Add Dan Clark as an API owner. [chromium/src : main]

16 views
Skip to first unread message

Chris Harrelson (Gerrit)

unread,
Feb 12, 2025, 3:58:10 PMFeb 12
to Vladimir Levin, blink-api-ow...@chromium.org
Attention needed from Vladimir Levin

Chris Harrelson has uploaded the change for review

Chris Harrelson would like Vladimir Levin to review this change.

Commit message

Add Dan Clark as an API owner.

Approved via consenseus at today's API owner meeting.
Change-Id: I28d85c9c42508fd5ef9ed1674f603b956a10b0aa

Change diff

diff --git a/third_party/blink/API_OWNERS b/third_party/blink/API_OWNERS
index b8c8b8d3..8747c9f 100644
--- a/third_party/blink/API_OWNERS
+++ b/third_party/blink/API_OWNERS
@@ -4,6 +4,7 @@
# See https://www.chromium.org/blink#new-features for details.
brat...@gmail.com
chri...@chromium.org
+dan...@microsoft.com
dom...@chromium.org
foo...@chromium.org
mike...@chromium.org
@@ -20,4 +21,4 @@
# oj...@chromium.org
# p...@chromium.org
# mk...@chromium.org
-# re...@igalia.com
\ No newline at end of file
+# re...@igalia.com

Change information

Files:
  • M third_party/blink/API_OWNERS
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Vladimir Levin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28d85c9c42508fd5ef9ed1674f603b956a10b0aa
Gerrit-Change-Number: 6259594
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Vladimir Levin (Gerrit)

unread,
Feb 12, 2025, 4:03:16 PMFeb 12
to Chris Harrelson, Chromium LUCI CQ, chromium...@chromium.org, blink-api-ow...@chromium.org, blink-...@chromium.org
Attention needed from Chris Harrelson

Vladimir Levin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28d85c9c42508fd5ef9ed1674f603b956a10b0aa
Gerrit-Change-Number: 6259594
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Feb 2025 21:02:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Yoav Weiss (@Shopify) (Gerrit)

unread,
Feb 12, 2025, 4:06:40 PMFeb 12
to Chris Harrelson, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, blink-api-ow...@chromium.org, blink-...@chromium.org
Attention needed from Chris Harrelson

Yoav Weiss (@Shopify) voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Harrelson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28d85c9c42508fd5ef9ed1674f603b956a10b0aa
Gerrit-Change-Number: 6259594
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Chris Harrelson <chri...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Feb 2025 21:05:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chris Harrelson (Gerrit)

unread,
Feb 12, 2025, 4:20:36 PMFeb 12
to Yoav Weiss (@Shopify), Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, blink-api-ow...@chromium.org, blink-...@chromium.org

Chris Harrelson voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28d85c9c42508fd5ef9ed1674f603b956a10b0aa
Gerrit-Change-Number: 6259594
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Feb 2025 21:20:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 12, 2025, 4:32:03 PMFeb 12
to Chris Harrelson, Yoav Weiss (@Shopify), Vladimir Levin, chromium...@chromium.org, blink-api-ow...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add Dan Clark as an API owner.

Approved via consenseus at today's API owner meeting.
Change-Id: I28d85c9c42508fd5ef9ed1674f603b956a10b0aa
Reviewed-by: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Reviewed-by: Vladimir Levin <vmp...@chromium.org>
Commit-Queue: Chris Harrelson <chri...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419517}
Files:
  • M third_party/blink/API_OWNERS
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Vladimir Levin, +1 by Yoav Weiss (@Shopify)
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I28d85c9c42508fd5ef9ed1674f603b956a10b0aa
Gerrit-Change-Number: 6259594
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Chris Harrelson <chri...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages