Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

Ask for a month of vendor review. [website : main]

478 views
Skip to first unread message

Jeffrey Yasskin (Gerrit)

unread,
Mar 28, 2024, 1:16:15 PM3/28/24
to Jeffrey Yasskin

Jeffrey Yasskin has uploaded the change for review

Commit message

Ask for a month of vendor review.

To match the month of TAG review we already ask for.
Change-Id: I96ebb8926993d44d2ef3b0eac4d054aea70122bc

Change diff

diff --git a/site/blink/launching-features/index.md b/site/blink/launching-features/index.md
index debe3cc..6c21b98 100644
--- a/site/blink/launching-features/index.md
+++ b/site/blink/launching-features/index.md
@@ -286,7 +286,8 @@
If you haven't already received [signals on their opinion of the
API](https://docs.google.com/document/d/1xkHRXnFS8GDqZi7E0SSbR3a7CZsGScdxPUWBsNgo-oo/edit#heading=h.tgzhprxcmw4u)
from other browser vendors and the web developer community, now is the time to
-pursue getting those signals.
+pursue getting those signals. You should ask at least a month ahead of sending
+an Intent to Ship, to give reviewers sufficient time for meaningful feedback.

You should also work with the documentation team to ensure your features will be
documented when shipped, and estimate when (in what milestone) you would like to
@@ -383,7 +384,8 @@
#### Step 6: Prepare to Ship {:#new-feature-prepare-to-ship}

By this stage, you need to have a complete specification available that matches
-what you have implemented, and you should have given the TAG at least a month to
+what you have implemented, and you should have given the TAG and [other
+browser vendors](https://bit.ly/blink-signals) at least a month to
comment on that specification. If you are a Googler you should get a final spec
review from your [spec mentor](/blink/spec-mentors), and discuss options for
moving your spec to a final standardization venue. You should get final signoff

Change information

Files:
  • M site/blink/launching-features/index.md
Change size: XS
Delta: 1 file changed, 4 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I96ebb8926993d44d2ef3b0eac4d054aea70122bc
Gerrit-Change-Number: 5403211
Gerrit-PatchSet: 1
Gerrit-Owner: Jeffrey Yasskin <jyas...@google.com>
unsatisfied_requirement
open
diffy

Jeffrey Yasskin

unread,
Mar 28, 2024, 1:20:06 PM3/28/24
to blink-api-owners-discuss, Jeffrey Yasskin (Gerrit), Jeffrey Yasskin
This explains the colors I'm using in https://github.com/GoogleChrome/chromium-dashboard/pull/3749 to warn about reviews that haven't been open long enough. Opinions are also welcome there about the 2-week/1-month thresholds I picked.

chromium-website-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)

unread,
Mar 28, 2024, 2:09:11 PM3/28/24
to Jeffrey Yasskin, Mike Taylor, Tricium
Commit message:
Ask for a month of vendor review.

To match the month of TAG review we already ask for.
Change-Id: I96ebb8926993d44d2ef3b0eac4d054aea70122bc
Auto-Submit: Jeffrey Yasskin <jyas...@google.com>
Reviewed-by: Mike Taylor <mike...@chromium.org>
Commit-Queue: Mike Taylor <mike...@chromium.org>
Files:
  • M site/blink/launching-features/index.md
Change size: XS
Delta: 1 file changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mike Taylor
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: website
Gerrit-Branch: main
Gerrit-Change-Id: I96ebb8926993d44d2ef3b0eac4d054aea70122bc
Gerrit-Change-Number: 5403211
Gerrit-PatchSet: 2
Gerrit-Owner: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Jeffrey Yasskin <jyas...@google.com>
Gerrit-Reviewer: Mike Taylor <mike...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages