Unexpected TrichromeLibrary64.apk size increase by 130KiB after a rebase

3 views
Skip to first unread message

Takashi Toyoshima

unread,
Sep 4, 2024, 8:41:13 AM9/4/24
to binar...@chromium.org
Hi binary-size members,

I'm seeing a curious binary size increase that only happened on ARM64 after a recent rebase, and I suspect something is wrong in the tool side.

The CL itself is just clean-ups that don't change the logic itself theoretically.

Here is the CL.

When I ran a try for the Patchset 3, it passed the  binary-size tests.
Normalized APK Size: 579 bytes (max is 16384 bytes)
Normalized APK Size (arm64): 10104 bytes (max is 65536 bytes)

Here is a cloned Patchset 3 that is completely same with the original, but base is a recent HEAD.

And the result is here.
Normalized APK Size: 675 bytes (max is 16384 bytes)
Normalized APK Size (arm64): 129876 bytes (max is 65536 bytes)

Binary size diffs are almost the same for 32-bits, but for 64-bits, the diff is almost 13 times of the previous result (10KiB vs 130KiB).

The builder page provides breakdowns via SuperSize HTML Diff, but it seems only for 32-bits.

Do you think this blocks my CL? Also, how can we investigate this problem?

--
Takashi Toyoshima
Software Engineer, Google

Takashi Toyoshima

unread,
Sep 5, 2024, 2:19:41 AM9/5/24
to binar...@chromium.org
Hi, here is an update.

The recent try with another rebase solved this problem.
Normalized APK Size: 587 bytes (max is 16384 bytes)
Normalized APK Size (arm64): 9720 bytes (max is 65536 bytes)

So, I will land my change (unless this problem happens again) 
Reply all
Reply to author
Forward
0 new messages