Unreasonable TrichromeLibrary64.apk size increase again

[TAMURA, Kent]

https://chromium-review.googlesource.com/c/chromium/src/+/5768295

This CL fails on APK Size bot.

The CL doesn't change any code logic, but changes many many function signatures.  I guess stale PGO data causes this increase.  Is it ok to ignore the size increase and merge the CL?

Name	Size Delta	Limit	Status
Android Binary Size	-4,595 bytes	+16,384 bytes	Allowed
Android Binary Size (arm64 high end) (TrichromeLibrary64.apk)	+753,052 bytes	+65,536 bytes	Not Allowed

--

TAMURA Kent
Software Engineer, Google

[Andrew Grieve]

Thanks, added it as a data point to this bug: https://g-issues.chromium.org/issues/344608183

Please LMK if the regression doesn't turn out to be a false positive.

I think this also underscores the importance of rolling PGO profiles to beta branches (which we currently do not do for Android,  for no good reason)

--
You received this message because you are subscribed to the Google Groups "binary-size" group.
To unsubscribe from this group and stop receiving emails from it, send an email to binary-size...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/binary-size/CAGH7WqEC327e-s%3D70vDzXsfMpLYh6hy%3DjGkGWTUgb9eBMjha8g%40mail.gmail.com.

[Peter Wen]

+Zhaoyang Li for WoA EngProd for impact of rolling PGO on branches.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/binary-size/CABiQX1U35cjsE_v-W-AeRsUq0N0wA2HOsLTiDk3dP4gz2oOG5g%40mail.gmail.com.