[rust png] Set default to `enable_rust_png = true` in GN args. [chromium/src : main]
4 views
Skip to first unread message
Łukasz Anforowicz (Gerrit)
Dec 10, 2024, 12:33:36 PM12/10/24
to binar...@chromium.org
Attention needed from Florin Malita
Łukasz Anforowicz has uploaded the change for review![]( "Open in Gerrit")
Commit message
[rust png] Set default to `enable_rust_png = true` in GN args.
This CL starts to actually build Rust PNG into the Chrome binary. It
also means that Rust-PNG-aware test-suites (e.g. `PNGCodecTest` in
`gfx_unittests` and `*PNGTests` in `blink_platform_unittests`) cover the
Rust PNG not only on Rust FYI bots, but also on the regular Chromium
CI/CQ. This CL is justified/motivated by the desire to prepare for
starting field trials - see the recent status update slidedeck [1] for
more details.
The binary size increase is discussed in the "Binary size" section of
the go/rusty-png-in-chromium-and-skia design doc [2]. Note that some of
the increase is expected to be temporary - it will be redeemed once the
new codec ships and the legacy `libpng` codec is removed.
[1] https://docs.google.com/presentation/d/1AXpg62xLaSXLZLTShSAMVZBhBnvDXUUaK8Tu4cy47VQ/edit?usp=sharing
[2] https://docs.google.com/document/d/1glx5ue5JDlCld5WzWgTOGK3wsMErQFnkY5N5Dsbi91Y/edit?usp=sharing#heading=h.m3sqlp5evinx
Binary-Size: See the commit description.
Fuchsia-Binary-Size: See the commit description.
Bug: 360375227
Change-Id: I3a94ba1e586a6ea7c2a25923b1e084fee32e49e4
Change diff
diff --git a/BUILD.gn b/BUILD.gn
index ebd779e..4d5c300 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -898,7 +898,7 @@
"//mojo/public/rust:mojo_rust_unittests",
]
}
- if (enable_rust_png) {
+ if (enable_rust_png && !is_cronet_build) {
deps += [ "//skia" ]
}
}
diff --git a/skia/skia.gni b/skia/skia.gni
index 3318337..e9694de 100644
--- a/skia/skia.gni
+++ b/skia/skia.gni
@@ -4,8 +4,10 @@
declare_args() {
# WIP attempt to replace `libpng` with Rust `png` crate.
+ # See https://crbug.com/40278281 for more details.
#
- # TODO(https://crbug.com/360375227): Default to true when ready to start A/B
- # experiments.
- enable_rust_png = false
+ # TODO(https://crbug.com/360375227): Either: 1) remove (if/when
+ # shipped) or 2) change back to `false` before branchpoint (if not
+ # ready for Beta/Stable yet).
+ enable_rust_png = true
}
Change information
Files:
- M BUILD.gn
- M skia/skia.gni
Change size: S
Delta: 2 files changed, 6 insertions(+), 4 deletions(-)
Related details
Attention is currently required from:
- Florin Malita
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Dec 10, 2024, 12:33:42 PM12/10/24
to Florin Malita, Daniel Dilan, Chromium LUCI CQ, chromium...@chromium.org, binar...@chromium.org
Attention needed from Florin Malita
Łukasz Anforowicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Łukasz Anforowicz . resolved
/cc binar...@chromium.org as an FYI (to transparently give a heads-up about the expected binary size increase)
Related details
Attention is currently required from:
- Florin Malita
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Florin Malita (Gerrit)
Dec 10, 2024, 12:55:32 PM12/10/24
to Łukasz Anforowicz, Daniel Dilan, Chromium LUCI CQ, chromium...@chromium.org, binar...@chromium.org
Attention needed from Łukasz Anforowicz
Florin Malita voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Dec 10, 2024, 12:57:35 PM12/10/24
to Andrew Grieve, Florin Malita, Daniel Dilan, Chromium LUCI CQ, chromium...@chromium.org, binar...@chromium.org
Attention needed from Andrew Grieve
Łukasz Anforowicz added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Łukasz Anforowicz . resolved
@agrieve, can you PTAL at the `//BUILD.gn` changes (as one of `//build/OWNERS
` + as a binary size watcher)?
Related details
Attention is currently required from:
- Andrew Grieve
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Grieve (Gerrit)
Dec 10, 2024, 1:01:09 PM12/10/24
to Łukasz Anforowicz, Andrew Grieve, Florin Malita, Daniel Dilan, Chromium LUCI CQ, chromium...@chromium.org, binar...@chromium.org
Attention needed from Łukasz Anforowicz
Andrew Grieve voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nico Weber (Gerrit)
Dec 10, 2024, 2:52:33 PM12/10/24
to Łukasz Anforowicz, Nico Weber, Andrew Grieve, Florin Malita, Daniel Dilan, Chromium LUCI CQ, chromium...@chromium.org, binar...@chromium.org
Attention needed from Łukasz Anforowicz
Nico Weber voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Łukasz Anforowicz
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Dec 11, 2024, 9:47:56 AM12/11/24
to Nico Weber, Andrew Grieve, Florin Malita, Daniel Dilan, Chromium LUCI CQ, chromium...@chromium.org, binar...@chromium.org
Łukasz Anforowicz voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Łukasz Anforowicz (Gerrit)
Dec 11, 2024, 10:17:30 AM12/11/24
to Nico Weber, Andrew Grieve, Florin Malita, Daniel Dilan, Chromium LUCI CQ, chromium...@chromium.org, binar...@chromium.org
Łukasz Anforowicz voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 11, 2024, 11:02:18 AM12/11/24
to Łukasz Anforowicz, Nico Weber, Andrew Grieve, Florin Malita, Daniel Dilan, chromium...@chromium.org, binar...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[rust png] Set default to `enable_rust_png = true` in GN args.
This CL starts to actually build Rust PNG into the Chrome binary. It
also means that Rust-PNG-aware test-suites (e.g. `PNGCodecTest` in
`gfx_unittests` and `*PNGTests` in `blink_platform_unittests`) cover the
Rust PNG not only on Rust FYI bots, but also on the regular Chromium
CI/CQ. This CL is justified/motivated by the desire to prepare for
starting field trials - see the recent status update slidedeck [1] for
more details.
The binary size increase is discussed in the "Binary size" section of
the go/rusty-png-in-chromium-and-skia design doc [2]. Note that some of
the increase is expected to be temporary - it will be redeemed once the
new codec ships and the legacy `libpng` codec is removed.
[1] https://docs.google.com/presentation/d/1AXpg62xLaSXLZLTShSAMVZBhBnvDXUUaK8Tu4cy47VQ/edit?usp=sharing
[2] https://docs.google.com/document/d/1glx5ue5JDlCld5WzWgTOGK3wsMErQFnkY5N5Dsbi91Y/edit?usp=sharing#heading=h.m3sqlp5evinx
Binary-Size: See the commit description.
Fuchsia-Binary-Size: See the commit description.
Bug: 360375227
Change-Id: I3a94ba1e586a6ea7c2a25923b1e084fee32e49e4
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Łukasz Anforowicz <luk...@chromium.org>
Reviewed-by: Nico Weber <tha...@chromium.org>
Reviewed-by: Florin Malita <fma...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1394856}
Files:
- M BUILD.gn
- M skia/skia.gni
Change size: S
Delta: 2 files changed, 6 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Florin Malita, +1 by Andrew Grieve, +1 by Nico Weber
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages