Large binary size increase from Blink feature flag change

[Kevin Babbitt]

Hi,

 

I have a CL that does nothing other than flipping a Blink feature flag from Experimental to Stable, but the binary size bot is failing with a size increase of ~40k. I looked at the breakdown, and it’s reporting most of the increase is coming from string resources. I’m stumped as to how this could be the case. Could someone please take a look and help clarify what’s going on?

 

CL: https://chromium-review.googlesource.com/c/chromium/src/+/5883497

Breakdown report: https://chrome-supersize.firebaseapp.com/viewer.html?load_url=https%3A%2F%2Fstorage.googleapis.com%2Fchromium-binary-size-trybot-results%2Fandroid-binary-size%2F2024%2F09%2F23%2F2032678%2Fsupersize_diff.sizediff#focus=20

 

Thanks

Kevin

 

[Andrew Grieve]

That's definitely a bug with the bots. It also shows a large amount of DEX (java) symbols changing. Filed: https://g-issues.chromium.org/issues/369178106

The size baselines update every ~45 minutes, so I'd just run it again and see what comes out.

Both of the attempts used the same baseline: 419dcaacd7c4db734e5938b459081f5f4d2b07a8 (One easy way to find this is by expanding the "Metadata" node in the size viewer)

--
You received this message because you are subscribed to the Google Groups "binary-size" group.
To unsubscribe from this group and stop receiving emails from it, send an email to binary-size...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/binary-size/PH0PR00MB11528BC1577257B37F8C8C6AC06F2%40PH0PR00MB1152.namprd00.prod.outlook.com.

[Kevin Babbitt]

Thanks Andrew! I’ve clicked Rerun, and if it fails again I’ll just tag it with Binary-Size and the bug URL.

 

Kevin