Adding Autofill Assistant to WebLayer - binary size

32 views
Skip to first unread message

Florian Gauger

unread,
Mar 16, 2022, 10:42:23 AM3/16/22
to binar...@chromium.org, Clark Duvall, Andrew Grieve, Autobot Runtime team, weblay...@google.com
Hi all,

We are working on implementing Autofill Assistant in WebLayer (dd). We have moved all code from //chrome to //components and we now have the first cl where we add all non-module build dependencies (crrev.com/c/3525116). This is quite a large increase in binary size:

Base Module Size: 35831 bytes (max is 16384 bytes)
Dex Methods Count: 728 methods (max is 50 methods)
Normalized APK Size: 143745 bytes (max is 16384 bytes)
Android Binary Size +143,745 bytes +16,384 bytes Not Allowed

We want to give a heads-up on this happening as well as ask if there is anything special we need to take care of before submitting this cl.

Thanks a lot!
Florian

Andrew Grieve

unread,
Mar 17, 2022, 10:15:23 AM3/17/22
to Florian Gauger, clank-webview, binary-size, Clark Duvall, Autobot Runtime team, weblay...@google.com
+clank-webview is what's growing here, so likely they'd be the ones to have concerns about this. Based on the supersize's report of autofill assistant's DFM, it's 200kb, but that's very much a lower bound (e.g. doesn't include size from your first CL).

I left a comment on your doc about why you'd want to do this, but wrt binary size, I don't think WebView has a size budget? It'd certainly be worth ensuring that none of the size increase ends up landing the base module vs. the weblayer module.
Reply all
Reply to author
Forward
0 new messages