Current browsingContext.create and script.invoke PRs

[Brandon Walderman]

Hi folks,

 

I did a pass through the current chromium-bidi PRs. I’m not sure I’m ready to sign off on browsingContext.create and script.invoke. I agree in principle with these PRs, but I’d like to see script.invoke spec’d first as well as buy-in from other vendors on the plan for both of these commands. I did sign off on the script.evaluate spec PR to hopefully move things forward. I’d also be happy with prefixing the current PRs as PROTO commands if that helps unblock things until these commands are merged into the spec. What do you think?

 

Thanks,

Brandon

[Mathias Bynens]

Agreed we shouldn’t land non-standard commands under a standard-looking name. Using PROTO for this purpose SGTM.

--
You received this message because you are subscribed to the Google Groups "bidi-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to bidi-dev+u...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/bidi-dev/SA1PR00MB1325F2F870A241D0F115FE35D8B29%40SA1PR00MB1325.namprd00.prod.outlook.com.
For more options, visit https://groups.google.com/a/chromium.org/d/optout.

[Maksim Sadym]

Agree. Having prefix `PROTO` is a great way to distinguish between already specified and experimental commands and events. I added the prefix to not yet specified commands:

• `script.invoke` implementation
• `create` and `navigate.browsingContext`