Issue 1489785 in chromium: Flag expired : back-forward-cache is expired in M120

278 views
Skip to first unread message

chrome-branch-day via monorail

unread,
Oct 5, 2023, 3:36:13 PM10/5/23
to bfcac...@chromium.org

Comment #1 on issue 1489785 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : back-forward-cache is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489785#c1

This flag has been marked as expiring in M120 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M120 branch you're all set; if you do it after the M120 branch you'll need to merge that CL to the M120 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

Git Watcher via monorail

unread,
Oct 17, 2023, 6:24:12 AM10/17/23
to bfcac...@chromium.org
Updates:
Status: Fixed

Comment #2 on issue 1489785 by Git Watcher: Flag expired : back-forward-cache is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489785#c2

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/b8a8542188b44e527c08f9c7897f4a511fe0ed98

commit b8a8542188b44e527c08f9c7897f4a511fe0ed98
Author: Fergal Daly <fer...@chromium.org>
Date: Tue Oct 17 10:23:37 2023

Extend back-forward-cache flag until M130.

We still see bug reports where it was useful to be able to disable
this to confirm that BFCache is the problem.

Fixed: 1489785
Change-Id: Icc750dc5ec594e6ed046b1563b9c503bc9c45d2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4943295
Auto-Submit: Fergal Daly <fer...@chromium.org>
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Commit-Queue: Rakina Zata Amni <rak...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210741}

[modify] https://crrev.com/b8a8542188b44e527c08f9c7897f4a511fe0ed98/chrome/browser/flag-metadata.json
Reply all
Reply to author
Forward
0 new messages