Issue 1385008 in chromium: Remove expired histograms Animation.AnimationWorklet.MutateDuration

[histogram-eraser via monorail]

Status: Untriaged
Owner: ----
CC: animati...@chromium.org, maj...@chromium.org, kev...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>Compositing>Animation
Pri: 3
Type: Task

New issue 1385008 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Animation.AnimationWorklet.MutateDuration
https://bugs.chromium.org/p/chromium/issues/detail?id=1385008

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Animation.AnimationWorklet.MutateDuration (expired as of 2021-01-01)

The following code locations were found:

third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc:182:
"Animation.AnimationWorklet.MutateDuration", timer.Elapsed(),

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- Mark the bug as Available to confirm that the histograms can be removed.
- Annotate the histograms as intentionally expired (see above) and update the bug.

Available bugs will be added to the Code Health Rotation to have the code cleaned up by participants in the rotation.

If the bug is left in the Untriaged state without any activity by histogram owners, it will be marked as Available after approximately two weeks.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[takemoto via monorail]

Updates:
Labels: Pri-2
Owner: sun...@chromium.org
Status: Assigned

Comment #1 on issue 1385008 by take...@google.com: Remove expired histograms Animation.AnimationWorklet.MutateDuration
https://bugs.chromium.org/p/chromium/issues/detail?id=1385008#c1

sunnyps@ can you triage further?

[Git Watcher via monorail]

Comment #4 on issue 1385008 by Git Watcher: Remove expired histograms Animation.AnimationWorklet.MutateDuration
https://bugs.chromium.org/p/chromium/issues/detail?id=1385008#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/77cf6288cbdd9149b3814db7a99a9d0ec95aefd5

commit 77cf6288cbdd9149b3814db7a99a9d0ec95aefd5
Author: Jonathan Ross <jon...@chromium.org>
Date: Wed Sep 20 19:45:13 2023

Remove expired histograms Animation.AnimationWorklet.MutateDuration

Metric long expired, looking to remove it.

OBSOLETE_HISTOGRAM=Animation.AnimationWorklet.MutateDuration long
expired

Bug: 1385008
Change-Id: I2c19f6674d41b8d1739d3e2c8cf4c0a1cbf6908b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4873649
Reviewed-by: Robert Flack <fla...@chromium.org>
Commit-Queue: Jonathan Ross <jon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1199179}

[modify] https://crrev.com/77cf6288cbdd9149b3814db7a99a9d0ec95aefd5/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc
[modify] https://crrev.com/77cf6288cbdd9149b3814db7a99a9d0ec95aefd5/tools/metrics/histograms/metadata/others/histograms.xml

[jonross via monorail]

Updates:
Status: Fixed

Comment #5 on issue 1385008 by jon...@chromium.org: Remove expired histograms Animation.AnimationWorklet.MutateDuration
https://bugs.chromium.org/p/chromium/issues/detail?id=1385008#c5

(No comment was entered for this change.)