Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 12/18/11 8:13 PM | Status: Untriaged Owner: ---- CC: dgr...@chromium.org, jsb...@chromium.org Labels: Type-Bug Pri-2 Area-WebKit ImportantForOffline Feature-IndexedDB New issue 108012 by ericbide...@chromium.org: IndexedDB should support FF has this implemented: I'm currently seeing Mac, 18.0.974.0 canary crash when trying to .put() a |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 12/19/11 7:50 PM | Comment #2 on issue 108012 by jsb...@chromium.org: IndexedDB should support
File via the FileSystem API appears to be working correctly, except that ericbidelman@ - I don't suppose you have a repro handy? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 12/20/11 12:09 AM | Comment #3 on issue 108012 by ericbide...@chromium.org: IndexedDB should
Sure. Attached has code that's compatible with FF (though not currently Again: Mac OSX, 10.6.8 17.0.963.12 dev Attachments: |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 12/20/11 2:27 PM | Comment #5 on issue 108012 by jsb...@chromium.org: IndexedDB should support
The important bit in the repro is that the object store has a keyPath and |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/20/12 1:55 PM | Comment #11 on issue 108012 by jsb...@chromium.org: IndexedDB should
With this patch in place: diff --git a/Source/WebCore/bindings/v8/V8DOMWrapper.cpp
BlobData* blob_data = GetBlobDataFromUrl(src_url);
Trace/breakpoint trap |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/24/12 4:46 PM | Updates: Cc: er...@chromium.org Comment #20 on issue 108012 by jsb...@chromium.org: IndexedDB should
(No comment was entered for this change.) |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/23/12 3:34 PM | Updates:
Owner: er...@chromium.org Comment #22 on issue 108012 by jsb...@chromium.org: IndexedDB should |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/12/12 5:52 PM | Updates:
Cc: jia...@chromium.org Comment #23 on issue 108012 by dim...@chromium.org: IndexedDB should support storing File/Blob objectsWe hit this trying to build an offline app. We pull avatar images using XHR (as blobs) then mint URLs for those blobs and set it to img.src. To have an offline app, we want to store those in IDB. Eric, what's your prognosis? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/1/12 9:35 AM | Comment #28 on issue 108012 by alecfl...@chromium.org: IndexedDB should support storing File/Blob objectsUnfortunately, we are not actively working on a fix for this right now - we do want to add blob support, but we don't have the resources to work on this at least for a month or so. We will do our best to update this bug as this changes. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 9/21/12 3:57 PM | Comment #30 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 There's any progress with this issue? At least on any nightly or personal branch that i would be able to download and compile (i'm using Ubuntu, if that's matters)? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 9:41 AM | Comment #32 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsNow let’s see if I cannot motivate you why this would be a great addition. I workin in a R&D firm on BigData. CouchDB and other NoSQL are ideal for storing the loosely structured mix of imagery, video, meta-info , signals data, etc. Mobile users (laptops, tablets, phones) need to grab snippets of this and work offline for periods, and then re-connect. I need something for NoSQL on the client side. Think of massive multiplayer outdoor collaboration gaming, where the game database is stored on the cloud and people are constantly connecting and disconnecting. The CouchDB central store is where all the loosely collected imagery, audio, and derived meta-information (JSON objects )is collected and processed. So when you do add it, can you make sure it also works for Chrome for Android? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 9:56 AM | Comment #33 on issue 108012 by jsb...@chromium.org: IndexedDB should support storing File/Blob objectsWe don't need any motivation, Blob support has just been below other work in the priority queue. It's bubbling it's way slowly to the top, closer all the time. Supporting it on Android is important too. Hopefully we'll have news soon. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 10:05 AM | Comment #34 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 Could you be able to give a (orientative) release? v26? Maybe v27? After v27? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 10:36 AM | Comment #35 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsGood to know you are motivated, I have the flexibility to wait. But I do see comments here about serializing/deserializing the blob. I don't know if FireFox is doing that, but if at all possible, I would rather see native binary storage if possible. I am talking about blobs in the 10KB size range, but I would have several hundred, and I need very fast retrieval. Otherwise, I will do a polyfill that uses FileSystemAPI. (Perhaps you can do the same, and store blobs in a hidden directory there?) |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 10:40 AM | Comment #36 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsIn case I was not clear, I meant store a reference in the IDB entry, with metadata and a pointer to the FileSystem binary blob. (Just one possible way to do this). |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 10:57 AM | Comment #37 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 I would be very interested in your polyfill, since I need to work with several megabytes files with access and modification of chunks and using the FileSystem API to fix IndexedDB would be great. Currently I'm using an on-memory IndexedDB implementation and modifying full blobs just to circunvent temporaly this issue and don't have the files stored it's fairly user unfriendly... I didn't be able to figure out how to create a polyfill to add support for File and Blob objects using FileSystem API (I thought about it some months ago), but if you have some idea and needs help or testing don't doubt in call me :-) By the way, here is my project: http:// github.com/piranna/ShareIt (I'm using IndexedDB for cache since it's available both for Firefox and Chrome, but first versions were using FileSystem API). |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 11:18 AM | Comment #38 on issue 108012 by ericbide...@google.com: IndexedDB should support storing File/Blob objectsI made the opposite polyfill, idb.filesystem.js (http://ericbidelman.tumblr.com/post/21649963613/idb-filesystem-js-bringing-the-html5-filesystem-api) as a polyfill for the FS API. It uses IDB under the hood for FF and other implementations that support saving Blobs to IDB. You could try |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 11:25 AM | Comment #39 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 I did, indeed :-D Also I improved your FileWriter class adding seek() and random write() according to specification that I have been using sucesfully the last months. You have a pull-request with the changes on GitHub :-) |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/3/13 12:06 PM | Comment #40 on issue 108012 by ericbide...@chromium.org: IndexedDB should support storing File/Blob objectsI must have missed that. I'll take a look. Thanks! |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/10/13 2:31 PM | Comment #44 on issue 108012 by cos...@gmail.com: IndexedDB should support storing File/Blob objects@piranna: Blob support is sufficient for caching data. If you have a file, you can read it into an ArrayBuffer and make a Blob out of that, then store the Blob :D Also, I was a bit wrong above. Building a Blob out of a binary string requires going through an Uint8Array. (set byte i to string.charCodeAt(i) & 0xff, for i in 0...string.length) |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/10/13 2:49 PM | Comment #45 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 I'm using it just this way to cache downloading content... :-D copy... :-/ |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/10/13 7:37 PM | Comment #46 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsFor my app, "Building a Blob out of a binary string requires going through an Uint8Array" seems a bit slow and kludgy. What about the idea of writing the blob to unique place in the FileSystem (/blobstore/key ), and then storing the reference in the objectStore in the format {blob-key: xxx, path: xxxx } |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/10/13 7:48 PM | Comment #47 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 I found this way better... In fact Firefox do it this way, Blob and Javascript-generated File objects inserted on IndexedDB are stored directly on the underlying computer filesystem (or at least I read that...). How could be done a polyfill for this? Override the ObjectStore methods and inspect each object attribute to detect when one of them is a Blob object? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/10/13 11:49 PM | Comment #48 on issue 108012 by benjamin...@gmail.com: IndexedDB should support storing File/Blob objectsYes that`s right in Firefox blobs are stored in the filesystem and you can even go there and open them. So i was able to download a movie to the IndexedDB as a blob and then in the filesystem open it with VLC. BTW the same thing works in IE10. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/11/13 3:37 AM | Comment #49 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 So it would be great to do a polyfill for this... At least I would have persistence and don't need to use my in-memory implementation... :-P Sent from my Android cell phone, please forgive the lack of format on the text, and my fat thumbs :-P El 11/01/2013 08:46, <chro...@googlecode.com> escribi�: |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 2/1/13 8:08 AM | Comment #50 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 This is just a FYI. Perhaps it will help in your design. I did a polyfill to store the results in the FileSystem. See below for the full results. But to summarize. It works. But performance is best in IE, which stores the results in the DB. FireFox is very poor. BTW, when I increase the number of files to 6,760 (220MB). I start getting all sorts of xhr error code: 0 errors, and it does not fetch all the PNG files (even though they are there). IE10 works fine with 220MB of files, and finishes in 15s! Superb. Results Offline blob cache for PNG slippy maps Testing 171 PNG files (total of 3.2MB) Platforms tested: Chrome v24, FireFox 18, IE 10 Should also work with Chrome & FF for Android Fetch from web server using XHR2 (supported on almost all browsers) for blob download from web server I went with XHR2-Lib by Phil Parsons, which is very much like JQUERY .ajax() https://github.com/p-m-p/xhr2-lib Storage IndexedDB for IE and FireFox Chrome: Polyfill (blob stored using FileSystem API, reference kept in IndexedDB) polyfill A Must read article on "How the browsers store IndexedDB data" http://www.aaron-powell.com/web/indexeddb-storage Note: FireFox uses SQLlite for the NOSQL IndexedDB. That might be the reason for the slow performance. (blobs stored separately) Note: Microsoft IE uses the extensible storage engine: http://en.wikipedia.org/wiki/Extensible_Storage_Engine Note: Chrome uses LevelDB http://code.google.com/p/leveldb/ Display I am using Leaflet http://leafletjs.com/ to show the map tiles I used the functional tile layer plugin by Ishmael Smyrnow for fetching the tile layer from the DB https://github.com/ismyrnow/Leaflet.functionaltilelayer I compared the DB-based tiles layer with a purely local (localhost://) storage There is no noticeable difference in performance! between using IndexedDB and local files! Results Chrome: Fetch (6.551s), Store (8.247s), Total Elapsed Time: (13.714s) FireFox: Fetch (0.422s), Store (31.519s), Total Elapsed Time: (32.836s) IE 10: Fetch (0.668s), Store: (0.896s), Total Elapsed Time: (3.758s) |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 2/11/13 7:31 AM | Comment #51 on issue 108012 by d...@arandomurl.com: IndexedDB should support storing File/Blob objectsFunnily in relation to #32 I have run into this while developing an in browser version of CouchDB (PouchDB) The problem with polyfilling this with the filesystem api is that you lose transactional semantics on document writes, we need to refcount and do other such things when we write a document and when we break the event loop to store things on the filesystem we get interleaved reads a lot of invalid transaction objects. It would be nice to see this fixed (alternatively I have heard that this isnt a popular idea but being able to open a transaction with an option to wait for it to be explicitly close would be just as good) |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 2/11/13 2:39 PM | Comment #52 on issue 108012 by jsb...@chromium.org: IndexedDB should support storing File/Blob objectsFYI, you can keep a transaction alive indefinitely by doing something like: var keep_alive = true; // set to false to allow transaction to finish var transaction; // the transaction to keep alive var store = 'store name'; // some object store in scope (function keepAlive() { if (keep_alive) { transaction.objectStore(store).get(0).onsuccess = keepAlive; } }()); |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/26/13 8:14 AM | Comment #56 on issue 108012 by Florian....@gmail.com: IndexedDB should support storing File/Blob objects@cos...@gmail.com Which solution are you using to store and read your videos ? (#42) It tried using BinaryString for Chrome, but I don't succeed in converting string back to blob using your tip with Uint8Array(#44) Do you have a working example somewhere ? Thanks. -- You received this message because this project is configured to send all issue notifications to this address. You may adjust your notification preferences at: https://code.google.com/hosting/settings |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/26/13 11:18 AM | Comment #57 on issue 108012 by ju.carr...@gmail.com: IndexedDB should support storing File/Blob objectsYes, +1 for #56. I would love to see that as well. Thanks guys! |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/11/13 10:23 AM | Comment #61 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsAny status updates on when this will be resolved? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/12/13 8:58 AM | Comment #63 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsPouchDB now supports native binary blob storage in the web client IndexedDB except in the case of Chrome (where it has to fall back to base64 storage). |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/29/13 9:56 AM | Comment #64 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsI have created a online demo "JSFIDDLE-Like" at: http://codepen.io/DrYSG/pen/hpqoD which uses XHR2 to fetch binary blobs, and stores them in PouchDB (which uses IndexedDB). PouchDB is currently converting the binary blobs to Base64. But it would be nice if Chrome supported native binary blobs in IDB. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/29/13 9:57 AM | Comment #65 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsOh yes, to operate, fist delete the old database, then reload, then press download tiles. You will statistics as it runs, and an image fetched from IDB when it is done. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/29/13 10:28 AM | Comment #66 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 There's currently any way to store File objects instead of Blobs? I'm interested about storing references to the location of files added by the user from the hard disk... Also, anybody know if it's supported to store FileEntries and specially DirEntries? El 29/05/2013 18:26, <chro...@googlecode.com> escribi�: |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/29/13 12:27 PM | Comment #67 on issue 108012 by er...@chromium.org: IndexedDB should support storing File/Blob objects@piranna: IDB should support anything covered by the Structured Clone algorithm. So once I get this feature in, it will support Blobs, Files, and FileLists. It will not support FileEntry or DirEntry; it's not clear what exactly that would mean w.r.t. permissions, file lifetimes, etc., and the FileSystem spec isn't likely to see a lot of further development in the near term. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/29/13 2:06 PM | Comment #68 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 Good to know. Seems that Mozilla is doing a copy of the File object instead of maintain references to the original ones as according to the spec, is this still true or files will be copied? I'm willing not... El 29/05/2013 21:21, <chro...@googlecode.com> escribi�: |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/12/13 9:23 AM | Comment #71 on issue 108012 by Toneti...@gmail.com: IndexedDB should support storing File/Blob objectsAny new update?? I think this is a feature that many people are waiting.. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/12/13 2:53 AM | Comment #73 on issue 108012 by downch...@gmail.com: IndexedDB should support storing File/Blob objectsChrome packaged apps now have a retain method for retaining access to filesystem entries. With those items as well as with standard FileSystem entries, you would simply store the URL reference in IndexedDB if you're looking to reference the FileEntry/DirectoryEntry. A Mozilla developer has started suggesting a new filesystem API, though there's little commitment. Blob in IndexedDB still seems to be stalled. Use the FileSystem API and string references for the time being. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/12/13 3:13 AM | Comment #74 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 I would like it to be a real web application, but until the Mozilla suggested filesystem API gets some progress, definitely using packaged apps on Chrome and DeviceStorage on Firefox would be a solution... :-) Thanks for your suggestion! :-D |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/12/13 7:58 AM | Comment #75 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsin note #50 https://code.google.com/p/chromium/issues/detail?id=108012#c50, I indicate that I already tried the hybrid IDB/FileSystem approach (blobs in the FileSystem). It does work, but not as efficiently (performance) or maintainence free (you have to do your own folder load balancing, cleanup, etc.) So I am still hoping that what er...@cromiumum.org says in #69 https://code.google.com/p/chromium/issues/detail?id=108012#c69 is true, and that the full IDB spec will be implemented (IE10 and IE11 does, *hint* *hint*) and their IDB is very very fast. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/20/13 7:47 AM | Comment #76 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsI have created another IDB download test. This one uses PouchDB (CouchDB for the browser and mobiles) and it uses IDB underneath. IE11 and FF have native blob support. Chrome is getting a slight performance hit since it does not. 1. Run http://codepen.io/DrYSG/pen/kdzft 2. Press [Download] It will load 171 JPG map tiles via XHR2 and stored them in PouchDB (The table tells you if Binary or Base64 (Chrome) is being used in PouchDB). [If you want to try with more JPG and get a higher resolution map (600+ tiles) then FORK and change line 1 to var serverURL = "https://googledrive.com/host/0B2Ay-nw1QSW2SHhjR0VBZXE2bUU/LittleBlueMarble/" ] You can also [DELETE] the PouchDB databases. Please tell me what performance you see. Behind my firewalls I am getting about 24 Files/Sec. in IE11 and 22 Files/sec in Chrome. One thing to know about this demo, is that it will only spawn "100 threads" of XHR2 download/IDB PUT). This is because of a issue https://code.google.com/p/chromium/issues/detail?id=244910 that I had to solve with throttling how fast Chrome downloads. You can easily FORK the source and try different numbers of threads. Also tell me if IE10 is working for you. FireFox has a real poor IDB (an overlay of WebSQL, and no SPDY support, so performance is very very poor) You can then look at the full downloaded map by going to: http://codepen.io/DrYSG/pen/mcdCq |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/20/13 7:52 AM | Comment #77 on issue 108012 by raymondc...@gmail.com: IndexedDB should support storing File/Blob objectsThis is the first time I've seen someone say Firefox's IDB implementation is an overlay of WebSQL. I don't believe this is true. Do you have a source for that? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/20/13 8:11 AM | Comment #78 on issue 108012 by ygutfre...@gmail.com: IndexedDB should support storing File/Blob objectsLet me be more precise. FF uses SQLlite 1. http://www.aaron-powell.com/posts/2012-10-05-indexeddb-storage.html 2. http://stackoverflow.com/questions/9846013/how-to-view-indexeddb-content-in-firefox This allows them to maintain legacy support of the WebSQL API, and also support IDB. But what I think I am finding is that non-SQL to a relational DB is not working well. (but maybe the real issue is lack of XHR2 and SPDY or something in their thread model) I really don't know. All I know is that Chrome does some amazing things in HTTP fetches pipeline. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/20/13 8:23 AM | Comment #79 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 The usage of base64 is thanks to the hack someone posted on this issue some months ago, or how it's done? If so, I would be interested on take a look on it... |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/20/13 9:02 AM | Comment #80 on issue 108012 by ce...@seznam.cz: IndexedDB should support storing File/Blob objects@78 ... just for the sake of completness. Firefox has never supported WebSQL, so there is no need to provide legacy support. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/20/13 1:55 PM | Comment #82 on issue 108012 by piranna: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012 Thanks for the advice. So, seems the storage of Blobs is not transparent, isn't it? El 20/08/2013 20:29, <chro...@googlecode.com> escribi�: |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 10/16/13 8:49 AM | Comment #85 on issue 108012 by vitteaym...@gmail.com: IndexedDB should support storing File/Blob objectsAs mentioned in the thread this requires some fundamental changes but can we have an idea when this will work (months, years...)? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 12/8/13 10:26 AM | Updates:
Cc: mlamo...@chromium.org Comment #89 on issue 108012 by mlamo...@chromium.org: IndexedDB should support storing File/Blob objects(No comment was entered for this change.) |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/22/14 7:55 PM | Updates:
Cc: arthur...@chromium.org Comment #90 on issue 108012 by dpa...@chromium.org: IndexedDB should |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 1/23/14 3:50 AM | Comment #91 on issue 108012 by vitteaym...@gmail.com: IndexedDB should support storing File/Blob objectsAny news when this is coming? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/3/14 10:26 PM | Comment #92 on issue 108012 by mathieu....@matbee.com: IndexedDB should support storing File/Blob objectsAnything? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/4/14 12:35 AM | Comment #93 on issue 108012 by bert...@gmail.com: IndexedDB should support storing File/Blob objectsJust finishing a project without it, perverting filesystem and localstorage to work around this bug... Please, fix this |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/13/14 11:46 PM | Comment #96 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c96 ------------------------------------------------------------------ r257044 | er...@chromium.org | 2014-03-14T06:37:40.455342Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.cc?r1=257044&r2=257043&pathrev=257044 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.h?r1=257044&r2=257043&pathrev=257044 Add the leveldb coding changes for IDB blob support. BUG=108012 Review URL: https://codereview.chromium.org/198133002 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/13/14 11:47 PM | Comment #97 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c97 ------------------------------------------------------------------ r257045 | er...@chromium.org | 2014-03-14T06:39:45.105412Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/leveldb/leveldb_transaction.h?r1=257045&r2=257044&pathrev=257045 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=257045&r2=257044&pathrev=257045 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/leveldb/leveldb_transaction.cc?r1=257045&r2=257044&pathrev=257045 Change LevelDBWriteOnlyTransaction to be writeable, and change its name to LevelDBDirectTransaction. BUG=108012 R=cmumford,jsbell Review URL: https://codereview.chromium.org/198243002 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/17/14 6:47 PM | Comment #99 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c99 ------------------------------------------------------------------ r257568 | er...@chromium.org | 2014-03-18T01:20:59.385466Z Changed paths: A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_pending_connection.h?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_database.h?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory_unittest.cc?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory.cc?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory.h?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/leveldb/leveldb_transaction.cc?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_unittest.cc?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_database_unittest.cc?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_dispatcher_host.cc?r1=257568&r2=257567&pathrev=257568 A http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_pending_connection.cc?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/content_browser.gypi?r1=257568&r2=257567&pathrev=257568 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_database.cc?r1=257568&r2=257567&pathrev=257568 Added IndexedDBPendingConnection to group up a bunch of parameters that get passed around together. This includes a convenience method CreateConnection in IndexedDBDatabase.cc that's not strictly needed for this change, but makes the merge of other related CLs easier later. BUG=108012 R=cmumford,jsbell Review URL: https://codereview.chromium.org/198223002 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/20/14 1:48 AM | Comment #104 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c104 ------------------------------------------------------------------ r258256 | pneu...@chromium.org | 2014-03-20T08:42:18.728419Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/media_galleries/fileapi/media_file_system_backend.cc?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/file_stream_writer.h?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.cc?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/isolated_file_system_backend.cc?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/local_file_stream_writer_unittest.cc?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/local_file_stream_writer.cc?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/fileapi/file_system_backend.cc?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/local_file_stream_writer.h?r1=258256&r2=258255&pathrev=258256 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/sandbox_file_stream_writer.cc?r1=258256&r2=258255&pathrev=258256 Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new (https://codereview.chromium.org/197233008/) Reason for revert: Best guess that this broke SyncFileSystemApiTest.WriteFileThenGetUsage on XP Tests(1). http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/30601/steps/browser_tests/logs/WriteFileThenGetUsage If not, we can just re-revert or reland it after a few cycles. Original issue's description: > Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating > new files as well as writing to existing files. > See https://codereview.chromium.org/18023022/ for context; this is needed > by upcoming IDB Blob support. > Tzik, please do primary review for filesystem; Kinaba, please review as > ChromeOS owner. > BUG=108012 > R=kinaba,tzik > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258120 TBR=kin...@chromium.org,tz...@chromium.org,er...@chromium.org NOTREECHECKS=true NOTRY=true BUG=108012 Review URL: https://codereview.chromium.org/206073006 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 3/20/14 2:15 AM | Comment #105 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c105 ------------------------------------------------------------------ r258259 | pneu...@chromium.org | 2014-03-20T09:11:36.043510Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/sandbox_file_stream_writer.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/media_galleries/fileapi/media_file_system_backend.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/file_stream_writer.h?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/drive/fileapi/webkit_file_stream_writer_impl.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/isolated_file_system_backend.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/local_file_stream_writer_unittest.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/local_file_stream_writer.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/fileapi/file_system_backend.cc?r1=258259&r2=258258&pathrev=258259 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/fileapi/local_file_stream_writer.h?r1=258259&r2=258258&pathrev=258259 Revert of Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to allow creating new (https://codereview.chromium.org/206073006/) Reason for revert: Sorry, I looked through this CL in more detail and it seems that it doesn't change any behavior. Re-reverting this one and instead trying crrev.com/258064 Original issue's description: > Revert of Add a parameter to FileStreamWriter::CreateForLocalFile to> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258256 TBR=kin...@chromium.org,tz...@chromium.org,er...@chromium.org NOTREECHECKS=true NOTRY=true BUG=108012 Review URL: https://codereview.chromium.org/206083004 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/8/14 9:18 PM | Comment #108 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c108 ------------------------------------------------------------------ r262608 | er...@chromium.org | 2014-04-09T04:04:15.634309Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/indexed_db_dispatcher_unittest.cc?r1=262608&r2=262607&pathrev=262608 M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/indexed_db_dispatcher.cc?r1=262608&r2=262607&pathrev=262608 M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/indexed_db_dispatcher.h?r1=262608&r2=262607&pathrev=262608 M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/indexed_db/indexed_db_messages.h?r1=262608&r2=262607&pathrev=262608 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_callbacks.cc?r1=262608&r2=262607&pathrev=262608 New IPC message parameters for IDB/Blob support. BUG=108012 Review URL: https://codereview.chromium.org/227693008 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/9/14 2:45 AM | Comment #109 on issue 108012 by shraddha...@gmail.com: IndexedDB should support storing File/Blob objectsAny news on expected release date for blob feature in chrome? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/14/14 12:37 PM | Comment #113 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c113 ------------------------------------------------------------------ r263693 | er...@chromium.org | 2014-04-14T19:04:35.859718Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_dispatcher_host.cc?r1=263693&r2=263692&pathrev=263693 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/renderer_host/render_process_host_impl.cc?r1=263693&r2=263692&pathrev=263693 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_dispatcher_host.h?r1=263693&r2=263692&pathrev=263693 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory_unittest.cc?r1=263693&r2=263692&pathrev=263693 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory.cc?r1=263693&r2=263692&pathrev=263693 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory.h?r1=263693&r2=263692&pathrev=263693 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_unittest.cc?r1=263693&r2=263692&pathrev=263693 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/worker_host/worker_process_host.cc?r1=263693&r2=263692&pathrev=263693 Plumb request_context, ipc_process_id, and blob_storage_context through to where they'll be needed. BUG=108012 Review URL: https://codereview.chromium.org/229623002 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/17/14 10:25 PM | Comment #115 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c115 ------------------------------------------------------------------ r264728 | er...@chromium.org | 2014-04-18T04:58:03.753933Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_callbacks.cc?r1=264728&r2=264727&pathrev=264728 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_callbacks.h?r1=264728&r2=264727&pathrev=264728 Complete registration of blobs before sending back an indexed DB value that contains them. BUG=108012 Review URL: https://codereview.chromium.org/238043007 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/28/14 3:42 PM | Comment #117 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c117 ------------------------------------------------------------------ r266677 | er...@chromium.org | 2014-04-28T22:38:16.895157Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/indexed_db_dispatcher_unittest.cc?r1=266677&r2=266676&pathrev=266677 M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/webidbcursor_impl_unittest.cc?r1=266677&r2=266676&pathrev=266677 M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/indexed_db_dispatcher.cc?r1=266677&r2=266676&pathrev=266677 M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/webidbcursor_impl.cc?r1=266677&r2=266676&pathrev=266677 M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/indexed_db_dispatcher.h?r1=266677&r2=266676&pathrev=266677 M http://src.chromium.org/viewvc/chrome/trunk/src/content/child/indexed_db/webidbcursor_impl.h?r1=266677&r2=266676&pathrev=266677 The chromium-side backchannel plumbing for blobs in IDB. This requires https://codereview.chromium.org/235933013/. BUG=108012 Review URL: https://codereview.chromium.org/240003010 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/28/14 3:44 PM | Updates:
Labels: merge-merged-git-svn Comment #118 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c118 The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63cf86df70fe7ae902810213b44958eb165dbe00 commit 63cf86df70fe7ae902810213b44958eb165dbe00 Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Mon Apr 28 22:38:16 2014 +0000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266677 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/29/14 4:04 AM | Comment #119 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c119 https://chromium.googlesource.com/chromium/src.git/+/8e215a665c1591ce9230f9124398badd20a58a8c commit 8e215a665c1591ce9230f9124398badd20a58a8c Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Tue Apr 29 09:57:07 2014 +0000 Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. BUG=108012 Review URL: https://codereview.chromium.org/259773006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266817 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/29/14 4:08 AM | Comment #120 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c120 ------------------------------------------------------------------ r266817 | er...@chromium.org | 2014-04-29T09:57:07.086130Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_data_handle.cc?r1=266817&r2=266816&pathrev=266817 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_data_handle.h?r1=266817&r2=266816&pathrev=266817 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/fileapi/blob_storage_context_unittest.cc?r1=266817&r2=266816&pathrev=266817 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_storage_context.h?r1=266817&r2=266816&pathrev=266817 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/29/14 11:07 AM | Comment #123 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c123 ------------------------------------------------------------------ r266916 | er...@chromium.org | 2014-04-29T17:54:35.167742Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory.cc?r1=266916&r2=266915&pathrev=266916 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=266916&r2=266915&pathrev=266916 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=266916&r2=266915&pathrev=266916 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_fake_backing_store.cc?r1=266916&r2=266915&pathrev=266916 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc?r1=266916&r2=266915&pathrev=266916 Add blob-writing functionality [as yet un-called] to IDB's backend. BUG=108012 R=cmum...@chromium.org, jsb...@chromium.org Review URL: https://codereview.chromium.org/240003011 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/29/14 11:13 AM | Comment #124 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c124 https://chromium.googlesource.com/chromium/src.git/+/de624f8b5de362b1d509f80d00701660abf0ac93 commit de624f8b5de362b1d509f80d00701660abf0ac93 Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Tue Apr 29 17:54:35 2014 +0000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266916 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/29/14 7:17 PM | Comment #125 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c125 ------------------------------------------------------------------ r267031 | er...@chromium.org | 2014-04-30T01:34:18.933655Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory_unittest.cc?r1=267031&r2=267030&pathrev=267031 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory.cc?r1=267031&r2=267030&pathrev=267031 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_factory.h?r1=267031&r2=267030&pathrev=267031 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=267031&r2=267030&pathrev=267031 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=267031&r2=267030&pathrev=267031 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc?r1=267031&r2=267030&pathrev=267031 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_dispatcher_host.cc?r1=267031&r2=267030&pathrev=267031 Track which IndexedDBBackingStores have been opened since boot. This way we'll know which need to have their live blob journals cleaned, once blob support is in. This has a small overlap with https://codereview.chromium.org/240003011/ [currently in the commit queue] for ease of merging. However, it also fixes a bug in that CL in which GetDatabaseNames didn't have the request_context parameter. BUG=108012 Review URL: https://codereview.chromium.org/259063004 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/29/14 7:22 PM | Comment #126 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c126 https://chromium.googlesource.com/chromium/src.git/+/8b9db116bda68414d122b35bdebb43ac42ef4d7d commit 8b9db116bda68414d122b35bdebb43ac42ef4d7d Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Wed Apr 30 01:34:18 2014 +0000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267031 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/30/14 9:44 PM | Comment #127 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c127 https://chromium.googlesource.com/chromium/src.git/+/3cf4bd4d39a7731100fd85c02fb9dd11259462a8 commit 3cf4bd4d39a7731100fd85c02fb9dd11259462a8 Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Thu May 01 04:22:15 2014 +0000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266817 Review URL: https://codereview.chromium.org/259773006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267423 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/30/14 9:51 PM | Comment #128 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c128 ------------------------------------------------------------------ r267423 | er...@chromium.org | 2014-05-01T04:22:15.976568Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_data_handle.cc?r1=267423&r2=267422&pathrev=267423 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_data_handle.h?r1=267423&r2=267422&pathrev=267423 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/fileapi/blob_storage_context_unittest.cc?r1=267423&r2=267422&pathrev=267423 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_storage_context.h?r1=267423&r2=267422&pathrev=267423 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/loader/upload_data_stream_builder_unittest.cc?r1=267423&r2=267422&pathrev=267423 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/30/14 10:40 PM | Comment #129 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c129 https://chromium.googlesource.com/chromium/src.git/+/74c6709366769b2ed7ace4ff9cb5c926bcbaa8fe commit 74c6709366769b2ed7ace4ff9cb5c926bcbaa8fe Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Thu May 01 05:28:54 2014 +0000 Some changes to support incognito mode, and some small cleanup. BUG=108012 Review URL: https://codereview.chromium.org/260783003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267448 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 4/30/14 10:44 PM | Comment #130 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c130 ------------------------------------------------------------------ r267448 | er...@chromium.org | 2014-05-01T05:28:54.340746Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_callbacks.cc?r1=267448&r2=267447&pathrev=267448 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc?r1=267448&r2=267447&pathrev=267448 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_dispatcher_host.cc?r1=267448&r2=267447&pathrev=267448 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_blob_info.cc?r1=267448&r2=267447&pathrev=267448 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_blob_info.h?r1=267448&r2=267447&pathrev=267448 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/1/14 1:09 AM | Comment #131 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c131 https://chromium.googlesource.com/chromium/src.git/+/ac6f8c98b9f225ac1c890f94d14ff9e3b17afd0c commit ac6f8c98b9f225ac1c890f94d14ff9e3b17afd0c Author: fal...@chromium.org <falken@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Thu May 01 08:03:24 2014 +0000 Revert of Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (https://codereview.chromium.org/259773006/) Reason for revert: I'm sorry to revert this change. It looks like it breaks the ASAN bot: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2161/steps/content_unittests/logs/ResolveBlobAndCreateUploadDataStream Direct leak of 120 byte(s) in 3 object(s) allocated from: #0 0x520dbb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x3a0f611 in webkit_blob::BlobDataHandle::BlobDataHandle(webkit_blob::BlobData*, webkit_blob::BlobStorageContext*, base::SequencedTaskRunner*) webkit/browser/blob/blob_data_handle.cc:42 #2 0x3a0fd71 in webkit_blob::BlobStorageContext::GetBlobDataFromUUID(std::string const&) webkit/browser/blob/blob_storage_context.cc:69 #3 0x268955d in ResolveBlobReference content/browser/loader/upload_data_stream_builder.cc:73 ... Original issue's description: > Allow BlobDataHandles to be copied, and have their UUIDs read, on any> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267423 TBR=mich...@chromium.org,piman@chromium.org,er...@chromium.org NOTREECHECKS=true NOTRY=true BUG=108012 Review URL: https://codereview.chromium.org/261683005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267479 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/1/14 1:10 AM | Comment #132 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c132 ------------------------------------------------------------------ r267479 | fal...@chromium.org | 2014-05-01T08:03:24.202388Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_data_handle.cc?r1=267479&r2=267478&pathrev=267479 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_data_handle.h?r1=267479&r2=267478&pathrev=267479 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/fileapi/blob_storage_context_unittest.cc?r1=267479&r2=267478&pathrev=267479 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/browser/blob/blob_storage_context.h?r1=267479&r2=267478&pathrev=267479 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/loader/upload_data_stream_builder_unittest.cc?r1=267479&r2=267478&pathrev=267479 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/1/14 5:24 PM | Comment #133 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c133 https://chromium.googlesource.com/chromium/src.git/+/790591d1c8a92f496b43ef87fe2cf48eb09020bb commit 790591d1c8a92f496b43ef87fe2cf48eb09020bb Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Thu May 01 23:38:27 2014 +0000 This is the implementation of the primary and secondary blob journals for IDB/Blob support. It's not yet used at all, so there are a few fake calls to eliminate compiler errors until the rest of the code lands. BUG=108012 Review URL: https://codereview.chromium.org/264483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267665 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/1/14 5:26 PM | Comment #134 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c134 ------------------------------------------------------------------ r267665 | er...@chromium.org | 2014-05-01T23:38:27.569509Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=267665&r2=267664&pathrev=267665 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=267665&r2=267664&pathrev=267665 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=267665&r2=267664&pathrev=267665 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc?r1=267665&r2=267664&pathrev=267665 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.cc?r1=267665&r2=267664&pathrev=267665 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.h?r1=267665&r2=267664&pathrev=267665 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/10/14 11:54 AM | Comment #137 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c137 https://chromium.googlesource.com/chromium/src.git/+/496cbfbec18cea8ba588687b355673d35420ab9d commit 496cbfbec18cea8ba588687b355673d35420ab9d Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Sat May 10 18:52:58 2014 More changes to support incognito mode in the IDB/Blob code. Also includes a few small cleanup changes I noticed while I was in there. BUG=108012 Review URL: https://codereview.chromium.org/261843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269605 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/10/14 11:57 AM | Comment #138 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c138 ------------------------------------------------------------------ r269605 | er...@chromium.org | 2014-05-10T18:52:58.035761Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=269605&r2=269604&pathrev=269605 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=269605&r2=269604&pathrev=269605 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/12/14 10:30 PM | Comment #139 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c139 ------------------------------------------------------------------ r270016 | er...@chromium.org | 2014-05-13T04:59:44.904941Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.cc?r1=270016&r2=270015&pathrev=270016 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=270016&r2=270015&pathrev=270016 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=270016&r2=270015&pathrev=270016 Add most of the metadata-handling code for blobs. It's not quite all there, but this is the biggest chunk I can pull out vaguely cleanly. It does contain a couple of fake calls to keep the compiler happy. This CL also makes SetUpMetadata a member in order to ease testing in a later CL. This depends on https://codereview.chromium.org/261843004/. BUG=108012 Review URL: https://codereview.chromium.org/266333002 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/12/14 10:31 PM | Comment #140 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c140 https://chromium.googlesource.com/chromium/src.git/+/9f96c91cd9a9f73d000e1ab35c53974c58fd571b commit 9f96c91cd9a9f73d000e1ab35c53974c58fd571b Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Tue May 13 04:59:44 2014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270016 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/13/14 12:20 AM | Comment #141 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c141 https://chromium.googlesource.com/chromium/src.git/+/28e0631885a68d2b0ad3aefbec80a18ada909a9d commit 28e0631885a68d2b0ad3aefbec80a18ada909a9d Author: dch...@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Tue May 13 06:55:43 2014 Revert 270016 "Add most of the metadata-handling code for blobs...." This may have caused indexed_db layout tests to start failing. TBR=er...@chromium.org Review URL: https://codereview.chromium.org/281623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270038 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/13/14 12:23 AM | Comment #142 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c142 ------------------------------------------------------------------ r270038 | dch...@chromium.org | 2014-05-13T06:55:43.383894Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=270038&r2=270037&pathrev=270038 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=270038&r2=270037&pathrev=270038 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.cc?r1=270038&r2=270037&pathrev=270038 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/16/14 7:36 PM | Comment #146 on issue 108012 by dpr...@chromium.org: IndexedDB should support storing File/Blob objectsr270016 appears to have broken a bunch of layout tests on win7, so I reverted it after discussing w/ Eric. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/16179 (and a few other builds around that time). |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/16/14 7:38 PM | Comment #145 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c145 ------------------------------------------------------------------ r271146 | dpr...@chromium.org | 2014-05-17T01:53:45.600680Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=271146&r2=271145&pathrev=271146 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=271146&r2=271145&pathrev=271146 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.cc?r1=271146&r2=271145&pathrev=271146 Revert r271097 - "Add most of the metadata-handling code for blobs." This change caused most of the indexeddb tests to fail on win7 :(. TBR=er...@chromium.org BUG=108012 Review URL: https://codereview.chromium.org/287093004 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 5/16/14 7:39 PM | Comment #147 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c147 https://chromium.googlesource.com/chromium/src.git/+/f498c2444254cd47c007c56bf5733fcdf905073c commit f498c2444254cd47c007c56bf5733fcdf905073c Author: dpr...@chromium.org <dpranke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Sat May 17 01:53:45 2014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271146 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/3/14 6:22 PM | Comment #150 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c150 ------------------------------------------------------------------ r274685 | er...@chromium.org | 2014-06-04T00:34:10.242923Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.cc?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/tools/metrics/histograms/histograms.xml?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store.h?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/leveldb/leveldb_comparator.h?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_fake_backing_store.cc?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_fake_backing_store.h?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_leveldb_coding.h?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_database_unittest.cc?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_database.cc?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_transaction_unittest.cc?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_context_impl.cc?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_transaction.cc?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_transaction.h?r1=274685&r2=274684&pathrev=274685 M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_backing_store_unittest.cc?r1=274685&r2=274684&pathrev=274685 This is the master CL that contains the whole remaining Chromium side. See https://codereview.chromium.org/18590006/ for the Blink side. See https://docs.google.com/a/chromium.org/document/d/1Kdr4pcFt4QBDLLQn-fY4kZgw6ptmK23lthGZdQMVh2Y/edit for the big picture document [chromium.org account required]. Read-only view at https://docs.google.com/document/d/1Kdr4pcFt4QBDLLQn-fY4kZgw6ptmK23lthGZdQMVh2Y/pub [no account required]. BUG=108012 Review URL: https://codereview.chromium.org/18023022 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/3/14 6:27 PM | Comment #151 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c151 https://chromium.googlesource.com/chromium/src.git/+/67bb75b97060c6e08912b1b1696b45374189535b commit 67bb75b97060c6e08912b1b1696b45374189535b Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Wed Jun 04 00:34:10 2014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274685 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/5/14 2:25 AM | Comment #152 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c152 https://chrome-internal.googlesource.com/bling/chromium.git/+/67bb75b97060c6e08912b1b1696b45374189535b
|
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/6/14 10:19 PM | Comment #154 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c154 https://chromium.googlesource.com/chromium/src.git/+/7c303f05a12233a23ffbe25c9a36f35dcb7bbb6e commit 7c303f05a12233a23ffbe25c9a36f35dcb7bbb6e Author: er...@chromium.org <ericu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Sat Jun 07 05:15:32 2014 Fix a bug wherein we'd release a scoped_ptr and dereference it in the same line of code. That worked by luck on some compilers, but failed on OSX, in a way only revealed by tryjobs on a subsequent blink change. BUG=108012 Review URL: https://codereview.chromium.org/320103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275623 0039d316-1c4b-4281-b951-d872f2087c98 |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/6/14 10:25 PM | Comment #155 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c155 ------------------------------------------------------------------ r275623 | er...@chromium.org | 2014-06-07T05:15:32.893991Z Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/indexed_db/indexed_db_callbacks.cc?r1=275623&r2=275622&pathrev=275623 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/7/14 10:45 AM | Comment #156 on issue 108012 by cos...@gmail.com: IndexedDB should support storing File/Blob objectsThank you very much for the hard work! I can try it out after the last CL lands. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/9/14 9:52 AM | Comment #157 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c157 http://src.chromium.org/viewvc/blink?view=rev&rev=175802 ------------------------------------------------------------------ r175802 | er...@chromium.org | 2014-06-09T16:26:21.735409Z Changed paths: M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/keypath-intrinsic-properties-expected.txt?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-valid-after-deletion.html?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-valid-before-commit-expected.txt?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-delete-objectstore-db-expected.txt?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-basics-metadata.html?r1=175802&r2=175801&pathrev=175802 D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/noblobs.html?r1=175802&r2=175801&pathrev=175802 M http://src.chromium.org/viewvc/blink/trunk/Source/bindings/v8/SerializedScriptValue.h?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-valid-before-commit.html?r1=175802&r2=175801&pathrev=175802 M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/resources/keypath-intrinsic-properties.js?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-delete-objectstore-db.html?r1=175802&r2=175801&pathrev=175802 M http://src.chromium.org/viewvc/blink/trunk/Source/modules/indexeddb/IDBObjectStore.cpp?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-valid-after-deletion-expected.txt?r1=175802&r2=175801&pathrev=175802 A http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/blob-basics-metadata-expected.txt?r1=175802&r2=175801&pathrev=175802 D http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/noblobs-expected.txt?r1=175802&r2=175801&pathrev=175802 This is the master CL that contains the whole remaining Blink side. It turns on Blob support in IDB, so it has to wait until the Chromium side has completely landed. See https://codereview.chromium.org/18023022/ for the Chromium side. SeeReview URL: https://codereview.chromium.org/18590006 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 6/10/14 10:44 AM | Updates:
Status: Fixed Comment #158 on issue 108012 by er...@chromium.org: IndexedDB should support storing File/Blob objectsDone ;'>. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 7/8/14 2:54 AM | Comment #159 on issue 108012 by vitteaym...@gmail.com: IndexedDB should support storing File/Blob objects"If you're the sort of brave soul who builds Chromium you could try applying the above patch locally. If not, watch here for one last change. We'll want you to try out the next Canary build after that." Is there a build ready to start testing it? |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 7/25/14 10:18 PM | Comment #161 on issue 108012 by bugdro...@chromium.org: IndexedDB should support storing File/Blob objects http://code.google.com/p/chromium/issues/detail?id=108012#c161 http://src.chromium.org/viewvc/blink?view=rev&rev=178979 ------------------------------------------------------------------ r178979 | jsb...@chromium.org | 2014-07-26T05:13:44.995631Z Changed paths: M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/structured-clone-expected.txt?r1=178979&r2=178978&pathrev=178979 M http://src.chromium.org/viewvc/blink/trunk/LayoutTests/storage/indexeddb/structured-clone.html?r1=178979&r2=178978&pathrev=178979 IndexedDB: Enable Blob/File/FileList structured clone tests These test cases should have been enabled when Blob support landed, but were missed. BUG=108012 R=cmum...@chromium.org,dgrogan@chromium.org Review URL: https://codereview.chromium.org/414223008 ----------------------------------------------------------------- |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/30/14 10:32 AM | Comment #162 on issue 108012 by bloodsp...@gmail.com: IndexedDB should support storing File/Blob objects https://code.google.com/p/chromium/issues/detail?id=108012 I was excited to try this out, as v37 hit the stable channel this week. It isn't stable. Steps: * write Blobs to the IndexedDB. * close the browser. * wait a few minutes. * open the browser Result: All blobs from the database return File not Found errors. Test data was 1900 images with a total size of 60MiB. I think I will have to go back to storing data-URIs and converting them into blobs on application load. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/30/14 4:15 PM | Comment #163 on issue 108012 by er...@chromium.org: IndexedDB should support storing File/Blob objects@bloodspill if you have a reproducible test case, please log a new bug [don't just comment here]. Please confirm that the writes complete, and the transaction commits, before killing the browser. If it hasn't committed, of course the blobs won't be there. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/30/14 10:02 PM | Comment #164 on issue 108012 by bloodsp...@gmail.com: IndexedDB should support storing File/Blob objectsI can confirm that the issue is not present in Canary (v39.0.2141.0). I couldn't find an issue in the tracker that describes this problem, so I don't know what other change led to this being fixed -- no idea when it will be in Stable. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/30/14 11:02 PM | Comment #165 on issue 108012 by jsb...@chromium.org: IndexedDB should support storing File/Blob objectsAny chance issue 408601 is the culprit? I landed a fix a couple of days ago, and the fix would be in the v39.0.2141.0 canary. I don't recall any other relevant fixes that'd be in 39 but not 37, but there may have been some. If you can share a repro - even if it's no longer reproducing in canary - it'd help us identify the fix (and ensure it's really fixed, and not just flaky) and justify merging the fix to earlier versions. |
Re: Issue 108012 in chromium: IndexedDB should support storing File/Blob objects | chro...@googlecode.com | 8/31/14 1:02 AM | Comment #166 on issue 108012 by bloodsp...@gmail.com: IndexedDB should support storing File/Blob objectsLooking at the change for #408120 again, it's possible? However I was experiencing different behaviour from the browser before and after closing it. Before closing the browser I had the mime-type text/plain complaint. <img> tags still loaded them fine. After restarting the browser I had 404 errors and <img> tags failed completely. |