garden-o-matic: how to review image rebaselines before committing?

[Elliot Poger]

Let's say I have used garden-o-matic to rebaseline a bunch of tests.

Is there a way for me to review those pending rebaselines before I actually commit?  (Like, let's say I wanted to show a subset of the pending rebaselines to a co-worker and get her OK before committing.)

I don't see any such functionality *within* garden-o-matic... as I click on the "Rebaseline" button for various tests, I don't see any "breadcrumb trail" (queue) being built to help me track the set of tests I have rebaselined.

I tried "webkit-patch pretty-diff", but its utility is limited by https://bugs.webkit.org/show_bug.cgi?id=76640 ('webkit-patch pretty-diff does not show image diffs').

My inclination is to improve "webkit-patch pretty-diff", but the pixel zoomer in garden-o-matic is so nice, it seems a shame to leave it behind!

Any suggestions?

[Dirk Pranke]

I would say that we should see if we can improve pretty-diff to share
the pixel zooming code from g-o-m.

Ideally we'd share that same code in NRWT's results.html as well. We
have too many different frontends for essentially the same problem.

-- Dirk

[Ojan Vafai]

I agree. I don't think garden-o-matic is the right place to fix this. We should have pretty-diff pull a script that adds both pixel-zooming and JS-based pixel diffing. The former exists in garden-o-matic as an external script file we can pull (from trac) into the diff generated by pretty-diff.

The code for JS-based pixel-diffing also exists as part of the rebaseline-server. It just needs to be pulled into a standalone JS file so other apps can use it. Garden-o-matic doesn't need the JS-based pixel-diffing because it uses the pixel diffs generated by the bots.

This has the added advantage of making the code-review tool be able to do pixel zooming and diffing.

We might also want to look into moving some of the code-review functionality a level down into the pretty-diff page (e.g. making the diff side-by-side, ability to expand content, etc).

Finally, adding some sort of breadcrumb functionality to see the changes you've made so far, seems useful, but orthogonal to the rest of these issues if the changes we're making are to the pretty-diff output.

Ojan

[Ojan Vafai]

That all said, I'd support also finding a way of showing the pretty-diff inside the garden-o-matic UI. I like the idea that the only tool you need to think about for doing rebaselines is garden-o-matic. Although, I'm also fine with continuing to support the REBASELINE keyword in test_expectations.txt.