Re: Refactor serving_dirs. (issue 838253005 by aiolos@chromium.org)

2 views
Skip to first unread message

commi...@chromium.org

unread,
Mar 13, 2015, 1:40:38 PM3/13/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/838253005/110001


https://codereview.chromium.org/838253005/

commi...@chromium.org

unread,
Mar 13, 2015, 1:45:38 PM3/13/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org
Committed patchset #7 (id:110001)

https://codereview.chromium.org/838253005/

commi...@chromium.org

unread,
Mar 13, 2015, 1:47:21 PM3/13/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org
Patchset 7 (id:??) landed as
https://crrev.com/eed596dced7b9e3f7d21c84f695a39b946c62bf2
Cr-Commit-Position: refs/heads/master@{#320523}

https://codereview.chromium.org/838253005/

vang...@google.com

unread,
Mar 13, 2015, 3:06:11 PM3/13/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org
A revert of this CL (patchset #7 id:110001) has been created in
https://codereview.chromium.org/1005903004/ by vang...@google.com.

The reason for reverting is: Causing failures on GPU bots

http://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%29/builds/30080

.

https://codereview.chromium.org/838253005/

k...@chromium.org

unread,
Mar 13, 2015, 4:15:12 PM3/13/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org
crbug.com/467149 filed about why this CL passed the commit queue but broke
the
waterfall.


https://codereview.chromium.org/838253005/

aio...@chromium.org

unread,
Mar 13, 2015, 8:35:03 PM3/13/15
to d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, k...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, k...@chromium.org
On 2015/03/13 20:15:12, Ken Russell wrote:
> crbug.com/467149 filed about why this CL passed the commit queue but
> broke the
> waterfall.

I fixed the import. Still not sure how that got deleted without causing
tests/lint to fail, but the bug on it has been closed. Trying again, hoping
the
issue is fixed.

Could someone else PTAL to see if there is anything I missed?

https://codereview.chromium.org/838253005/

nedn...@google.com

unread,
Mar 13, 2015, 9:08:50 PM3/13/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, chris...@google.com, dpr...@chromium.org, k...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, k...@chromium.org
On 2015/03/14 00:35:03, aiolos wrote:
> On 2015/03/13 20:15:12, Ken Russell wrote:
> > crbug.com/467149 filed about why this CL passed the commit queue but
> broke
the
> > waterfall.

> I fixed the import. Still not sure how that got deleted without causing
> tests/lint to fail, but the bug on it has been closed. Trying again,
> hoping
the
> issue is fixed.

> Could someone else PTAL to see if there is anything I missed?
lgtm
My guess is that it's merge problem. I would just check the cq again. :-/

https://codereview.chromium.org/838253005/

commi...@chromium.org

unread,
Mar 17, 2015, 4:50:56 PM3/17/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, k...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, k...@chromium.org
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/838253005/130001


https://codereview.chromium.org/838253005/

commi...@chromium.org

unread,
Mar 17, 2015, 6:08:09 PM3/17/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, k...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, k...@chromium.org
Committed patchset #8 (id:130001)

https://codereview.chromium.org/838253005/

commi...@chromium.org

unread,
Mar 17, 2015, 6:08:52 PM3/17/15
to aio...@chromium.org, d...@chromium.org, sull...@chromium.org, nedn...@google.com, chris...@google.com, dpr...@chromium.org, k...@chromium.org, to...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, k...@chromium.org
Patchset 8 (id:??) landed as
https://crrev.com/cd55fdb2cfcd494abab3e4ccab7934b14f94581b
Cr-Commit-Position: refs/heads/master@{#320990}

https://codereview.chromium.org/838253005/
Reply all
Reply to author
Forward
0 new messages