Re: Telemetry: Add a script to check and enable reading MSRs on Linux. (issue 601783003 by thestig@chromium.org)

tomm...@chromium.org

unread,

Jul 31, 2015, 2:32:35 PM7/31/15

to the...@chromium.org, d...@chromium.org, sull...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, d...@chromium.org

Hey guys,

I got bit by Linux MSR issues this morning. If this patch was in, it would
have
prompted me to run the script to set up my box.

In fact Dan and I referred to this script to fix my MSR configuration.

Any chance of reconsidering including this script into the tree?

https://codereview.chromium.org/601783003/

the...@chromium.org

unread,

Jul 31, 2015, 4:56:13 PM7/31/15

to d...@chromium.org, sull...@chromium.org, tomm...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, d...@chromium.org, tomm...@chromium.org

On 2015/07/31 18:32:34, tommycli wrote:
> Hey guys,

> I got bit by Linux MSR issues this morning. If this patch was in, it would
have
> prompted me to run the script to set up my box.

> In fact Dan and I referred to this script to fix my MSR configuration.

> Any chance of reconsidering including this script into the tree?

I'll rewrite this in Python. You can use the bash script locally in the mean
time.

https://codereview.chromium.org/601783003/

d...@chromium.org

unread,

Jul 31, 2015, 6:18:24 PM7/31/15

to the...@chromium.org, sull...@chromium.org, tomm...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, tomm...@chromium.org

Sounds like a plan. I'm willing to relax the rule about zero-setup

https://codereview.chromium.org/601783003/

the...@chromium.org

unread,

Aug 1, 2015, 3:08:20 AM8/1/15

to d...@chromium.org, sull...@chromium.org, tomm...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, tomm...@chromium.org

See patch set 2.

https://codereview.chromium.org/601783003/

d...@chromium.org

unread,

Aug 3, 2015, 5:01:13 PM8/3/15

to the...@chromium.org, sull...@chromium.org, tomm...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, tomm...@chromium.org

lgtm with comment

https://codereview.chromium.org/601783003/diff/20001/tools/telemetry/linux_setup_msr.py
File tools/telemetry/linux_setup_msr.py (right):

https://codereview.chromium.org/601783003/diff/20001/tools/telemetry/linux_setup_msr.py#newcode1
tools/telemetry/linux_setup_msr.py:1: #!/usr/bin/env python
I think tools/telemetry/build/ is the right place?

https://codereview.chromium.org/601783003/

the...@chromium.org

unread,

Aug 3, 2015, 6:29:47 PM8/3/15

to d...@chromium.org, sull...@chromium.org, tomm...@chromium.org, chromium...@chromium.org, telemet...@chromium.org, tomm...@chromium.org

Tested locally and worked fine. (Before I moved it)

$ tools/telemetry/linux_setup_msr.py
Error: MSR module not loaded.
Error: /usr/sbin/rdmsr missing or not executable.
Check failed, try running "linux_setup_msr.py enable" as root to fix.

$ sudo tools/telemetry/linux_setup_msr.py enable
Loading msr kernel module.
Running chmod on /dev/cpu/0/msr.
Need to install the msr-tools package.
[apt-get output here]
Running setcap on /usr/sbin/rdmsr.

$ tools/telemetry/linux_setup_msr.py
Check succeeded

https://codereview.chromium.org/601783003/diff/20001/tools/telemetry/linux_setup_msr.py
File tools/telemetry/linux_setup_msr.py (right):

https://codereview.chromium.org/601783003/diff/20001/tools/telemetry/linux_setup_msr.py#newcode1
tools/telemetry/linux_setup_msr.py:1: #!/usr/bin/env python

On 2015/08/03 21:01:12, dtu wrote:
> I think tools/telemetry/build/ is the right place?

Done.

https://codereview.chromium.org/601783003/