Clipboard related crash in headless mode.

4 views
Skip to first unread message

Zoe Clifford

unread,
Mar 1, 2017, 3:36:56 PM3/1/17
to dch...@chromium.org, stora...@chromium.org
Hello ui/base/clipboard/clipboard.cc owners,

I filed a Headless Chromium bug where a crash could be triggered in the clipboard code due to headless using the auraX11 clipboard without setting up an x11 related global variable.

I believe the most straightforward solution would be to promote TestClipboard to an actual production headless clipboard used in headless mode, and check if the browser is running during headless mode during clipboard construction.

A compile time switch isn't possible in this case, because headless mode is a runtime flag.

Does this approach sound reasonable? I wanted to check before writing a change.

Thanks!

Daniel Cheng

unread,
Mar 2, 2017, 2:33:26 AM3/2/17
to Zoe Clifford, stora...@chromium.org
That seems fine to me.

Daniel
Reply all
Reply to author
Forward
0 new messages