Re: power_save_blocker_ozone errors

[Robert Kroeger]

[+ozone-dev] for the active ozone team to comment.

On Mon, Jun 1, 2015 at 8:21 AM, Chris Masone <cma...@google.com> wrote:

It's extremely possible that the GN for that rusted or wasn't done quite right initially. Feel free to change it as long as stuff still compiles.

On Mon, Jun 1, 2015 at 7:32 AM Daniel Erat <de...@google.com> wrote:

This seems broken to me. Cc-ing Chris since I think he did the GN conversion here a while back.

This part of content/browser/BUILD.gn looks wrong:

  # Dealing with power_save_blocker_{x11,ozone}.cc is a little complicated

  # given the interaction between os_chromeos and the feature flags for X11 and

  # ozone, so do it all in one spot.

  if (is_chromeos || !use_ozone) {

    sources -= [ "power_save_blocker_ozone.cc" ]

  }

  if (is_chromeos || !use_x11) {

    sources -= [ "power_save_blocker_x11.cc" ]

  }

In contrast, content/content_browser.gypi removes both of those files when chromeos is defined.

On both Ozone and X11 Chrome OS, we should use power_save_blocker_chromeos.cc. It talks to the Chrome OS power manager, which is agnostic about the display system.

On X11 desktop Linux, we should use power_save_blocker_x11.cc. It speaks either the GNOME or FreeDesktop (KDE and XFCE) API.

I'm not sure what power_save_blocker_ozone.cc is used for -- just Chromecast? It's probably fine to delete those NOTIMPLEMENTED calls, as I don't think there's anything power-management-related that needs to be done to keep the system awake while video/audio/etc. is active there.

On Mon, Jun 1, 2015 at 7:47 AM, Luke Halliwell <hall...@google.com> wrote:

Hi - you're the only two on the history for this file:

https://chromium.googlesource.com/chromium/src/+log/master/content/browser/power_save_blocker_ozone.cc

We get this error in the log on Chromecast for every video played, would like to remove it.

Do you know what the plans are around implementing this, or who to ask?  And if it's not going to be implemented soon, whether we could just remove the NOTIMPLEMENTED lines?

Luke

[Luke Halliwell]

I don't think the gn file is relevant to our particular issue - while it might be wrong, we build with gyp.

We're fine with the non-implemented status of power_save_blocker_ozone.cc - it's just the log errors that are unnecessary noise.  It sounds like we should just delete those NOTIMPLEMENTED lines - I'll submit a CL for that.

Thanks!

Luke

[Daniel Erat]

Cool, I'm happy to review.

I think the GN file is fine, by the way -- I somehow misread the "||"s as "&&"s. Sorry for the confusion. :-/

[Michael Spang]

+1 let's just squelch it.

Michael