update to gn

Craig Stout

unread,

Jul 28, 2015, 6:06:54 PM7/28/15

to mojo...@chromium.org

This update to gn would be immediately useful to me. Any chance we can easily pick it up?

https://codereview.chromium.org/1217093007

-craig

Adam Barth

unread,

Jul 28, 2015, 6:08:50 PM7/28/15

to Craig Stout, mojo...@chromium.org

The most direct way of picking up that change would be to update our copy of //base and //build from Chromium.

Adam

Viet-Trung Luu

unread,

Jul 28, 2015, 6:14:47 PM7/28/15

to Craig Stout, mojo...@chromium.org

Updating it would just be a matter of updating the hashes in buildtools/linux64/gn.sha1 and buildtools/mac/gn.sha1 (e.g., to match those in Chromium tip-of-tree, assuming gn binaries have been updated in Chromium).

If doing so doesn't break anything, I don't see the harm.

To unsubscribe from this group and stop receiving emails from it, send an email to mojo-dev+u...@chromium.org.

Adam Barth

unread,

Jul 28, 2015, 6:19:22 PM7/28/15

to Viet-Trung Luu, Craig Stout, mojo...@chromium.org

buildtools is fetched via DEPS, which means we'd need to pull in a newer rev of all of //buildtools. It's possible we can do that without breaking things, but it's likely that will cause use to need to pull in a new //build and a new //base.

Adam

James Robinson

unread,

Jul 28, 2015, 6:22:19 PM7/28/15

to Adam Barth, Viet-Trung Luu, Craig Stout, mojo...@chromium.org

Any syntax changes in GN itself (which are relatively rare but happen) will also require updating all the BUILD.gn files. Easiest to pull everything we pull from chromium along with the new GN rev since we know those will work together.

Viet-Trung Luu

unread,

Jul 28, 2015, 6:35:14 PM7/28/15

to James Robinson, Adam Barth, Craig Stout, mojo...@chromium.org

Sigh. People have landed quite a few local changes to //build, so updating it is somewhat annoying.

Reply all

Reply to author

Forward