GN args not being propagated?

[wn...@chromium.org]

I am looking at a bug (http://crbug.com/599268) on why is_official_build is not propagating correctly when ChromeVersionConstants.java is generated from ChromeVersionConstants.java.version.

Any ideas? I'm kinda stuck as to how the defines from https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD.gn&l=246 is not getting to //chrome/android/BUILD.gn.

Thanks,

Peter

[Jeremy Roman]

The GN file you point at defines a C preprocessor macro, which doesn't seem to apply in this case. Rather, either:

- the gn action could conditionally provide the "CHROME_BUILD_TYPE" environment variable that's required there (though this is probably awkward), or

- build/util/version.py should be modified to take a flag instead, and the action could conditionally specify this flag depending on the is_official_build variable

[Peter Wen]

Oooh, process_version is a template which contains an action using the build/util/version.py. I remember yesterday's talk so I think I can work through this.

Agreed that modifying build/util/version.py would be the best way. Thanks Jeremy!

Peter