Disable accelerated 2d canvas on the mac. The current implementation is based on SKIA and isn't ... (issue7093002)
vang...@google.com
a...@chromium.org
http://codereview.chromium.org/7093002/diff/1/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
File chrome/browser/tab_contents/render_view_host_delegate_helper.cc
(right):
http://codereview.chromium.org/7093002/diff/1/chrome/browser/tab_contents/render_view_host_delegate_helper.cc#newcode322
chrome/browser/tab_contents/render_view_host_delegate_helper.cc:322:
web_prefs.accelerated_2d_canvas_enabled = false;
Need a comment with a bug URL here.
ju...@chromium.org
per
platform basis is in feauture_override.gypi. We already have a compile
flag for
this feature in place: ENABLE(ACCELERATED_2D_CANVAS)
The problem is that the current logic in feauture_override.gypi turns on the
accelerated 2d canvas whenever accelerated compositing is on, which is not
necessary. On the mac, we should be building with accelerated compositing
only.
The change that is required on the WebKit side is to make sure that
accelerated
compositing can be used without accelerated 2d canvas, which is currently
not
the case because of unresolved symbols from TilingData.cpp. To fix that,
it is
just a matter of changing the #if at the top of that file.
Once that change is rolled into chromium, the change to
feature_override.gypi
will not break the mac build.
a...@chromium.org
vang...@google.com
> junov clearly is better-informed than I am. Please follow his advice.
Thanks, Justin. I like your solution better too! I'm closing this one
since
you're already working on the GYP-based solution.