sqlite: Tag FTS3 cursor pointers in fts3ColumnMethod(). [chromium/src : master]

Victor Costan (Gerrit)

unread,

May 12, 2017, 6:53:23 PM5/12/17

to chromium...@chromium.org

Victor Costan uploaded patch set #4 to this change.

sqlite: Tag FTS3 cursor pointers in fts3ColumnMethod().

FTS3 tables have a magic column, whose name matches the table name, which
is used to obtain a pointer to the cursor for the current operation.
fts3ColumnMethod() now tags its result when used with the magic column,
and fts3FunctionArg() checks the tag and returns an error when asked to
access the magic column on behalf of the user.

Bug: 703507
Change-Id: I7ca3d7c550845948e606ed57db4a0bc83579e648
---
A third_party/WebKit/LayoutTests/storage/websql/fts-crash-703507.html
M third_party/sqlite/README.chromium
M third_party/sqlite/amalgamation/sqlite3.c
A third_party/sqlite/patches/0012-Tag-FTS3-cursor-pointers-in-fts3ColumnMethod.patch
M third_party/sqlite/src/ext/fts3/fts3.c
5 files changed, 76 insertions(+), 2 deletions(-)

To view, visit change 505407. To unsubscribe, visit settings.

Victor Costan (Gerrit)

unread,

May 12, 2017, 6:55:43 PM5/12/17

to chromium...@chromium.org

Victor Costan posted comments on this change.

View Change

Patch set 4:Commit-Queue +1

To view, visit change 505407. To unsubscribe, visit settings.

Victor Costan (Gerrit)

unread,

May 12, 2017, 6:59:39 PM5/12/17

to Chris Mumford, chromium...@chromium.org

Victor Costan posted comments on this change.

View Change

Patch set 4:

PTAL?

To view, visit change 505407. To unsubscribe, visit settings.

Reply all

Reply to author

Forward