Blacklist HD3000 on Mac (issue 2076443002 by ccameron@chromium.org)

[ccam...@chromium.org]

Reviewers: Zhenyao Mo
CL: https://codereview.chromium.org/2076443002/

Message:
HD4000 is also on the chopping block, but this just does HD3000 for now. It
holds the dubious honor of being responsible for 30% of our GPU crashes.

Description:
Blacklist HD3000 on Mac

HD3000 is responsible for 30% of our GPU process crashes on Mac.

BUG=592130
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+14, -1 lines):
M gpu/config/software_rendering_list_json.cc


Index: gpu/config/software_rendering_list_json.cc
diff --git a/gpu/config/software_rendering_list_json.cc b/gpu/config/software_rendering_list_json.cc
index 1d5c2b161eed48188e140075fbbcb38c6b6cc105..ef5bad6b90f18fe5a15b43dbc1b1a205ed50e6b5 100644
--- a/gpu/config/software_rendering_list_json.cc
+++ b/gpu/config/software_rendering_list_json.cc
@@ -18,7 +18,7 @@ const char kSoftwareRenderingListJson[] = LONG_STRING_CONST(
{
"name": "software rendering list",
// Please update the version number whenever you change this file.
- "version": "11.1",
+ "version": "11.2",
"entries": [
{
"id": 1,
@@ -1075,6 +1075,19 @@ LONG_STRING_CONST(
"features": [
"gpu_rasterization"
]
+ },
+ {
+ "id": 112,
+ "description": "Intel HD 3000 driver crashes frequently on Mac",
+ "cr_bugs": [592130],
+ "os": {
+ "type": "macosx"
+ },
+ "vendor_id": "0x8086",
+ "device_id": ["0x0116", "0x0126"],
+ "features": [
+ "all"
+ ]
}
]
}

[z...@chromium.org]

On 2016/06/16 01:07:33, ccameron wrote:
> HD4000 is also on the chopping block, but this just does HD3000 for now. It
> holds the dubious honor of being responsible for 30% of our GPU crashes.

Maybe just turning off rasterization rather than everything? These GPUs should
run WebGL OK. We don't want the situation where Firefox and Safari can have
WebGL but Chrome doesn't.

Adding Ken for his opinion.

https://codereview.chromium.org/2076443002/

[k...@chromium.org]

The crashes on these GPUs were happening before GPU rasterization was turned on.
The HD 3000 in particular is really old, and has been problematic. For these
reasons I think it's OK to blacklist all GPU functionality on it, including
WebGL. Users can manually specify --ignore-gpu-blacklist if they want to try
content on it.

LGTM from my standpoint.


https://codereview.chromium.org/2076443002/

[z...@chromium.org]

OK, lgtm then

https://codereview.chromium.org/2076443002/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/2076443002/1


https://codereview.chromium.org/2076443002/

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #1 (id:1)

https://codereview.chromium.org/2076443002/

[commit-bot@chromium.org via codereview.chromium.org]

Patchset 1 (id:??) landed as
https://crrev.com/0b113ce33d9d553b105fa68a2b2b554a93de43e9
Cr-Commit-Position: refs/heads/master@{#400262}

https://codereview.chromium.org/2076443002/

[aaron...@gmail.com]

I've used WebGL on this computer for over a year with no problem, until now. Now I'm in "the situation where Firefox and Safari can have WebGL but Chrome doesn't" that you wanted to avoid... I've got that Intel 3000 HD, on my 2011-era MBP.

[dcdo...@gmail.com]

You guys are way too aggressive on this stuff.

[ungo...@gmail.com]

I have the good fortune of owning an early 2011 MBP with an Intel HD 3000.

Never had any problems with WebGL until y'all decided to disable it.

My favorite part was the link in `chrome://gpu`:

> Intel HD 3000 driver crashes frequently on Mac: 592130

> Disabled Features: all

Following the link, I get the following friendly message:

> You do not have permission to view the requested page.
> 
> Reason: User is not allowed to view this issue

A couple hours later I found this thread. Guess I'm manually setting --ignore-gpu-blacklist now. Not exactly the ideal user experience.

[peter...@gmail.com]

+1 on too aggressive. 

We have customers who have used our WebGL app for over a year with no issue. Now they have an issue because of the blacklisting and we look stupid for taking them down this path. The solution was to use Firefox.

[pe...@kokowa.co]

agree. +1 on too aggressive.

[robert...@gmail.com]

+1, no issues until recently. Now I'm having to restart the browser upwards of three times a day.

[pallz...@gmail.com]

Same as above, 2011 MBP, never had real issues with my HD 3000 until few days back. What's worse, using ignore-gpu-blacklist results in WebGL crashing all the time now. 

[emile...@gmail.com]

Ah, so this is why I no longer can load WebGL on Chrome? Seems a bit silly to blacklist it. I was experiencing no issues prior to this week, and suddenly I can't use WebGL anymore.

I think it would be a better decision to allow its use, if it crashes on someone for the moment that's still a better outcome than not being able to use it at all. For most applications it's working perfectly fine for me.

[Tarek Sherif]

There should really be more awareness when making decisions like this that there are businesses that are depending on Chrome's WebGL support. We've generally recommended people use our product via Chrome, but will likely stop doing so if updates like these are going to be made so recklessly.

[Peter Saal]

+1

--
You received this message because you are subscribed to a topic in the Google Groups "Chromium-reviews" group.
To unsubscribe from this topic, visit https://groups.google.com/a/chromium.org/d/topic/chromium-reviews/I6dL_9IAwiE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to chromium-reviews+unsubscribe@chromium.org.

--

Peter Saal

Phone: +1.303.578.9085

Skype: PLSAAL

[elfra...@gmail.com]

+1 on aggressive
awful UX

[vasilis...@gmail.com]

Same here. Never had issues with my MBP2011 running webgl content, but no... Chrome devs had to ruin the day without a hint of warning!! Totally irresponsible decision and just looks like laziness on their behalf.

[cra...@gmail.com]

+1 for being sad about this. I totally understand the reasons behind wanting to disable it for an overall less crashy user experience, but we've made several technical decisions based on decent webGL support being wide spread, and now it seems like we may have to reconsider because of this. Is there some way of letting a user enable/disable webGL for each tab and/or rendering instance, just like how flash works? At least then there would be a nicer UI for opting into a potentially crashy experience rather than having to set it via options.

[tir...@gmail.com]

I have the same problem on Macbook Air 2011 with HD3000.   It was running fine until yesterday when the HD300 was blacklisted.  I don't understand why Safari works but not Chrome?

[dub...@gmail.com]

I hope this issue gets fixed. Now I can't code Three.js stuff and use Chrome? WebGL works fine on Firefox and Safari so please optimize the code on Chrome. WebGL never crashed for me on HD3000. I thought Chrome was the better browser. 

On Wednesday, June 15, 2016 at 6:07:37 PM UTC-7, ccam...@chromium.org wrote:

[Páll Zoltán]

Hi guys,

I'm back again because few days ago WebGL started crashing again. I've been using Chrome with ignore-gpu-blacklist and everything worked fine. Due to some update, Google Maps won't work with WebGL anymore, it just crashes and falls back to the simple version. Any idea what's going on?

Here's my chrome://gpu output: http://pastebin.com/2XqqwfAk

Cheers,

Z.

--
You received this message because you are subscribed to a topic in the Google Groups "Chromium-reviews" group.
To unsubscribe from this topic, visit https://groups.google.com/a/chromium.org/d/topic/chromium-reviews/I6dL_9IAwiE/unsubscribe.

To unsubscribe from this group and all its topics, send an email to chromium-revie...@chromium.org.

[kte...@gmail.com]

+1 too aggressive. WebGL has worked fine for years (late 2011 MBP). Now without explicit explanation Chrome has no WebGL support. Computers are not becoming obsolete as fast as they used to. 

[arnaud...@gmail.com]

+1 too aggressive. I had google map 3d working perfectly on MBP late 2011, but cant use it anymore after chrome update. Anyone knows what is the latest chrome version that doesnt black liste Intel HD 3000 grapic card?

[rma...@rmart.in]

+1 this feels too aggressive. I'm in a situation now where I may have to buy a new computer just to use Chrome + WebGL. Not super happy about that :/

[nik....@gmail.com]

I have a Mac Mini with an Intel HD 3000 graphics card. I'm seeing an issue where WebGL works in Firefox and Safari, but not Chrome. See: https://productforums.google.com/forum/?utm_medium=email&utm_source=footer#!msg/chrome/co6w-9D1ZWo/PkVV2yMsBQAJ