Why always get "WARNING: Scripts have changed since pre-upload was allowed." when doing repo upload . ?

[Scott Cunningham]

I get this WARNING whenever I run "repo upload .":

scunningham@xot:~/chromiumos/chromeos-admin$ repo upload .

WARNING: Scripts have changed since pre-upload was allowed.

Repo must run the script:

  /usr/local/google/home/scunningham/chromiumos/src/repohooks/pre-upload.py

Do you want to allow this script to run (yes/yes-never-ask-again/NO)? yes

Why am I getting this warning, and how do I make it stop?

[Miao-chen Chou]

Hi,

You can skip the pre-upload check using 'repo upload --no-verify .' However, it should be used only if it's for sure that the warning is harmless or not applicable.

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en

---
You received this message because you are subscribed to the Google Groups "Chromium OS dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-os-dev+unsubscribe@chromium.org.

[Dan Shi]

I think the promt pops up again if there is any presubmit check changes, yes-never-ask-again is the option to stop the prompt until another change in presubmit.

Dan

[Mike Frysinger]

correct!

-mike

[Daniel Erat]

Does this prompt exist for the case where you don't trust other committers to not check in malicious presubmit scripts? If so, I think that our builds already run such a huge amount of checked-in code (with access to run as root, no less) that I don't see any value from the prompt. Is there some way we can suppress it entirely? 

If anyone on the team actually manually reviews the presubmit changes before proceeding whenever they see this instead of just automatically typing "yes-never-ask-again", my hat's off to them.

[Mike Frysinger]

I actually just landed a CL in repo to make this simpler for many of the reasons you cited. the release was yesterday with the new code. we have to roll it into our copy in depot_tools, and then you should really only ever see the prompt once per repo checkout.

-mike

[Mike Frysinger]

hopefully we should have a new version of repo in depot_tools this/next week which would include this improvement

-mike