repo upload similarity

[Lutz Justen]

Does repo upload support a way to specify similarity for detecting moves vs delete/adds?

I see that git cl upload has a --similarity option, but what about repo upload?

I have a CL where my local git detected a move, but Gerrit didn't.

Thanks!

[Mike Frysinger]

repo upload is dumb (as in KISS).  it just pushes commits to gerrit.  any checks run on the code are entirely on our hands via the repohooks code, and we don't have anything in there afaik.

-mike

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en

[Lutz Justen]

Got it, thanks! Are we setting a higher threshold than 50%? My changes had similarity between 51% and 54%.

I ended up working around it by doing the move in a separate CL first. 

--

Dr. Lutz Justen
Software Engineer
lju...@google.com

Google Germany GmbH
ABC-Str. 19
20354 Hamburg

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.    

This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person.

Der Inhalt dieser E-Mail spiegelt den derzeitigen Stand der Verhandlungen wider und dient als Basis für weitere Gespräche. Er soll keine rechtlich verbindliche Verpflichtung begründen. Eine solche Verpflichtung wird allein durch einen zwischen allen beteiligten Parteien abgeschlossenen, schriftlichen Vertrag geschaffen.

The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.

[Mike Frysinger]

i have no idea what gerrit settings are tuned to.  there's an internal gerritcodereview-users@ group you could prob inquiry on :).

-mike

[Lutz Justen]

Thanks. For future reference, it's 60% in Gerrit, whereas git uses 50% by default.