system_api

11 views

Skip to first unread message

Luigi Semenzato

unread,

Oct 12, 2017, 3:08:15 PM10/12/17

to Chromium OS dev

Is there any good reason why system_api is in src/platform instead of
src/platform2? Most of the stuff it defines is used in platform2, and
this could theoretically cause confusion. Not that it confused me,
not for a minute. I am asking for a friend.

Mike Frysinger

unread,

Oct 12, 2017, 3:21:22 PM10/12/17

to Luigi Semenzato, Chromium OS dev

system_api is shared with Chromium checkouts. that doesn't mean it can't be merged, but i've heard whispers that Chromium doesn't want to include platform2. not that i've heard any actual reason as to why it'd be a problem considering it's not a large checkout.

-mike

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en

Satoru Takabayashi

unread,

Oct 12, 2017, 10:30:54 PM10/12/17

to Mike Frysinger, Luigi Semenzato, Chromium OS dev, Daniel Erat

platform/system_api was introduced in August 2011, that was before platform2 was enabled in September 2013.

Since platform2 git repo is just 69MB (system_api is 4MB), it may be alright to include in the Chromium checkout via DEPS. derat@, what do you think?

One problem is that DEPS is currently shared between Linux desktop and Chrome OS [1], hence 69MB will be wasted for developers who only work on Chrome for Linux.

[1] IIRC, it's possible to introduce Chrome OS-only DEPS but it'll require reconfiguration of every Chrome OS build bot, which is a lot of work.

Daniel Erat

unread,

Oct 13, 2017, 12:47:42 PM10/13/17

to Satoru Takabayashi, Mike Frysinger, Luigi Semenzato, Chromium OS dev

I'd prefer to keep system_api in its own repository. I'm concerned that if we import all of platform2 into Chrome, people will start depending on arbitrary code from it instead of keeping shared code in system_api.

Luigi Semenzato

unread,

Oct 13, 2017, 12:58:26 PM10/13/17

to Daniel Erat, Satoru Takabayashi, Mike Frysinger, Chromium OS dev

OK it's probably no big deal. I should use cs/ more often instead of
find | xargs grep. Thanks.

Kevin Cernekee

unread,

Oct 13, 2017, 1:40:56 PM10/13/17

to Luigi Semenzato, Daniel Erat, Satoru Takabayashi, Mike Frysinger, Chromium OS dev

On Fri, Oct 13, 2017 at 9:58 AM, Luigi Semenzato <seme...@chromium.org> wrote:

OK it's probably no big deal. I should use cs/ more often instead of
find | xargs grep. Thanks.

I like to symlink the dbus-constants.h for shill into my shill source directory, so that ctags indexes those constants. The same trick may be helpful if you're working on a platform2 daemon.