chromeos-chrome fails on boards with x11

[Markus Doehr]

Since some time now boads with x11 enabled (instead of freon) fail building in webtrc:

chromeos-chrome-57.0.2941.0_rc-r1: [21/17036] CXX obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_x11.o
chromeos-chrome-57.0.2941.0_rc-r1: FAILED: obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_x11.o
chromeos-chrome-57.0.2941.0_rc-r1: x86_64-cros-linux-gnu-g++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_x11.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PDF=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH -DENABLE_EXTERNAL_AUTH -DHAVE_OPENSSL_SSL_H -DHAVE_SCTP -DHAVE_SRTP -DHAVE_WEBRTC_VIDEO -DHAVE_WEBRTC_VOICE -DLOGGING_INSIDE_WEBRTC -DSSL_USE_OPENSSL -DUSE_WEBRTC_DEV_BRANCH -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DCHROMEOS -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DNO_MAIN_THREAD_WRAPPING -I../../../../../chromeos-cache/distfiles/target/chrome-src/src -Igen -I../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/webrtc_overrides -I../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party -I/build/siau/usr/include/glib-2.0 -I/build/siau/usr/lib64/glib-2.0/include -I../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/libyuv/include -fno-strict-aliasing -funwind-tables -fPIC -pipe -m64 -march=x86-64 -pthread -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../../../../../../build/siau -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -fno-rtti -fno-exceptions -pipe -pipe -pipe -march=x86-64 -msse3 -D__google_stl_debug_vector=1  -c ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc -o obj/third_party/webrtc/modules/desktop_capture/desktop_capture/screen_capturer_x11.o
chromeos-chrome-57.0.2941.0_rc-r1: ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc: In static member function 'static std::unique_ptr<webrtc::DesktopCapturer> webrtc::DesktopCapturer::CreateRawScreenCapturer(const webrtc::DesktopCaptureOptions&)':
chromeos-chrome-57.0.2941.0_rc-r1: ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc:415:10: error: cannot bind 'std::unique_ptr<webrtc::{anonymous}::ScreenCapturerLinux>' lvalue to 'std::unique_ptr<webrtc::{anonymous}::ScreenCapturerLinux>&&'
chromeos-chrome-57.0.2941.0_rc-r1:    return capturer;
chromeos-chrome-57.0.2941.0_rc-r1:           ^
chromeos-chrome-57.0.2941.0_rc-r1: In file included from /usr/lib/gcc/x86_64-cros-linux-gnu/4.9.x/include/g++-v4/memory:81:0,
chromeos-chrome-57.0.2941.0_rc-r1:                  from ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc:13:
chromeos-chrome-57.0.2941.0_rc-r1: /usr/lib/gcc/x86_64-cros-linux-gnu/4.9.x/include/g++-v4/bits/unique_ptr.h:220:2: note: initializing argument 1 of 'std::unique_ptr<_Tp, _Dp>::unique_ptr(std::unique_ptr<_Up, _Ep>&&) [with _Up = webrtc::{anonymous}::ScreenCapturerLinux; _Ep = std::default_delete<webrtc::{anonymous}::ScreenCapturerLinux>; <template-parameter-2-3> = void; _Tp = webrtc::DesktopCapturer; _Dp = std::default_delete<webrtc::DesktopCapturer>]'
chromeos-chrome-57.0.2941.0_rc-r1:   unique_ptr(unique_ptr<_Up, _Ep>&& __u) noexcept
chromeos-chrome-57.0.2941.0_rc-r1:   ^
chromeos-chrome-57.0.2941.0_rc-r1: ../../../../../chromeos-cache/distfiles/target/chrome-src/src/third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc:416:1: error: control reaches end of non-void function [-Werror=return-type]
chromeos-chrome-57.0.2941.0_rc-r1:  }
chromeos-chrome-57.0.2941.0_rc-r1:  ^
chromeos-chrome-57.0.2941.0_rc-r1: cc1plus: all warnings being treated as errors

Am I missing something obvious? If I compile manually chrome builds fine except for this one file.

-- 

Markus

[Vincent Palatin]

Yes that WAI ?  X11 support is gone,

now that the last boards have been 'freonized' thanks to the huge effort from the graphics team,

X11 leftovers are cleaned up, I think the effort is tracked there : https://bugs.chromium.org/p/chromium/issues/detail?id=655820

[Markus Doehr]

Am I missing something obvious?

Yes that WAI ?  X11 support is gone,

now that the last boards have been 'freonized' thanks to the huge effort from the graphics team,

X11 leftovers are cleaned up, I think the effort is tracked there : https://bugs.chromium.org/p/chromium/issues/detail?id=655820

Oh... I see... wasn't aware of that...

Well, I guess then I can stop trying. I was aiming on putting older Lenovo Thinkpad devices back to work, they mostly have older Radeon devices that are (for whatever reason) not working with freon but were working really well with X11.

-- 

M.