How to get Chrome features from ash/ ?

16 views

Skip to first unread message

Sonny Sasaka

unread,

Mar 13, 2018, 5:59:28 AM3/13/18

to Chromium OS dev

Hi Chrome OS Dev,

I realized that including "chrome/common/chrome_features.h" from ash is disallowed. What is the right way to get Chrome features from ash/ ? Or maybe the question should be: what is the right way to define a feature that can be read by both Chrome and ash? Thank you!

Daniel Erat

unread,

Mar 13, 2018, 6:36:07 PM3/13/18

to Sonny Sasaka, Chromium-dev

[cc chromium-dev, bcc chromium-os-dev]

Yes, //ash can't depend on //chrome. I see //ash/public/cpp/ash_features.h, and I also see various files in //chrome including it. (I don't know whether this code will need to be updated for Mustash or if there's already a mechanism in place to make these features accessible to Chrome when Ash and Chrome are running in separate processes.)

On Tue, Mar 13, 2018 at 4:58 AM, Sonny Sasaka <sonny...@chromium.org> wrote:

Hi Chrome OS Dev,

I realized that including "chrome/common/chrome_features.h" from ash is disallowed. What is the right way to get Chrome features from ash/ ? Or maybe the question should be: what is the right way to define a feature that can be read by both Chrome and ash? Thank you!

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en