How does cros-bot update the chrome ebuild

[Sean]

I noticed that the chromeos-chrome ebuild is updated by cros-bot instead of a human.  How are these changes computed?

[Mike Frysinger]

if you want to get a change into the tree, you make it to the 9999 ebuild, get it reviewed & merged via gerrit like a normal CL, then the Chrome/Chromium PFQ bots verify the new ebuild/chrome sources before pushing a revbump

-mike

On Mon, Jun 6, 2016 at 4:00 PM, Sean <sk...@chromium.org> wrote:

I noticed that the chromeos-chrome ebuild is updated by cros-bot instead of a human.  How are these changes computed?

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en

[Sean]

I assume that the order of operations should be:

1) land change to 9999 ebuild

2) commit change to Chromium

3) bot picks up the change and updates the versioned ebuild

[Mike Frysinger]

because of slop between the trees being in sync (and making sure they're both green/uprevving), it's usually recommended to do something like:

- land the change in Chromium first, but do it in such a way that it doesn't break things if it isn't enabled/whatever

- land the change in the ebuild to enable the new flag/setting/whatever

- drop the old/dead code from Chromium once CrOS has pulled in the new version

hope that isn't too vague/general for your use case

-mike

--

[Daniel Erat]

You typically don't need to update the ebuild when you make a change to the Chromium source (unless you're doing something like using a new shared library or changing build flags).

Chromium source changes are integrated automatically by the PFQ. The procedure that Mike described is for updating the ebuild itself.

--

[Mike Frysinger]

you could also land the CrOS change sooner/at the same time if it's non-fatal.  but i want to say gn is not terribly friendly when given flags/options it doesn't know about which forces you to update Chromium first.  the good news is as soon as the Chromium CL is accepted, you can move forward with the CrOS one.

-mike