[PATCH 0/8] dbus-c++: stability fixes and improvements

23 views
Skip to first unread message

John Ernberg

unread,
Jan 8, 2016, 5:57:09 AM1/8/16
to chromiu...@chromium.org
From: John Ernberg <john.e...@actia.se>

Sending these fixes as a patch set on the mailing list as my project
lead doesn't allow me to spend the necessary time to submit these
patches through the proper system.

This patch set includes everything we fixed up including crashes and
memory leaks.

Each patch is entirely independent making it very easy to select the
desired changes.

John Ernberg (8):
Fix std::string property casting
Handle exceptions in async mode.
Don't crash if signature of signal is different from the expected.
Rename async adapters
Properly unref glib timeout on BusTimeout disable
Fix crash in handling of messages with a NULL-interface
Don't incref steal_reply Messages
Properly unref BusWatch on disable

include/dbus-c++/object.h | 14 +++++++----
include/dbus-c++/property.h | 2 +-
src/glib-integration.cpp | 2 ++
src/object.cpp | 57 +++++++++++++++++++++++++++++++++++----------
src/pendingcall.cpp | 2 +-
tools/ef-adaptor-stubs.tpl | 28 +++++++++++-----------
6 files changed, 72 insertions(+), 33 deletions(-)

--
1.9.1

Mike Frysinger

unread,
Jan 8, 2016, 2:34:51 PM1/8/16
to John Ernberg, chromiu...@chromium.org
since you're using git, why can't you run this one command ?
$ git push cros HEAD:refs/for/master
(assuming "cros" is the name of your remote ... otherwise you can replace it with the git repo URL)

that'll upload the patches to gerrit
-mike


--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en



John Ernberg

unread,
Jan 11, 2016, 2:47:12 AM1/11/16
to Mike Frysinger, chromiu...@chromium.org
Hi Mike,

Can I do that without a gerrit account?
I wasn't allowed to go through with that process which is why I posted them here.

Best regards // John Ernberg

Mike Frysinger

unread,
Jan 12, 2016, 2:45:41 AM1/12/16
to John Ernberg, chromiu...@chromium.org
you need to sign into gerrit once to create your account.  what aren't you allowed to do ?  sign in ?  if you have a Google account, all you do is click "sign in" in the upper right.  if you want to keep authorship info w/your actia.se address, that's fine too -- just associate it with your gerrit account under:

John Ernberg

unread,
Jan 12, 2016, 7:09:07 AM1/12/16
to Mike Frysinger, chromiu...@chromium.org
Hi Mike,

I do not have a google account. This is unfortunately where my project lead said stop: setting it up, connecting it with my @actia.se address and then submitting in gerrit.


Best regards // John Ernberg

Bonta Marian

unread,
Jan 9, 2017, 2:48:24 PM1/9/17
to Chromium OS dev, john.e...@actia.se
Hi, 

Where could I get these patches? 
Thanks. 
Reply all
Reply to author
Forward
This conversation is locked
You cannot reply and perform actions on locked conversations.
0 new messages