third_party/speex: OWNERS missing

[Thiago Farina]

Hi chromiumers,

Is there someone familiar with speex library, that would be fine to own it?

Maybe the same owners of content/browser/speech/OWNERS and flac? Tommi, Philip?

Thanks!

--

Thiago Farina

[Philip Jägenstedt]

Given the very low activity (one commit in 2014) I'm OK with that. It seems that replacing its use with Opus would be a good idea though.

[Tommi]

Sgtm. Where is it being used?

[Philip Jägenstedt]

The only usage seems to be in content/browser/speech/audio_encoder.cc, just like with third_party/flac. However, it looks like all the calls to AudioEncoder::Create use kDefaultAudioCodec, which is AudioEncoder::CODEC_FLAC, so perhaps all speex-related code is just dead code and should be removed?

[João Paulo Santos Almeida]

People,

I not know what is e-mail, please remove my email it.

Thanks

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

[PhistucK]

If you meant to unsubscribe -

Try sending a blank e-mail to chromium-discu...@chromium.org (note that +unsubscribe in the address, it is important). If you already did exactly that, skip this.

If that does not work and you are still getting e-mails -

1. Go to https://groups.google.com/a/chromium.org/forum/m/#!forum/chromium-discuss.

2. Click on the button that has an icon of a head and shoulders.

3. Click on "Leave group" and you are done. Or -

 a. Select in the selection box - "Don't send email updates".

 b. Click on "Save".

☆PhistucK

[Jeremy Roman]

Replace chromium-discuss with chromium-dev. :)

[PhistucK]

Damn. It has been so long since someone needed those instructions, so I forgot I had to change before submitting. Thank you for reminding me!

☆PhistucK

[Thiago Farina]

On Sun, Jul 5, 2015 at 3:07 AM, Tommi <to...@chromium.org> wrote:

Sgtm. Where is it being used?

I will send a CL for this later today.

--

Thiago Farina

[Thiago Farina]

On Sun, Jul 5, 2015 at 8:13 AM, Philip Jägenstedt <phi...@opera.com> wrote:

The only usage seems to be in content/browser/speech/audio_encoder.cc, just like with third_party/flac. However, it looks like all the calls to AudioEncoder::Create use kDefaultAudioCodec, which is AudioEncoder::CODEC_FLAC, so perhaps all speex-related code is just dead code and should be removed?

I will take a look and possibly file a bug to track this work/removal. Thanks for looking into this too!

--

Thiago Farina

[Tommi]

Thanks Thiago.  The remoting code might also need to be looked at.  See here.

[Thiago Farina]

Done. https://codereview.chromium.org/1223413004

--

Thiago Farina