Draws chromium tab bar'shape

[Zhong]

hello guys,

    I want to change the shape of the tab bar, but i can't find how chromium draws it, so anybody could help me? thanks!

[PhistucK]

This old change list implemented the Material Design edition of the tab strip, maybe that will help -

https://chromium.googlesource.com/chromium/src/+/8cad69317a709849eccedcaf3822e3e55f993db5%5E%21/#F3

I believe the shape is drawn by code (see some lineTo calls), not using an image.

☆PhistucK

On Fri, May 18, 2018 at 3:16 AM Zhong <xiuhao...@gmail.com> wrote:

hello guys,

    I want to change the shape of the tab bar, but i can't find how chromium draws it, so anybody could help me? thanks!

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/edbbf50d-3879-403b-8d66-cb56eb6e580b%40chromium.org.

[Peter Kasting]

On Thu, May 17, 2018 at 5:15 PM Zhong <xiuhao...@gmail.com> wrote:

hello guys,

    I want to change the shape of the tab bar, but i can't find how chromium draws it, so anybody could help me? thanks!

Individual tabs are drawn by chrome/browser/ui/views/tabs/tab.cc.  The overall tabstrip layout is handled by chrome/browser/ui/views/tabs/tab_strip.cc.

This code is under heavy development right now (I have a local CL in progress which changes a thousand lines), so if you begin touching it locally you are likely to have a lot of merge conflicts to resolve in the future.

PK

[Paul A. Simpson]

Hi Peter,

Out of curiosity, is the macOS multi-select and drag tabs bug going to be fixed in your 1000 line CL? I will switch to Canary in a heartbeat whenever that fix lands.

Thanks.

[Avi Drissman]

There was briefly a bug in Chrome 66 where multi-select then drag of tabs on the Mac was broken. It was fixed.

If you are still experiencing it, and your Chrome is up-to-date, please file a bug at new.crbug.com. That should be working.

Avi

--

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/eafedd36-71e0-4cb7-8676-728a8b02f167%40chromium.org.

[Paul A. Simpson]

Thank you Avi. There is already an open bug report that is listed as "Available:"

https://bugs.chromium.org/p/chromium/issues/detail?id=409144

I'm happy to open another one if there's something wrong with that bug report - let me know.

FWIW, it still repros for me on Chrome 66.x and 68.x. As far as I can recall, this has been broken for me for years, although I've only been keeping a close eye on this issue for about 12-18 months.

Thanks.

[Avi Drissman]

Oh, within the window. Yes, that's the appropriate bug.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/e9a26cc1-930e-463c-8713-8b63708224b9%40chromium.org.

[Paul A. Simpson]

👍

I know there's a lot of work going on with Views right now - is there reason for near-term optimism that a fix will come as part of the MacViews deployment? Phase 4 of MacViews should be fairly soon, if I'm not mistaken?

[Avi Drissman]

I ran a test with a local build with MacViews turned on, and things worked. This will almost certainly be resolved with it shipping.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/868c9290-b3c1-418d-b0a6-fc482734e736%40chromium.org.

[Paul A. Simpson]

That's great to hear; thanks so much for taking the time to test it.