Build chrome 55.0.2883.87 success but launch with error on Window

[Erxin Shang]

Build chrome 55.0.2883.87 base on the release tags with these steps. 

1. Set up necessary environment and VS 2015 Update 3

2. fetch chromium

3. cd src && git checkout -b branch55 55.0.2883.87

4. cd .. && gclient sync --with_branch_heads --job 16

5. gn gen out\Default

6. ninja -C out\Default chrome

The build is successful but with two link warning 

After build success try to run chrome.exe in out put will get error 

OS: Window 10

Also tried window server 2012 R2, same error. 

Any suggestions? Thanks in advance! 

Regards,

Edwin

[Erxin Shang]

BTW, I could build && run latest chromium successfully. Did I miss configure anything? 

Regards

Edwin

[Erxin Shang]

Update more detail about the error:

The exception is happened in navigation_handle_impl.cc

bool NavigationHandleImpl::IsSamePage() {

  DCHECK(state_ == DID_COMMIT || state_ == DID_COMMIT_ERROR_PAGE)

      << "This accessor should not be called before the navigation has "

         "committed.";

  return is_same_page_;

}

Does anyone know what's the main reason about why do we need to check the page is same or not?

Thanks in advance.

Regards,

Edwin

On Monday, April 17, 2017 at 5:06:26 PM UTC+8, Erxin Shang wrote:

[Erxin Shang]

I have found a workaround for this issue. Currently don't know the influence but it make the browser start successful. 

The workaround is just comment the DCHECK statement. 

Regards, 

Edwin

On Monday, April 17, 2017 at 5:06:26 PM UTC+8, Erxin Shang wrote:

[yuhou wang]

this week I also built chrome 55.0.2883.87 successfully and ran into this issue. Is there official fix for this issue?

[Ian Clelland]

There won't be an official fix -- Chrome 55 was released in November 2016, and so is almost 18 months old now. The best course of action would be to update to something (much) more recent. If there was an actual issue, it would likely have already been fixed in the intervening releases. (Along with many, many other bugs)

For what it's worth, that DCHECK was removed in M56, but as part or a larger reorganization. I wouldn't know if it's correct to remove it without making any other changes.

See https://codereview.chromium.org/2345053006 for the actual change, if you want to try to understand all of the context around it.

But seriously, you probably shouldn't be using M55 for anything other than historical research if you can help it.

On Tue, Apr 17, 2018 at 11:17 PM yuhou wang <wang...@sina.com> wrote:

this week I also built chrome 55.0.2883.87 successfully and ran into this issue. Is there official fix for this issue?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/7a85b6d5-68b5-4585-b21b-1569152f35ec%40chromium.org.