compositor_impl_android.cc CompositorImpl::SetRootLayer possibly broken?

[Сергей Кузнецов]

Hi all!

I think that CompositorImpl::SetRootLayer function possibly broken.

 

https://cs.chromium.org/chromium/src/content/browser/renderer_host/compositor_impl_android.cc?q=CompositorImpl::SetRootLayer&sq=package:chromium&l=434

1) subroot_layer_->RemoveFromParent(); doesn't have effect, because is subroot_layer_ is root_window_->GetLayer() and doesn't have parent

2) Calling SetRootLayer with nullptr (it is legitimate call) crashes because root_window_->GetLayer() is not nullptr

 

Does that make sense?