working in third_party repos (mirrored)

28 views
Skip to first unread message

Thiago Farina

unread,
Jun 26, 2015, 7:46:55 PM6/26/15
to Chromium-dev
Hi,

Are the instructions in https://www.chromium.org/developers/how-tos/get-the-code/working-with-nested-repos up-to-date? I'm following them for the http://src.chromium.org/svn case, where I'm trying to make a patch for third_party/flac.

The command lines I ran was:

$ export DIR=flac
$ cd third_party/${DIR}
$ git svn init --prefix=origin/ -T trunk/deps/third_party/${DIR} http://src.chromium.org/svn
$ git config svn-remote.svn.fetch trunk/deps/third_party/${DIR}:refs/remotes/origin/master
$ git config svn-remote.svn.pushurl svn://svn.chromium.org/chrome
$ git svn info
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.0039d316-1c4b-4281-b951-d872f2087c98
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.0039d316-1c4b-4281-b951-d872f2087c98
Unable to determine upstream SVN information from working tree history

Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.0039d316-1c4b-4281-b951-d872f2087c98
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.0039d316-1c4b-4281-b951-d872f2087c98
W: Ignoring error from SVN, path probably does not exist: (160013): Filesystem has no item: File not found: revision 41700, path '/trunk/deps/third_party/flac'
W: Do not be alarmed at the above message git-svn is just searching aggressively for old history.
This may take a while on large repositories
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.0039d316-1c4b-4281-b951-d872f2087c98
# Then it keeps repeating the above line like it was in forever loop.

Am I doing something wrong?

--
Thiago Farina

Robert Iannucci

unread,
Jun 27, 2015, 12:25:54 PM6/27/15
to tfa...@chromium.org, Chromium-dev, aga...@google.com
+Aaron Gable I think that these just recently got converted to all-git.  

All you need to do now is clone https://chromium.googlesource.com/chromium/deps/flac.git, make your changes, submit the CL and land it with `git cl`, then roll DEPS in chromium/src.git

I'll take a stab at updating the instructions.

R

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

Robert Iannucci

unread,
Jun 27, 2015, 12:26:35 PM6/27/15
to tfa...@chromium.org, Chromium-dev, aga...@google.com
Oh, and if you already have a chromium/src checkout, then you already have a clone of the repo.

Robert Iannucci

unread,
Jun 27, 2015, 12:51:09 PM6/27/15
to tfa...@chromium.org, Chromium-dev, aga...@google.com
PTAL the new instructions. They should work a lot better I think.

Aaron/anyone, can you verify that I updated them correctly?

R

Thiago Farina

unread,
Jun 27, 2015, 4:18:07 PM6/27/15
to Robert Iannucci, Chromium-dev
On Sat, Jun 27, 2015 at 1:50 PM, Robert Iannucci <iann...@chromium.org> wrote:
PTAL the new instructions. They should work a lot better I think.

Yup! Thanks for the update Robert! They worked for me and I uploaded https://codereview.chromium.org/1214023002/ for review.

--
Thiago Farina
Reply all
Reply to author
Forward
0 new messages