PSA: Rietveld becoming fully read-only

[Aaron Gable]

Hey there code reviewers!

Since Chromium started using Gerrit, we've been busy migrating the last few repositories off of Rietveld. As of next week, the last active users of Rietveld will be fully moved, so now it's time to take the next step.

On Friday, September 29, Rietveld will become fully read-only.

You will not be able to upload new changes for any repo, upload new patchsets on any change, leave comments on changes, add or change reviewers, or take any other action that would mutate Rietveld's database. Both the old and new Rietveld UIs handle this moderately gracefully; over the next few weeks we'll be removing the links and buttons that offer mutating operations to prevent confusion as well.

If you have an in-flight change still on Rietveld, you will need to either land it in the next week, or use "git cl issue 0 && git cl upload" to reupload the change to Gerrit.

If you have any questions, please feel free to reach out to me on infr...@chromium.org. If you discover particularly bad behaviors on Rietveld, or (later on) think that I have missed removing a mutating link or button, please file a bug in the Infra>Codereview>Rietveld component.

Thanks, and happy reviewing!

Aaron

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2cgp%2BPkZqbPsV0hPkkeiotViO%2Bnp6RoCgSJTRGobqN18g%40mail.gmail.com.

[Aaron Gable]

Reminder: this is happening tomorrow. The last project on Rietveld is being disabled as I type this. I'll update this thread again tomorrow after the database goes read-only!

Aaron

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2ekq9c1RBdCPtf%2Bry_%2B9DEwQRaNqWXWWmmYSC-UCh6hmQ%40mail.gmail.com.

[Nico Weber]

I still leave comments on old reviews several times a week. What's the recommended replacement for that? Filing a crbug with a link to the review and manually cc'ing reviewers?

(I'm mostly asking so that we can all do something consistent instead of everyone inventing their own convention.)

On Thu, Sep 28, 2017 at 7:53 PM, Aaron Gable <aga...@chromium.org> wrote:

Reminder: this is happening tomorrow. The last project on Rietveld is being disabled as I type this. I'll update this thread again tomorrow after the database goes read-only!

Aaron

On Thu, Sep 21, 2017 at 11:26 PM Aaron Gable <aga...@chromium.org> wrote:

Hey there code reviewers!

Since Chromium started using Gerrit, we've been busy migrating the last few repositories off of Rietveld. As of next week, the last active users of Rietveld will be fully moved, so now it's time to take the next step.

On Friday, September 29, Rietveld will become fully read-only.

You will not be able to upload new changes for any repo, upload new patchsets on any change, leave comments on changes, add or change reviewers, or take any other action that would mutate Rietveld's database. Both the old and new Rietveld UIs handle this moderately gracefully; over the next few weeks we'll be removing the links and buttons that offer mutating operations to prevent confusion as well.

If you have an in-flight change still on Rietveld, you will need to either land it in the next week, or use "git cl issue 0 && git cl upload" to reupload the change to Gerrit.

If you have any questions, please feel free to reach out to me on infr...@chromium.org. If you discover particularly bad behaviors on Rietveld, or (later on) think that I have missed removing a mutating link or button, please file a bug in the Infra>Codereview>Rietveld component.

Thanks, and happy reviewing!

Aaron

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2ekq9c1RBdCPtf%2Bry_%2B9DEwQRaNqWXWWmmYSC-UCh6hmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH58R2ekq9c1RBdCPtf%2Bry_%2B9DEwQRaNqWXWWmmYSC-UCh6hmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAMGbLiFhdfBEvGLxzVxP45GR7rwHSYKWuzK4mEiv_Laib31daQ%40mail.gmail.com.

[Dirk Pranke]

Sending an email to the CL author and/or reviewers, or filing a bug and cc'ing the author and reviewers, depending on the severity,

seem like good options to me.

-- Dirk

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAMGbLiFhdfBEvGLxzVxP45GR7rwHSYKWuzK4mEiv_Laib31daQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+unsubscribe@chromium.org.
To post to this group, send email to infr...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGbLiFhdfBEvGLxzVxP45GR7rwHSYKWuzK4mEiv_Laib31daQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEoffTCBBdnu060Q1o-3-YOHdZhEZeHzxS1VydnXB%3D07cKWyow%40mail.gmail.com.

[Aaron Gable]

Great question! For the sake of preserving data for posterity, I second Dirk's second suggestion: file a bug and CC the relevant people. It seems likely that this accurately represents the usecase of most old comments: "hey, this broke thing X", or "I'm going to revert part of this". If you comment on old changes just to ask questions about the reasoning behind them, then informal email makes sense to me.

Speaking of which, this is now done! In the coming time I'll be removing all mutating APIs and UI elements from Rietveld to prevent confusion, but aside from that the site is now static. The king is dead, long live the king!

Aaron

On Fri, Sep 29, 2017 at 12:20 PM Dirk Pranke <dpr...@chromium.org> wrote:

Sending an email to the CL author and/or reviewers, or filing a bug and cc'ing the author and reviewers, depending on the severity,

seem like good options to me.

-- Dirk

On Fri, Sep 29, 2017 at 11:27 AM, Nico Weber <tha...@chromium.org> wrote:

I still leave comments on old reviews several times a week. What's the recommended replacement for that? Filing a crbug with a link to the review and manually cc'ing reviewers?

(I'm mostly asking so that we can all do something consistent instead of everyone inventing their own convention.)

On Thu, Sep 28, 2017 at 7:53 PM, Aaron Gable <aga...@chromium.org> wrote:

Reminder: this is happening tomorrow. The last project on Rietveld is being disabled as I type this. I'll update this thread again tomorrow after the database goes read-only!

Aaron

On Thu, Sep 21, 2017 at 11:26 PM Aaron Gable <aga...@chromium.org> wrote:

Hey there code reviewers!

Since Chromium started using Gerrit, we've been busy migrating the last few repositories off of Rietveld. As of next week, the last active users of Rietveld will be fully moved, so now it's time to take the next step.

On Friday, September 29, Rietveld will become fully read-only.

You will not be able to upload new changes for any repo, upload new patchsets on any change, leave comments on changes, add or change reviewers, or take any other action that would mutate Rietveld's database. Both the old and new Rietveld UIs handle this moderately gracefully; over the next few weeks we'll be removing the links and buttons that offer mutating operations to prevent confusion as well.

If you have an in-flight change still on Rietveld, you will need to either land it in the next week, or use "git cl issue 0 && git cl upload" to reupload the change to Gerrit.

If you have any questions, please feel free to reach out to me on infr...@chromium.org. If you discover particularly bad behaviors on Rietveld, or (later on) think that I have missed removing a mutating link or button, please file a bug in the Infra>Codereview>Rietveld component.

Thanks, and happy reviewing!

Aaron

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2ekq9c1RBdCPtf%2Bry_%2B9DEwQRaNqWXWWmmYSC-UCh6hmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH58R2ekq9c1RBdCPtf%2Bry_%2B9DEwQRaNqWXWWmmYSC-UCh6hmQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAMGbLiFhdfBEvGLxzVxP45GR7rwHSYKWuzK4mEiv_Laib31daQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.

To post to this group, send email to infr...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGbLiFhdfBEvGLxzVxP45GR7rwHSYKWuzK4mEiv_Laib31daQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2cvf6HzN_5Nung07JoT-8ddY%2BicJThp5UjvrCoeScV-kQ%40mail.gmail.com.

[anatoly techtonik]

Should it be backed up to Web Archive?

> https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAH58R2cvf6HzN_5Nung07JoT-8ddY%2BicJThp5UjvrCoeScV-kQ%40mail.gmail.com.



--
anatoly t.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAPkN8xJkQUO0E7fQMPe-EntXoWGFno9xY2tV8%2BB0HgtSFSdTgA%40mail.gmail.com.

[Aaron Gable]

The site is still serving, and will remain so indefinitely to avoid breaking old urls embedded in docs, commit messages, bugs, and email threads. Only the ability to modifying the contents has been removed.

I'm certainly in favor of getting archive.org to index as much as possible, but it isn't necessary to preserve information for posterity at this point.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2fDYWO7U3sORydVZBZWdWwzY3OfGXdGu-9yvfm3B32zow%40mail.gmail.com.

[Ken Rockot]

What are the chances we could move old chromium rietveld CLs to new gerrit CLs? Is it feasible to retroactively create a gerrit CL from an already-merged commit?

>>>> an email to infra-announce+unsubscribe@chromium.org.

>>>> To post to this group, send email to infra-a...@chromium.org.
>>>> To view this discussion on the web visit
>>>> https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2ekq9c1RBdCPtf%2Bry_%2B9DEwQRaNqWXWWmmYSC-UCh6hmQ%40mail.gmail.com.
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "blink-dev" group.
>>>> To view this discussion on the web visit
>>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH58R2ekq9c1RBdCPtf%2Bry_%2B9DEwQRaNqWXWWmmYSC-UCh6hmQ%40mail.gmail.com.
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "infra-announce" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an

>>> email to infra-announce+unsubscribe@chromium.org.

>>> To post to this group, send email to infra-a...@chromium.org.
>>>
>>> To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAMGbLiFhdfBEvGLxzVxP45GR7rwHSYKWuzK4mEiv_Laib31daQ%40mail.gmail.com.
>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "infra-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an

>>> email to infra-dev+unsubscribe@chromium.org.

>>> To post to this group, send email to infr...@chromium.org.
>>> To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGbLiFhdfBEvGLxzVxP45GR7rwHSYKWuzK4mEiv_Laib31daQ%40mail.gmail.com.
>
> --
> You received this message because you are subscribed to the Google Groups
> "infra-announce" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to infra-announce+unsubscribe@chromium.org.

> To post to this group, send email to infra-a...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2cvf6HzN_5Nung07JoT-8ddY%2BicJThp5UjvrCoeScV-kQ%40mail.gmail.com.
>
> --
> You received this message because you are subscribed to the Google Groups
> "infra-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to infra-dev+unsubscribe@chromium.org.

> To post to this group, send email to infr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAH58R2cvf6HzN_5Nung07JoT-8ddY%2BicJThp5UjvrCoeScV-kQ%40mail.gmail.com.



--
anatoly t.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAH58R2fDYWO7U3sORydVZBZWdWwzY3OfGXdGu-9yvfm3B32zow%40mail.gmail.com.

--

You received this message because you are subscribed to the Google Groups "blink-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAH58R2fDYWO7U3sORydVZBZWdWwzY3OfGXdGu-9yvfm3B32zow%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CA%2BapAgFjb9xM4fT7MyM9HzOcyj06azcjYxPqFW-cJ%2BvHEw43sg%40mail.gmail.com.

['Nodir Turakulov' via infra-announce]

bcc: infra-announce@

cc: infra-dev@

i think it is possible to create Gerrit CLs based on old revisions. We cannot modify git commits that point to Rietveld URLs (hash would change), but we can modify codereview.chromium.org to redirect to mirrored Gerrit CLs.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CA%2BapAgFjb9xM4fT7MyM9HzOcyj06azcjYxPqFW-cJ%2BvHEw43sg%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAFckvjV_Biqb0u%3DGwnSzdN6wogtvfiqV%3DxR2T3B0i_uC4m01iA%40mail.gmail.com.