About DIA SDK

[Ivan L]

Hi,

I was trying recently to build target `All` from Chromium 35 on Windows. And it doesn't work. My little investigation led me to the absence of the DIA SDK. This SDK is required by `static_initializers` that was added here https://codereview.chromium.org/66613003 . And then (or before) the actual auto-extraction was added here https://codereview.chromium.org/150333005 - especially the line is interesting:

(r'professionalcore\Setup\vs_professionalcore.msi', False),

As far as I understand the DIA SDK is a part of VS2013 Pro, which is commercial, and it's not part of auto-downloaded VS Express by `toolchain2013.py` . Is it a Chromium-way to require some commercial non-redistributable stuff to build particular targets? Even if it is ok, why add this target to the `All`?

[Sébastien Marchand]

Which target is failing to build? Can you give us the error message?

Thanks.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

[Greg Thompson]

Building "all" probably isn't a useful goal. Build only what you care about. "chrome", "mini_installer", "unit_tests", etc are interesting targets to build. Have a look in src/build/all.gyp for a list of other composite targets (e.g., "chromium_builder" or somesuch) that the builders use.

--

[Лежанкин Иван]

Target is `static_initializers`.

Error message:

src/tools/win/static_initializers/static_initializers.cc:5 fatal error C1083: Cannot open include file: 'dia2.h': No such file or directory

[Thiago Farina]

On Tue, Apr 15, 2014 at 11:20 AM, Лежанкин Иван <aby...@gmail.com> wrote:

Target is `static_initializers`.

Error message:

src/tools/win/static_initializers/static_initializers.cc:5 fatal error C1083: Cannot open include file: 'dia2.h': No such file or directory

If I recall correctly, Scott wrote this tool.

Looks like you don't have this header in your path though.

--

Thiago Farina

[Thiago Farina]

On Tue, Apr 15, 2014 at 1:24 PM, Thiago Farina <tfa...@chromium.org> wrote:

On Tue, Apr 15, 2014 at 11:20 AM, Лежанкин Иван <aby...@gmail.com> wrote:

Target is `static_initializers`.

Error message:

src/tools/win/static_initializers/static_initializers.cc:5 fatal error C1083: Cannot open include file: 'dia2.h': No such file or directory

If I recall correctly, Scott wrote this tool.

Yes, see https://chromium.googlesource.com/chromium/chromium/+/b7f471060c9bb66a3bc8610421708c79502a61cd

--

Thiago Farina

[Scott Graham]

Sorry about that, I'll make it conditional based on availability of the dia sdk.

--

[Лежанкин Иван]

That sounds great! Can you provide, please, the link to CL in this thread, when you're done?

Thank you, Scott.

[Scott Graham]

https://codereview.chromium.org/239603002/

[w...@chromium.org]

Also - although DIA SDK is shipped with VS2013, unfortunately there is a bug in the VS2013 installer whereby if you have VS2012 installed and then install VS2013 on top, then it doesn't correctly install the DIA SDK for VS2013 (!!).  You need to manually copy it from your VS2012 directory to able to use it.  I had to do this for my install even though I was using VS2013 pro.

The MS connect bug is here: http://connect.microsoft.com/VisualStudio/feedback/details/814147 if you want to marvel at the glory of it.

Will