gfx_unittests on android

10 views
Skip to first unread message

Alok Priyadarshi

unread,
May 9, 2015, 1:30:47 AM5/9/15
to Chromium-dev, Scott Violet, Scott Graham
While reading ui/gfx/screen_android.cc, I suspected that there is a bug in the way display bounds are computed. So to confirm I wrote a unittest and sent it to the trybots:


It looks like gfx_unittests is not being run on any android bot. Can someone confirm if that is true? If so, is it intentional or just an oversight?

Thiago Farina

unread,
May 9, 2015, 2:08:12 PM5/9/15
to Alok Priyadarshi, Chromium-dev, Scott Violet, Scott Graham, Dirk Pranke
I think it is an oversight, looking at https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/chromium_trybot.json#157, if I understand it right, it might be running only on chromeos configs, right?

Let me see if adding a 'platforms' linux helps.

--
Thiago Farina

Thiago Farina

unread,
May 9, 2015, 3:04:06 PM5/9/15
to Alok Priyadarshi, Chromium-dev, Scott Violet, Scott Graham, Dirk Pranke
Follow up:

I have uploaded the following patches to help address this:


NOTE: 1 might not be necessary. 2 might depend on 3. I will wait for the trybot results to see what happens and wait for the reviewers feedback to see if this is correct or not.

I have copied you on all the above patches, so you don't miss the progress of this.

--
Thiago Farina
Reply all
Reply to author
Forward
0 new messages