Bringing back enable_webrtc?

[Allan Sandfeld Jensen]

I noticed while updating our embedded project to Chromium 68 that you have
removed the enable_webrtc option because it didn't build for a couple of
releases. I can confirm it didn't build for a long time, we had patches
locally to fix it, but I admit I didn't really think of upstreaming them,
fixing combinations of options that we need, but doesn't build out of the box
is everyday life for an embedder of Chromium, we have fixes like that for many
more Chromium options that doesn't build out the box.

Since WebRTC is a very large feature with many third party dependencies and it
is not that commonly used or needed, it is one of the biggest things we can
disable for customers to bring the size of Chromium down. I would very much
like to keep the option to disable it. We will be reverting the patches in our
branch, but would like to bring it back upstream as well, and will promise to
upstream patches maintaining it in the future if necessary.

Would it be acceptable?

Best regards
'Allan Sandfeld Jensen
Principal Engineer
The Qt Company

[Dirk Pranke]

I would be theoretically open to keeping it working -- i.e. to help embedders if this really is a common need -- but it would depend on the impact to the code base. Any sense of how big that'd be?

I would also probably defer to the media and other platform folks if they had compelling reasons for making it be mandatory.

-- Dirk

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
    http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/23624630.1r3eYUQgxm%40twilight.

[Brett Wilson]

You can see the patch that removed the defines:

https://chromium-review.googlesource.com/c/chromium/src/+/1059408

There were a lot, and they were in some really hairy files where we'd want to reduce complexity.

According to the change that removed the flag (also relatively large):

https://chromium-review.googlesource.com/c/chromium/src/+/1044220

it was "broken for months and no one has noticed".

Brett

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAEoffTCQGt8AoorgGGRUssTq5Hm23Uh2yvHegf_A%2B9Rzz5_8_g%40mail.gmail.com.

[Allan Sandfeld Jensen]

On Freitag, 24. August 2018 22:27:31 CEST Brett Wilson wrote:
> You can see the patch that removed the defines:
> https://chromium-review.googlesource.com/c/chromium/src/+/1059408
>
> There were a lot, and they were in some really hairy files where we'd want
> to reduce complexity.
>
> According to the change that removed the flag (also relatively large):
> https://chromium-review.googlesource.com/c/chromium/src/+/1044220
> it was "broken for months and no one has noticed".
>

Well, we noticed, but fixing it was very minor things like updating some
arguments to functions that now took one more argument. This is the kind of
stuff that usually just gets fixed in the next release of Chrome, but I can
see how that attitude can be a problem if all embedders think like that.

Br.
Allan

[Matthew Menke]

473 lines of code across 84 files seems a bit much to disable a feature.  Maybe there are different places we could make the cut that aren't quite as intrusive?

[Niklas Enbom]

On Fri, Aug 24, 2018 at 7:35 PM 'Matthew Menke' via Chromium-dev <chromi...@chromium.org> wrote:

473 lines of code across 84 files seems a bit much to disable a feature.  Maybe there are different places we could make the cut that aren't quite as intrusive?

 

That's because "WebRTC" isn't a single feature. And yes, if we reintroduce the flag it would make sense if was more clear what feature you disable, PeerConnection, Remoting etc.

 

On Friday, August 24, 2018 at 4:42:14 PM UTC-4, Allan Sandfeld Jensen wrote:

On Freitag, 24. August 2018 22:27:31 CEST Brett Wilson wrote:
> You can see the patch that removed the defines:
> https://chromium-review.googlesource.com/c/chromium/src/+/1059408
>
> There were a lot, and they were in some really hairy files where we'd want
> to reduce complexity.
>
> According to the change that removed the flag (also relatively large):
> https://chromium-review.googlesource.com/c/chromium/src/+/1044220
> it was "broken for months and no one has noticed".
>
Well, we noticed, but fixing it was very minor things like updating some
arguments to functions that now took one more argument. This is the kind of
stuff that usually just gets fixed in the next release of Chrome, but I can
see how that attitude can be a problem if all embedders think like that.

Br.
Allan

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/ade95923-24e5-47e3-8049-33ea0006aeaf%40chromium.org.