PSA: Cross-references for Android C++ code now available in Chromium Code Search

[js...@chromium.org]

Hi all,

If you don't use Chromium Code Search, you can stop reading now.

Over the last quarter we've been working on supporting Xrefs for multiple platforms in Code Search. The first stage of this is now ready for general use: you can view C++ Xrefs for Android code by selecting Target OS > Android from the dropdown in the top right, or by adding the ?targetos=chromium-android query parameter to the URL.

Here's an example: https://cs.chromium.org/chromium/src/chrome/common/chrome_switches.cc?targetos=chromium-android&l=767

If you have any issues, please feel free to file feedback either in Monorail (using the Infra>Codesearch component) or using the "Feedback" link in Code Search itself.

Thanks,

Joey

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/e1636c0a-9ab1-4f8a-9f25-1527d87bed4f%40chromium.org.

[Peter Kasting]

On Tue, Jun 19, 2018 at 12:39 PM <js...@chromium.org> wrote:

If you don't use Chromium Code Search, you can stop reading now.

Over the last quarter we've been working on supporting Xrefs for multiple platforms in Code Search. The first stage of this is now ready for general use: you can view C++ Xrefs for Android code by selecting Target OS > Android from the dropdown in the top right, or by adding the ?targetos=chromium-android query parameter to the URL.

Here's an example: https://cs.chromium.org/chromium/src/chrome/common/chrome_switches.cc?targetos=chromium-android&l=767

This is cool.  Really glad to see this work started :)

Two questions:

1) I don't seem to have a dropdown until I click the link you gave.  Is this still being rolled out?

2) Is the eventual plan to union the xrefs (or provide an option like "all" in this dropdown), or is per-platform xrefs the final goal?

PK

[Joey Scarr]

Answers inline.

 

1) I don't seem to have a dropdown until I click the link you gave.  Is this still being rolled out?

Thanks for the report; it seems there may be a bug where it doesn't appear if you come in from a search or navigating through the file pane (but it does work if you load the URL directly). I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=854325 and will look into this ASAP.

In the meantime, the workaround is to refresh the page if the dropdown doesn't appear.

 

2) Is the eventual plan to union the xrefs (or provide an option like "all" in this dropdown), or is per-platform xrefs the final goal?

Yes, showing a unified version of the xrefs is the eventual plan. This is just step 1 :)

Thanks,

Joey

[dan...@chromium.org]

Thank you so much for working on this!! This has been such a blue sky wish for me for many years.

You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e1636c0a-9ab1-4f8a-9f25-1527d87bed4f%40chromium.org.

[Dominic Mazzoni]

Yes, thank you so much, this is a great improvement!

Do you have a roadmap, what's next? Platforms like macOS, Windows? Other languages like JavaScript?

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHtyhaSn7W9oHYqM%2BnZK0K1W2BU--WOTQhUciPFi2iLTMYzJSg%40mail.gmail.com.

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
https://groups.google.com/a/chromium.org/group/chromium-os-dev
---
You received this message because you are subscribed to the Google Groups "Chromium OS Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-os-d...@chromium.org.

[Erik Chen]

Whoo super awesome. :)

+1 for support for macOS/Windows.

On Tue, Jun 19, 2018 at 4:56 PM, 'Dominic Mazzoni' via Chromium-dev <chromi...@chromium.org> wrote:

Yes, thank you so much, this is a great improvement!

Do you have a roadmap, what's next? Platforms like macOS, Windows? Other languages like JavaScript?

On Tue, Jun 19, 2018 at 1:52 PM <dan...@chromium.org> wrote:

Thank you so much for working on this!! This has been such a blue sky wish for me for many years.

On Tue, Jun 19, 2018 at 3:39 PM <js...@chromium.org> wrote:

Hi all,

If you don't use Chromium Code Search, you can stop reading now.

Over the last quarter we've been working on supporting Xrefs for multiple platforms in Code Search. The first stage of this is now ready for general use: you can view C++ Xrefs for Android code by selecting Target OS > Android from the dropdown in the top right, or by adding the ?targetos=chromium-android query parameter to the URL.

Here's an example: https://cs.chromium.org/chromium/src/chrome/common/chrome_switches.cc?targetos=chromium-android&l=767

If you have any issues, please feel free to file feedback either in Monorail (using the Infra>Codesearch component) or using the "Feedback" link in Code Search itself.

Thanks,

Joey

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/e1636c0a-9ab1-4f8a-9f25-1527d87bed4f%40chromium.org.

--

You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e1636c0a-9ab1-4f8a-9f25-1527d87bed4f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHtyhaSn7W9oHYqM%2BnZK0K1W2BU--WOTQhUciPFi2iLTMYzJSg%40mail.gmail.com.

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
https://groups.google.com/a/chromium.org/group/chromium-os-dev
---
You received this message because you are subscribed to the Google Groups "Chromium OS Development" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-os-dev+unsubscribe@chromium.org.

--
--
Chromium Developers mailing list: chromi...@chromium.org

View archives, change email options, or unsubscribe:

http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAFz-FYwYxnras0YXdSBXK%3Dt3xGmLcofdxpNLDw%3Dit3%3DhtgLTLQ%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-announc...@chromium.org.
To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAEYHnr3DbftF8RVjKE_bNB8SwMKb4%3D924Bnxj%2BpsH2HPy5GJqw%40mail.gmail.com.

[Joey Scarr]

Next on the roadmap is Windows and better support for ChromeOS, then Mac and iOS further down the line.

Languages other than C++ are out-of-scope for the time being, since there are some significant infrastructure changes required before these can be implemented. But we're definitely thinking about it :)

On Tue, Jun 19, 2018 at 1:56 PM, Dominic Mazzoni <dmaz...@google.com> wrote:

Yes, thank you so much, this is a great improvement!

Do you have a roadmap, what's next? Platforms like macOS, Windows? Other languages like JavaScript?

On Tue, Jun 19, 2018 at 1:52 PM <dan...@chromium.org> wrote:

Thank you so much for working on this!! This has been such a blue sky wish for me for many years.

On Tue, Jun 19, 2018 at 3:39 PM <js...@chromium.org> wrote:

Hi all,

If you don't use Chromium Code Search, you can stop reading now.

Over the last quarter we've been working on supporting Xrefs for multiple platforms in Code Search. The first stage of this is now ready for general use: you can view C++ Xrefs for Android code by selecting Target OS > Android from the dropdown in the top right, or by adding the ?targetos=chromium-android query parameter to the URL.

Here's an example: https://cs.chromium.org/chromium/src/chrome/common/chrome_switches.cc?targetos=chromium-android&l=767

If you have any issues, please feel free to file feedback either in Monorail (using the Infra>Codesearch component) or using the "Feedback" link in Code Search itself.

Thanks,

Joey

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/e1636c0a-9ab1-4f8a-9f25-1527d87bed4f%40chromium.org.

--

You received this message because you are subscribed to the Google Groups "blink-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/e1636c0a-9ab1-4f8a-9f25-1527d87bed4f%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "infra-announce" group.

To unsubscribe from this group and stop receiving emails from it, send an email to infra-announce+unsubscribe@chromium.org.

To post to this group, send email to infra-a...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-announce/CAHtyhaSn7W9oHYqM%2BnZK0K1W2BU--WOTQhUciPFi2iLTMYzJSg%40mail.gmail.com.

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
https://groups.google.com/a/chromium.org/group/chromium-os-dev
---
You received this message because you are subscribed to the Google Groups "Chromium OS Development" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-os-dev+unsubscribe@chromium.org.

[Joey Scarr]

Update: the bug mentioned upthread has been fixed, so the dropdown should now be working for everyone.