C++17 in Chromium

[Long Le]

Now C++17 is officially newest standard of C++ with many good features, can we now use it in Chromium ? If not what is the challenge for us to apply this standard? 

[Daniel Cheng]

https://bugs.chromium.org/p/chromium/issues/detail?id=752720 has more info about what's blocking the move to C++17.

Daniel

On Wed, May 9, 2018 at 11:04 PM Long Le <philo...@gmail.com> wrote:

Now C++17 is officially newest standard of C++ with many good features, can we now use it in Chromium ? If not what is the challenge for us to apply this standard? 

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/eea38fed-4b15-42aa-a44d-c18ec55d8e07%40chromium.org.

[PhistucK]

The Google Style Guide mandates most of the new feature usage. Some features are dimmed unreadable, confusing, unmaintainable or similar, so they are not allowed.

Plus, features may be banned if the compilers used to compile Chromium do not support them, or their support is buggy.

https://chromium-cpp.appspot.com/

☆PhistucK

On Thu, May 10, 2018 at 9:04 AM Long Le <philo...@gmail.com> wrote:

Now C++17 is officially newest standard of C++ with many good features, can we now use it in Chromium ? If not what is the challenge for us to apply this standard? 

--

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev...@chromium.org.

[Taiju Tsuiki]

The main part of Chromium is getting ready to compile in C++17. And, the major blockers of C++17 are NaCl and libchrome.

pnacl-clang in NaCl toolchain is based on clang-3.7.0, which doesn't support C++17. I don't know much about its deprecation status, but it's likely alive for awhile.

libchrome is the other. It's a subset of chrome that is imported to Android repository, pulled to ChromeOS, and used for several services including ARC++. As it's linked to Android framework itself to talk to Chrome with Mojo for ARC++, we may have to migrate Android framework to C++17 first.

2018年5月10日(木) 15:09 PhistucK <phis...@gmail.com>:

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABc02_LcssLQBGVSdXQCFgzDM8XQNOHewFyEu6sHp-%2BdMQ%2Bryg%40mail.gmail.com.

[Nico Weber]

libchrome hasn't been an issue for any other toolchain changes (c++11, 14, lld, etc) -- are you sure that's a blocker?

NaCl has been an issue for all toolchain changes though.

On Thu, May 10, 2018 at 8:03 AM, Taiju Tsuiki <tz...@chromium.org> wrote:

The main part of Chromium is getting ready to compile in C++17. And, the major blockers of C++17 are NaCl and libchrome.

pnacl-clang in NaCl toolchain is based on clang-3.7.0, which doesn't support C++17. I don't know much about its deprecation status, but it's likely alive for awhile.

libchrome is the other. It's a subset of chrome that is imported to Android repository, pulled to ChromeOS, and used for several services including ARC++. As it's linked to Android framework itself to talk to Chrome with Mojo for ARC++, we may have to migrate Android framework to C++17 first.

2018年5月10日(木) 15:09 PhistucK <phis...@gmail.com>:

The Google Style Guide mandates most of the new feature usage. Some features are dimmed unreadable, confusing, unmaintainable or similar, so they are not allowed.

Plus, features may be banned if the compilers used to compile Chromium do not support them, or their support is buggy.

https://chromium-cpp.appspot.com/

☆PhistucK

On Thu, May 10, 2018 at 9:04 AM Long Le <philo...@gmail.com> wrote:

Now C++17 is officially newest standard of C++ with many good features, can we now use it in Chromium ? If not what is the challenge for us to apply this standard? 

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/eea38fed-4b15-42aa-a44d-c18ec55d8e07%40chromium.org.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CABc02_LcssLQBGVSdXQCFgzDM8XQNOHewFyEu6sHp-%2BdMQ%2Bryg%40mail.gmail.com.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAFK_eqR7BP_2GmbPA-pn24pFz9k%2BV-uHR%3D_1cQgu7LGw_Pxo6w%40mail.gmail.com.

[Allan Sandfeld Jensen]

As an embedder I would really prefer we kept a more steady pace and stuck with
C++14 for a while. It would make it easier to maintain on non-default
configurations.

Besides C++14 has only recently been fully accepted in Chromium, and is still
used somewhat inconsistenly. I think it would be better to not to mix even
more haphazard refactoring in. The recent addition of constexpr everywhere
meant it was incorrectly used in several dozen places because it appears clang
is more forgiving in incorrect usage than other compilers.

Best regard
'Allan

[Allan Sandfeld Jensen]

I forgot to ask: Is there anything in particular from C++17 you want to use
for something critical?

'Allan