Proguard failures on ToT Android build

[Ken Rockot]

Clean output dir, unmodified ToT checkout. I don't see failures on any builders, but I can't get chrome_public_apk built locally. GN config has no relevant settings as far as I can tell (is_debug, is_component_build, goma setup, and gaia stuff).

The problem is specifically with the chrome_public_apk__proguard action. I have no idea where to begin with this, but the output is below:

[2729/2730] ACTION //chrome/android:chrome_public_apk__proguard(//build/toolchain/android:arm)
FAILED: gen/chrome/android/chrome_public_apk__proguard.d gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.dump gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.seeds gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.mapping gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.usage 
python ../../build/android/gyp/proguard.py --depfile gen/chrome/android/chrome_public_apk__proguard.d --proguard-path ../../third_party/proguard/lib/proguard.jar --output-path gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar --classpath ../../third_party/android_tools/sdk/platforms/android-23/android.jar --proguard-configs=\[\"gen/chrome/android/chrome_public_apk/chrome_public_apk.resources.proguard.txt\",\ \"../../chrome/android/java/proguard.flags\"\] --input-paths=@FileArg\(gen/chrome/android/chrome_public_apk.build_config:proguard:input_paths\)
Traceback (most recent call last):
  File "../../build/android/gyp/proguard.py", line 77, in <module>
    sys.exit(main(sys.argv[1:]))
  File "../../build/android/gyp/proguard.py", line 73, in main
    output_paths=[options.output_path])
  File "/work/chrome/src/build/android/gyp/util/build_utils.py", line 527, in CallAndWriteDepfileIfStale
    pass_changes=True)
  File "/work/chrome/src/build/android/gyp/util/md5_check.py", line 87, in CallAndRecordIfStale
    function(*args)
  File "/work/chrome/src/build/android/gyp/util/build_utils.py", line 511, in on_stale_md5
    function(*args)
  File "/work/chrome/src/build/android/gyp/util/proguard_util.py", line 179, in CheckOutput
    stderr_filter=stderr_filter)
  File "/work/chrome/src/build/android/gyp/util/build_utils.py", line 174, in CheckOutput
    raise CalledProcessError(cwd, args, stdout + stderr)
util.build_utils.CalledProcessError: Command failed: ( cd /work/chrome/src/out/dr; java -jar ../../third_party/proguard/lib/proguard.jar -forceprocessing -libraryjars ../../third_party/android_tools/sdk/platforms/android-23/android.jar -injars gen/chrome/android/chrome_public_apk/chrome_public_apk.jar:lib.java/third_party/gif_player/gif_player_java.jar:lib.java/third_party/leakcanary/leakcanary_noop_java.jar:lib.java/chrome/android/webapk/libs/common/common_java.jar:lib.java/third_party/WebKit/public/blink_headers_java.jar:lib.java/third_party/android_tools/android_support_v13_java.jar:lib.java/third_party/android_tools/android_support_multidex_java.jar:lib.java/third_party/jsr-305/jsr_305_javalib.jar:lib.java/ui/accessibility/ui_accessibility_java.jar:lib.java/third_party/android_tools/legacy_http_javalib.jar:lib.java/base/base_java.jar:lib.java/components/bookmarks/common/android/bookmarks_java.jar:lib.java/components/variations/android/variations_java.jar:lib.java/media/capture/video/android/capture_java.jar:lib.java/third_party/android_data_chart/android_data_chart_java.jar:lib.java/chrome/android/webapk/libs/client/client_java.jar:lib.java/third_party/android_swipe_refresh/android_swipe_refresh_java.jar:lib.java/components/safe_json/android/safe_json_java.jar:lib.java/media/midi/midi_java.jar:lib.java/components/navigation_interception/android/navigation_interception_java.jar:lib.java/third_party/android_protobuf/protobuf_nano_javalib.jar:lib.java/components/web_restrictions/web_restrictions_java.jar:lib.java/printing/printing_java.jar:lib.java/third_party/cardboard-java/cardboard-java.jar:lib.java/third_party/android_tools/android_gcm_java.jar:lib.java/mojo/public/java/system.jar:lib.java/device/bluetooth/java.jar:lib.java/mojo/public/java/bindings.jar:lib.java/device/battery/mojo_bindings_java.jar:lib.java/third_party/WebKit/public/android_mojo_bindings_java.jar:lib.java/third_party/custom_tabs_client/custom_tabs_support_lib.jar:lib.java/components/policy/android/policy_java.jar:lib.java/net/android/net_java.jar:lib.java/mojo/android/system_java.jar:lib.java/ui/android/ui_java.jar:lib.java/components/precache/android/precache_java.jar:lib.java/third_party/android_tools/android_support_design_java.jar:lib.java/third_party/android_tools/android_support_v7_appcompat_java.jar:lib.java/third_party/cacheinvalidation/cacheinvalidation_proto_java.jar:lib.java/device/usb/java.jar:lib.java/device/vr/java.jar:lib.java/components/invalidation/impl/proto_java.jar:lib.java/media/base/android/media_java.jar:lib.java/components/dom_distiller/android/dom_distiller_core_java.jar:lib.java/device/battery/android/battery_monitor_android.jar:lib.java/chrome/android/document_tab_model_info_proto_java.jar:lib.java/device/power_save_blocker/java.jar:lib.java/device/vibration/mojo_bindings_java.jar:lib.java/third_party/android_tools/android_support_v7_recyclerview_java.jar:lib.java/third_party/android_tools/android_support_v7_mediarouter_java.jar:lib.java/third_party/android_media/android_media_java.jar:lib.java/third_party/android_tools/google_play_services_default_java.jar:lib.java/device/vibration/android/vibration_manager_android.jar:lib.java/third_party/cacheinvalidation/cacheinvalidation_javalib.jar:lib.java/components/gcm_driver/instance_id/android/instance_id_driver_java.jar:lib.java/sync/android/sync_java.jar:lib.java/components/signin/core/browser/android/java.jar:lib.java/content/public/android/content_java.jar:lib.java/components/web_contents_delegate_android/web_contents_delegate_android_java.jar:lib.java/components/gcm_driver/android/gcm_driver_java.jar:lib.java/components/service_tab_launcher/service_tab_launcher_java.jar:lib.java/components/invalidation/impl/java.jar:lib.java/components/dom_distiller/android/dom_distiller_content_java.jar:lib.java/chrome/android/chrome_java.jar -include gen/chrome/android/chrome_public_apk/chrome_public_apk.resources.proguard.txt -include ../../chrome/android/java/proguard.flags -outjars gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar -dump gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.dump -printseeds gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.seeds -printusage gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.usage -printmapping gen/chrome/android/chrome_public_apk/chrome_public_apk.proguard.jar.mapping )
Warning: library class android.webkit.WebView depends on program class android.net.http.SslCertificate
Warning: library class android.webkit.WebView depends on program class android.net.http.SslCertificate
Warning: there were 2 instances of library classes depending on program classes.
         You must avoid such dependencies, since the program classes will
         be processed, while the library classes will remain unchanged.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#dependency)
Error: Please correct the above warnings first.

[Scott Graham]

Maybe the people involved with https://codereview.chromium.org/2069213002 know what's up.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Nico Weber]

(To save others the click, it sounds like https://codereview.chromium.org/2103193002/ should've fixed this on trunk 10h ago.)

[Ken Rockot]

On Jun 29, 2016 5:49 AM, "Nico Weber" <tha...@chromium.org> wrote:

(To save others the click, it sounds like https://codereview.chromium.org/2103193002/ should've fixed this on trunk 10h ago.)

Thanks Nico, can confirm.

Thanks Scott for the other link as well - with that I was able to patch in a suppression and get a local build working.