../../ui/base/cocoa/touch_bar_forward_declarations.h:121:15: error: not currently inside '#pragma clang assume_nonnull'

[Brook Hong]

Hi spqchan,

Build breaks as titled.

../../ui/base/cocoa/touch_bar_forward_declarations.h:121:15: error: not currently inside '#pragma clang assume_nonnull'

#pragma clang assume_nonnull end

@spq...@chromium.org

diff --git a/ui/base/cocoa/touch_bar_forward_declarations.h b/ui/base/cocoa/touch_bar_forward_declarations.h

index ce03c6aae01f..82136f279098 100644

--- a/ui/base/cocoa/touch_bar_forward_declarations.h

+++ b/ui/base/cocoa/touch_bar_forward_declarations.h

@@ -10,10 +10,10 @@

 #import <Foundation/Foundation.h>

 

 #include "ui/base/ui_base_export.h"

+#pragma clang assume_nonnull begin

 

 #if !defined(MAC_OS_X_VERSION_10_12_1)

 

-#pragma clang assume_nonnull begin

 

 @class NSTouchBar, NSTouchBarItem;

 @protocol NSTouchBarDelegate;

[Jayson Adams]

Please file a bug.

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/1a1c7bc1-ba39-4616-b136-ad29f9af8b40%40chromium.org.

[Sarah]

I'm currently investigating this

[Alexis Menard]

Hi,

Shouldn't this be fixed with https://codereview.chromium.org/2835693003/ ?

Thanks.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/c3f390b1-5e1a-41df-919f-d1f093ed4e32%40chromium.org.

[Sarah]

It should've fixed it, so I'm not sure why the error is still there. I'm looking to see if there's anything that's missing.

Brock, are you using the latest code?

[Alexis Menard]

The proposed patch in his original email is what I landed, so I don't think he is using the latest code.

[Sarah]

So that's what that snippet was. I thought it was part of the CL that was recently landed.