When does a change enter canary/dev?

[Chris Mumford]

Let's say I've made a change to Chrome (https://chromium.googlesource.com/chromium/src.git) and I'd like to know the first canary/dev release that contained that change. How do I figure that out?

[Nico Weber]

https://omahaproxy.appspot.com/

On Wed, Jan 7, 2015 at 9:39 AM, Chris Mumford <cmum...@chromium.org> wrote:

Let's say I've made a change to Chrome (https://chromium.googlesource.com/chromium/src.git) and I'd like to know the first canary/dev release that contained that change. How do I figure that out?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev

[Chris Mumford]

Thx Nico:

Those seem to be version → commit, and not commit → version which is what I'm looking for. So if I wanted to figure out when my change (de701ab) first landed in a dev channel how do I use that site?

I can see, from omahaproxy, that the current "dev" (for Windows) is 41.0.2267.0, and the previous one is 41.0.2251.0. If I run:

git branch -r --contains de701ab

then I can see that it first landed in branch 2251, so that's an easy one to figure out. But what if my change is older - like fecd7c1 which first appeared in 2248? How do I know what channel 2248 was in?

[Michael Moss]

$ git name-rev --tags de701ab

de701ab tags/41.0.2251.0~68

which says that the first tag (release version) with that commit is 41.0.2251.0.

[Michael Moss]

See also https://www.kernel.org/pub/software/scm/git/docs/user-manual.html#finding-tagged-descendants for a whole lot more explanation (and alternative commands) than you probably ever cared about.

[Chris Mumford]

And by the mere fact that 41 hasn't yet gone beta then that means that the branch is either canary or dev right? If a branch is no longer on omahaproxy is there a way to figure out which channel?

[Michael Moss]

I'm not entirely sure I understand the question, but if the version that name-rev gives you is "less" than the current version of a given channel on omahaproxy, then your change is live in that channel. For example:

win canary 41.0.2268.0  > 41.0.2251.0 = in canary

win dev 41.0.2267.0  > 41.0.2251.0 = in dev

win beta 40.0.2214.45 < 41.0.2251.0 = NOT in beta

win stable 39.0.2171.95 < 41.0.2251.0 = NOT in stable

Is that what you're trying to answer?

[Rob Wu]

Those seem to be version → commit, and not commit → version which is what I'm looking for. So if I wanted to figure out when my change (de701ab) first landed in a dev channel how do I use that site?

1. Given a commit hash, visit crrev.com/de701ab.

2. Click on the "tree" link, this will bring you to https://chromium.googlesource.com/chromium/src/+/de701ab/.

3. Click on the "chrome" directory.

4. Click on the "VERSION" file: https://chromium.googlesource.com/chromium/src/+/de701ab/chrome/VERSION

This file shows the version when the patch was NOT applied yet.
MAJOR=41
MINOR=0
BUILD=2251
PATCH=0

When a new version is released, the BUILD version is bumped. So you will find your patch in releases starting at 41.0.2252.0.

These steps are accurate for dev/canary channels.

Keep in mind that patches can be reverted or merged back to previous channels (e.g. beta/stable). When such a release version gets published, the PATCH number is incremented.
Visit https://chromium.googlesource.com/chromium/src/+log/40.0.2214.0..40.0.2214.71 to see all patches that have been merged with a release channel (beta, at the moment) since 40.0.2214.0 moved from dev to beta.

To know whether the major channel is stable/beta/dev/canary, visit https://omahaproxy.appspot.com.

Kind regards,

 Rob

 https://robwu.nl

[Michael Moss]

On Wed, Jan 7, 2015 at 2:03 PM, Rob Wu <r...@robwu.nl> wrote:

Those seem to be version → commit, and not commit → version which is what I'm looking for. So if I wanted to figure out when my change (de701ab) first landed in a dev channel how do I use that site?

1. Given a commit hash, visit crrev.com/de701ab.

2. Click on the "tree" link, this will bring you to https://chromium.googlesource.com/chromium/src/+/de701ab/.

3. Click on the "chrome" directory.

4. Click on the "VERSION" file: https://chromium.googlesource.com/chromium/src/+/de701ab/chrome/VERSION

This file shows the version when the patch was NOT applied yet.
MAJOR=41
MINOR=0
BUILD=2251
PATCH=0

When a new version is released, the BUILD version is bumped. So you will find your patch in releases starting at 41.0.2252.0.

Actually, the patch is in 2251 and later. The VERSION file is bumped after the release branch is cut, so the chrome/VERSION file at the time of your commit is a good indicator of the first release that should include your commit (modulo any problems cutting that release, reverts on the branch, etc.).

[Rob Wu]

2015-01-07 23:37 GMT+01:00 Michael Moss <mm...@chromium.org>:

On Wed, Jan 7, 2015 at 2:03 PM, Rob Wu <r...@robwu.nl> wrote:

Those seem to be version → commit, and not commit → version which is what I'm looking for. So if I wanted to figure out when my change (de701ab) first landed in a dev channel how do I use that site?

1. Given a commit hash, visit crrev.com/de701ab.

2. Click on the "tree" link, this will bring you to https://chromium.googlesource.com/chromium/src/+/de701ab/.

3. Click on the "chrome" directory.

4. Click on the "VERSION" file: https://chromium.googlesource.com/chromium/src/+/de701ab/chrome/VERSION

This file shows the version when the patch was NOT applied yet.
MAJOR=41
MINOR=0
BUILD=2251
PATCH=0

When a new version is released, the BUILD version is bumped. So you will find your patch in releases starting at 41.0.2252.0.

Actually, the patch is in 2251 and later. The VERSION file is bumped after the release branch is cut, so the chrome/VERSION file at the time of your commit is a good indicator of the first release that should include your commit (modulo any problems cutting that release, reverts on the branch, etc.).

Thanls for the correction, this makes more sense indeed.