Unlisted source files in BUILD.gn

[Taiju Tsuiki]

Hi, chromium-dev.

I did a quick check to see the consistency of BUILD.gn and the chromium source tree, and found that some files were not listed in any GN files. Here is the resulting spreadsheet.

In summary, there are 897 files not in any GN file, 809 of them are headers, 51 files look tests, and 37 are others. Tests are particularly problematic, since they are not compiled nor run on the CI.

I'd recommend owners of each directory to take a look to the sheet, and fix it if needed.

[Charles Harrison]

Thank you tzik for this work.

Can we write a presubmit for this to avoid the problem moving forward?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
---
You received this message because you are subscribed to the Google Groups "Chromium-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-dev+unsubscribe@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CAFK_eqSg890RprgmLTGntEc%2BFjf5BLNW0oeLLsVn-dsq%3D2h%2B4w%40mail.gmail.com.

[Brett Wilson]

A presubmit will be annoying to write and show to execute. Most of these files are probably legacy stuff from the GYP build. I think with the GN build people are better at keeping these up-to-date.

Brett

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/CADjAqN5SRLx3-W_YeAb7oYPOkNVJwUoyE1tN21nO746H5Nbbrg%40mail.gmail.com.

[Wei-Yin]

This bug https://bugs.chromium.org/p/chromium/issues/detail?id=661774 looks related.

[Alexei Svitkine]

Here's an older bug about it that I filed in 2012:

https://bugs.chromium.org/p/chromium/issues/detail?id=112371

There was some more recent discussion on it last year.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-dev/04dfc2ce-ea7a-4db8-95ab-3f0d730d4732%40chromium.org.