Issue 132119 in chromium: Google Chrome has crashed. Relaunch Now window is shown twice

[chro...@googlecode.com]

Status: Untriaged
Owner: ----
CC: kar...@google.com, anan...@chromium.org
Labels: Type-Regression Pri-2 Area-Internals OS-Windows Stability-Crash
Mstone-21

New issue 132119 by pucchaka...@chromium.org: Google Chrome has crashed.
Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

Chrome Version : 21.0.1171.0 (Official Build 141382)
URLs (if applicable) :
Other browsers tested:
Add OK or FAIL after other browsers where you have tested this issue:
Safari 5:
Firefox 4.x:
IE 7/8/9:

What steps will reproduce the problem?
1. Launch Chrome and induce a browser crash using
chrome://inducebrowsercrashforrealz
2. Click on "Ok" button in the Relaunch dialog.
3. Verify the behavior.

What is the expected result?
Chrome window should be opened with the info-bar giving option to
Restore the session.

What happens instead?
Chrome window is opened and an info-bar is shown asking to Restore the
session.
Whoa! Google Chrome has crashed. Relaunch Now dialog is shown again.

Please provide any additional information below. Attach a screenshot if
possible.


Attachments:
Capture.PNG 151 KB

[chro...@googlecode.com]

Comment #1 on issue 132119 by pucchaka...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

I will update the bisect info soon.

[chro...@googlecode.com]

Updates:
Cc: pav...@chromium.org
Labels: -Pri-2 Pri-1

Comment #2 on issue 132119 by pucchaka...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #3 on issue 132119 by anan...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

That is because Chrome crashed again up on relaunch. Do you see any
crash-ids?

[chro...@googlecode.com]

Comment #4 on issue 132119 by pucchaka...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

I just see one crash id getting generated in chrome://crashes

[chro...@googlecode.com]

Comment #8 on issue 132119 by pucchaka...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

This was working fine on 21.0.1156.0, 21.0.1156.1 and broken from
21.0.1157.0 (139641) onwards.

[chro...@googlecode.com]

Updates:
Labels: ReleaseBlock-Stable

Comment #12 on issue 132119 by kar...@google.com: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

robert said he'll try to take a look tomorrow. he thinks it's not a double
crash.

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: robertsh...@chromium.org

Comment #13 on issue 132119 by kar...@google.com: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

robert?

[chro...@googlecode.com]

Comment #14 on issue 132119 by robertsh...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

Turns out the second dialog is shown by the GPU process. This happens
because chrome.exe inspects an env. var at startup to determine whether to
show the restart dialog.

This env var is cleared at some point during startup but clearly not before
the GPU process is started. This causes the GPU process to also inherit the
env var and show the crash dialog. This is annoying but won't harm
functionality.

A low-side-effect workaround is in the pipes, a cleaner solution will be
needed later.

[chro...@googlecode.com]

Updates:
Cc: c...@chromium.org apatr...@chromium.org

Comment #15 on issue 132119 by robertsh...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

A fix that works, but is ugly is here:
https://chromiumcodereview.appspot.com/10657024/. Waiting for review
feedback.

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #17 on issue 132119 by robertsh...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice
http://code.google.com/p/chromium/issues/detail?id=132119

[chro...@googlecode.com]

Updates:
Labels: Merge-Requested

Comment #18 on issue 132119 by robertsh...@chromium.org: Google Chrome has

[chro...@googlecode.com]

Updates:
Labels: -Merge-Requested Merge-Approved

Comment #19 on issue 132119 by kar...@google.com: Google Chrome has

[chro...@googlecode.com]

Updates:
Labels: -Merge-Approved merge-merged-1180

Comment #20 on issue 132119 by bugdro...@chromium.org: Google Chrome has

crashed. Relaunch Now window is shown twice

http://code.google.com/p/chromium/issues/detail?id=132119#c20

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=144711

------------------------------------------------------------------------
r144711 | robert...@chromium.org | Thu Jun 28 07:13:58 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/app/breakpad_win.cc?r1=144711&r2=144710&pathrev=144711

Merge 144224 - Don't show the restart dialog in the GPU process.

BUG=132119
TEST=Go to chrome://inducebrowsercrashforrealz, observe that only a
single "Whoa!" dialog appears.


Review URL: https://chromiumcodereview.appspot.com/10657024

TBR=robert...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10689021
------------------------------------------------------------------------