ShapeDetection: adding Exposed=(Window,Worker) to idls (issue 2546293002 by mcasas@chromium.org)

[mca...@chromium.org]

Reviewers: haraken
CL: https://codereview.chromium.org/2546293002/

Message:
haraken@ PTAL/RS plz

Description:
ShapeDetection: adding Exposed=(Window,Worker) to idls

Because they are missing as [1] mentions.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c10

BUG=665150

Affected files (+30, -0 lines):
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
M third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl
M third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl


Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt b/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
index 087e8a89fc6a6116a9e15730f7013b5b5ec64e60..27fa54e893e733d7936acc37981e7f826ae3dcb4 100644
--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
@@ -1,3 +1,6 @@
+interface BarcodeDetector
+ method constructor
+ method detect
interface Blob
getter isClosed
getter size
@@ -194,6 +197,9 @@ interface ExtendableMessageEvent : ExtendableEvent
getter ports
getter source
method constructor
+interface FaceDetector
+ method constructor
+ method detect
interface FetchEvent : ExtendableEvent
getter clientId
getter isReload
Index: third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
diff --git a/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt b/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
index f7e4f6ab319586d3274da6251c8d9cc7dcaa0d40..3c39f18587dc8a78cf9b666c92de908f6c335120 100644
--- a/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
+++ b/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
@@ -1,3 +1,6 @@
+interface BarcodeDetector
+ method constructor
+ method detect
interface Blob
getter isClosed
getter size
@@ -194,6 +197,9 @@ interface ExtendableMessageEvent : ExtendableEvent
getter ports
getter source
method constructor
+interface FaceDetector
+ method constructor
+ method detect
interface FetchEvent : ExtendableEvent
getter clientId
getter isReload
Index: third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
diff --git a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
index f7914d10b44675ea191306cd4e8e9e310cadf34e..07db00e740ba5d9f3b7ddd26cfb46032a1c24524 100644
--- a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
+++ b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
@@ -5,6 +5,10 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

Starting worker: resources/global-interface-listing.js
[Worker] [INTERFACES]
+[Worker] interface BarcodeDetector
+[Worker] attribute @@toStringTag
+[Worker] method constructor
+[Worker] method detect
[Worker] interface Blob
[Worker] attribute @@toStringTag
[Worker] getter isClosed
@@ -199,6 +203,10 @@ Starting worker: resources/global-interface-listing.js
[Worker] method constructor
[Worker] method dispatchEvent
[Worker] method removeEventListener
+[Worker] interface FaceDetector
+[Worker] attribute @@toStringTag
+[Worker] method constructor
+[Worker] method detect
[Worker] interface File : Blob
[Worker] attribute @@toStringTag
[Worker] getter lastModified
Index: third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
diff --git a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
index 54c6ae46c686bc04235cad8dbbacc8add3900a65..3f2c35f6cac71fe05ccb79bbd5bc591d16e266c6 100644
--- a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
+++ b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
@@ -5,6 +5,10 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE

Starting worker: resources/global-interface-listing.js
[Worker] [INTERFACES]
+[Worker] interface BarcodeDetector
+[Worker] attribute @@toStringTag
+[Worker] method constructor
+[Worker] method detect
[Worker] interface Blob
[Worker] attribute @@toStringTag
[Worker] getter isClosed
@@ -194,6 +198,10 @@ Starting worker: resources/global-interface-listing.js
[Worker] method constructor
[Worker] method dispatchEvent
[Worker] method removeEventListener
+[Worker] interface FaceDetector
+[Worker] attribute @@toStringTag
+[Worker] method constructor
+[Worker] method detect
[Worker] interface File : Blob
[Worker] attribute @@toStringTag
[Worker] getter lastModified
Index: third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl
diff --git a/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl b/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl
index 99cd4fe9d741f2e4be56337cee1238409c16ee8e..122a3649c61a19a2ab330010b92dc643573da5ae 100644
--- a/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl
+++ b/third_party/WebKit/Source/modules/shapedetection/BarcodeDetector.idl
@@ -7,6 +7,7 @@
[
Constructor,
ConstructorCallWith=Document,
+ Exposed=(Window,Worker),
RuntimeEnabled=ShapeDetection,
] interface BarcodeDetector {
[CallWith=ScriptState] Promise<sequence<DetectedBarcode>> detect(CanvasImageSource image);
Index: third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
diff --git a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
index 03a6dd12407d1514a730b2af4ab4eee0ec1c164d..36e911284cce2d4243af171c1e86f517529abfd9 100644
--- a/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
+++ b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl
@@ -7,6 +7,7 @@
[
Constructor(optional FaceDetectorOptions faceDetectorOptions),
ConstructorCallWith=Document,
+ Exposed=(Window,Worker),
RuntimeEnabled=ShapeDetection,
] interface FaceDetector {
[CallWith=ScriptState] Promise<sequence<DetectedObject>> detect(CanvasImageSource image);

[har...@chromium.org]

LGTM


https://codereview.chromium.org/2546293002/

[commit-bot@chromium.org via codereview.chromium.org]

CQ is trying da patch. Follow status at

https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2546293002/60001


https://codereview.chromium.org/2546293002/

[commit-bot@chromium.org via codereview.chromium.org]

Committed patchset #1 (id:60001)

https://codereview.chromium.org/2546293002/

[commit-bot@chromium.org via codereview.chromium.org]

Patchset 1 (id:??) landed as
https://crrev.com/a7ef3116ec25214bca7252c56bab8840beaf45eb
Cr-Commit-Position: refs/heads/master@{#436199}

https://codereview.chromium.org/2546293002/