Use trackInfo.id instead of bytestream id for blink tracks (issue 2113173002 by servolk@chromium.org)

0 views
Skip to first unread message

ser...@chromium.org

unread,
Jun 30, 2016, 7:41:09 PM6/30/16
to wole...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org, mlamouri+w...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Reviewers: wolenetz
CL: https://codereview.chromium.org/2113173002/

Description:
Use trackInfo.id instead of bytestream id for blink tracks

Base URL: https://chromium.googlesource.com/chromium/src.git@master

Affected files (+2, -2 lines):
M third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp


Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
index d746f989912406909eac23fa1449ff42e65fc2d3..16d0963c41680e90eb92d353a6af68dd5632edab 100644
--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
@@ -746,7 +746,7 @@ bool SourceBuffer::initializationSegmentReceived(const WebVector<MediaTrackInfo>
const auto& kind = trackInfo.kind;
// 5.2.7 TODO(servolk): Implement track kind processing.
// 5.2.8.2 Let new audio track be a new AudioTrack object.
- AudioTrack* audioTrack = AudioTrack::create(byteStreamTrackID, kind, label, language, false);
+ AudioTrack* audioTrack = AudioTrack::create(trackInfo.id, kind, label, language, false);
SourceBufferTrackBaseSupplement::setSourceBuffer(*audioTrack, this);
// 5.2.8.7 If audioTracks.length equals 0, then run the following steps:
if (audioTracks().length() == 0) {
@@ -783,7 +783,7 @@ bool SourceBuffer::initializationSegmentReceived(const WebVector<MediaTrackInfo>
const auto& kind = trackInfo.kind;
// 5.3.7 TODO(servolk): Implement track kind processing.
// 5.3.8.2 Let new video track be a new VideoTrack object.
- VideoTrack* videoTrack = VideoTrack::create(byteStreamTrackID, kind, label, language, false);
+ VideoTrack* videoTrack = VideoTrack::create(trackInfo.id, kind, label, language, false);
SourceBufferTrackBaseSupplement::setSourceBuffer(*videoTrack, this);
// 5.3.8.7 If videoTracks.length equals 0, then run the following steps:
if (videoTracks().length() == 0) {


wole...@chromium.org

unread,
Jun 30, 2016, 8:05:26 PM6/30/16
to ser...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org, mlamouri+w...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 30, 2016, 8:10:21 PM6/30/16
to ser...@chromium.org, wole...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org, mlamouri+w...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 30, 2016, 8:46:16 PM6/30/16
to ser...@chromium.org, wole...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org, mlamouri+w...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Committed patchset #1 (id:1)

https://codereview.chromium.org/2113173002/

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 30, 2016, 8:46:24 PM6/30/16
to ser...@chromium.org, wole...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org, mlamouri+w...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org

commit-bot@chromium.org via codereview.chromium.org

unread,
Jun 30, 2016, 8:49:19 PM6/30/16
to ser...@chromium.org, wole...@chromium.org, commi...@chromium.org, chromium...@chromium.org, blink-...@chromium.org, har...@chromium.org, mlamouri+w...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Patchset 1 (id:??) landed as
https://crrev.com/590408ef33ec1a9615de1285c24b54edc9782839
Cr-Commit-Position: refs/heads/master@{#403377}

https://codereview.chromium.org/2113173002/
Reply all
Reply to author
Forward
0 new messages