Notify PaintLayer if ScrollsOverflow changed. [chromium/src : master]

Chris harrelson (Gerrit)

unread,

Jun 24, 2017, 4:58:55 PM6/24/17

to blink-rev...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, Dongseong Hwang

Chris harrelson uploaded patch set #3 to this change.

Notify PaintLayer if ScrollsOverflow changed.

Bug: 736173
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibafd4af308bb6eca6496d3c95afd8697b767185e
---
M third_party/WebKit/Source/core/paint/PaintLayer.cpp
M third_party/WebKit/Source/core/paint/PaintLayer.h
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
3 files changed, 4 insertions(+), 3 deletions(-)

To view, visit change 547366. To unsubscribe, visit settings.

Chris harrelson (Gerrit)

unread,

Jun 24, 2017, 4:59:12 PM6/24/17

to blink-rev...@chromium.org, blink-...@chromium.org, chromium...@chromium.org, Dongseong Hwang

Chris harrelson posted comments on this change.

View Change

Patch set 3:Commit-Queue +1

To view, visit change 547366. To unsubscribe, visit settings.

Chris harrelson (Gerrit)

unread,

Jun 26, 2017, 1:49:35 PM6/26/17

to blink-rev...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Chris harrelson posted comments on this change.

View Change

Patch set 4:Commit-Queue +1

To view, visit change 547366. To unsubscribe, visit settings.

Chris harrelson (Gerrit)

unread,

Jun 26, 2017, 2:06:49 PM6/26/17

to blink-rev...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org, Philip Rogers, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Chris harrelson posted comments on this change.

View Change

Patch set 4:

All of the rebaselines look ok. The change to scrollbars in overflow-float-stacking.html changes back to the behavior observed prior to
https://codereview.chromium.org/2522043002, because that patch resulted
in the scroller in this test being self-painting. Firefox also has a
scrollbar.

The scrollbar overlaps the adjoining content, but I think that is a bug
in float exclusion areas. Will follow up on that with szager.

To view, visit change 547366. To unsubscribe, visit settings.

Chris harrelson (Gerrit)

unread,

Jun 26, 2017, 2:06:49 PM6/26/17

to Philip Rogers, blink-rev...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org

Chris harrelson would like Philip Rogers to review this change.

View Change

Notify PaintLayer if ScrollsOverflow changed.

Bug: 736173
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibafd4af308bb6eca6496d3c95afd8697b767185e
---

M third_party/WebKit/LayoutTests/hittesting/inner-border-radius-hittest-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-float-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/linux/fast/overflow/overflow-with-local-background-attachment-expected.png
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/textarea-caret-expected.txt
M third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/css3/flexbox/flexbox-baseline-expected.png
A third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-float-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/overflow-with-local-background-attachment-expected.png
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/textarea-caret-expected.txt
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt
M third_party/WebKit/LayoutTests/platform/mac/css3/flexbox/flexbox-baseline-expected.png
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-float-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/mac/fast/overflow/overflow-with-local-background-attachment-expected.png
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/textarea-caret-expected.txt
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt
M third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-float-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-stacking-expected.png
M third_party/WebKit/LayoutTests/platform/win/fast/overflow/overflow-with-local-background-attachment-expected.png
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/textarea-caret-expected.txt
M third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/textarea-caret-expected.txt


M third_party/WebKit/Source/core/paint/PaintLayer.cpp
M third_party/WebKit/Source/core/paint/PaintLayer.h
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

30 files changed, 5 insertions(+), 124 deletions(-)

To view, visit change 547366. To unsubscribe, visit settings.

Philip Rogers (Gerrit)

unread,

Jun 26, 2017, 2:20:52 PM6/26/17

to Chris harrelson, blink-rev...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Philip Rogers posted comments on this change.

View Change

Patch set 4:Code-Review +1

To view, visit change 547366. To unsubscribe, visit settings.

Chris harrelson (Gerrit)

unread,

Jun 26, 2017, 4:24:47 PM6/26/17

to blink-rev...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org, Philip Rogers, Commit Bot, chromium...@chromium.org, Dongseong Hwang

Chris harrelson posted comments on this change.

View Change

Patch set 5:Commit-Queue +2

To view, visit change 547366. To unsubscribe, visit settings.

Commit Bot (Gerrit)

unread,

Jun 26, 2017, 4:24:57 PM6/26/17

to Chris harrelson, blink-rev...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org, Philip Rogers, chromium...@chromium.org, Dongseong Hwang

Commit Bot posted comments on this change.

View Change

Patch set 5:

CQ is trying da patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"none" https://chromium-review.googlesource.com/c/547366/5

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/547366/5

Bot data: {"action": "start", "triggered_at": "2017-06-26T20:24:44.0Z", "cq_cfg_revision": "e12d437dc7f395d72995b548c9dacf21b0b1526e", "revision": "ff2d6ea742f85c4eefb3eaa92c79aeb0cf8b09f0"}

To view, visit change 547366. To unsubscribe, visit settings.

Commit Bot (Gerrit)

unread,

Jun 26, 2017, 6:40:03 PM6/26/17

to Chris harrelson, blink-rev...@chromium.org, blink-...@chromium.org, mac-r...@chromium.org, Philip Rogers, chromium...@chromium.org, Dongseong Hwang

Commit Bot merged this change.

View Change

Approvals:
  Philip Rogers: Looks good to me
  Chris harrelson: Commit

Notify PaintLayer if ScrollsOverflow changed.

Bug: 736173
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibafd4af308bb6eca6496d3c95afd8697b767185e

Reviewed-on: https://chromium-review.googlesource.com/547366
Commit-Queue: Chris harrelson <chri...@chromium.org>
Reviewed-by: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#482441}
---
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/platform/linux/fast/overflow/overflow-with-local-background-attachment-expected.png
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/platform/linux/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.txt
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/platform/linux/paint/invalidation/selection/selection-in-non-composited-scrolling-container-expected.txt

34 files changed, 122 insertions(+), 124 deletions(-)

To view, visit change 547366. To unsubscribe, visit settings.

Reply all

Reply to author

Forward