DevTools: replace Console messageURLFilter setting with text filter [chromium/src : master]

Erik Luo (Gerrit)

unread,

May 22, 2018, 4:33:55 PM5/22/18

to Dmitry Gozman, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org

Erik Luo would like Dmitry Gozman to review this change.

View Change

DevTools: replace Console messageURLFilter setting with text filter

Bug: 804611
Change-Id: Idb76d8eed1ed16d39e97e1b67f1abeb7efb4f367
---
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
M third_party/blink/renderer/devtools/front_end/common/Settings.js
M third_party/blink/renderer/devtools/front_end/console/ConsoleView.js
4 files changed, 22 insertions(+), 98 deletions(-)

To view, visit change 1068507. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

May 22, 2018, 4:33:56 PM5/22/18

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Please take a look at this negative patch!

View Change

To view, visit change 1068507. To unsubscribe, or for help writing mail filters, visit settings.

Dmitry Gozman (Gerrit)

unread,

May 23, 2018, 12:45:45 PM5/23/18

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

lgtm

Patch set 1:Code-Review +1

View Change

1 comment:

File third_party/blink/renderer/devtools/front_end/common/Settings.js:
- Patch Set #1, Line 807: }
  You should also call .remove() on the old setting.

To view, visit change 1068507. To unsubscribe, or for help writing mail filters, visit settings.

Erik Luo (Gerrit)

unread,

May 25, 2018, 6:21:43 PM5/25/18

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Thank you, landing!

Patch set 2:Commit-Queue +2

View Change

1 comment:

File third_party/blink/renderer/devtools/front_end/common/Settings.js:

- Patch Set #1, Line 807: }
  You should also call .remove() on the old setting.

- Done

To view, visit change 1068507. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 25, 2018, 6:21:54 PM5/25/18

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"ac" https://chromium-review.googlesource.com/c/1068507/2

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1068507/2

Bot data: {"action": "start", "triggered_at": "2018-05-25T22:21:41.0Z", "cq_cfg_revision": "6a25833cb93164fb378d8087f9dae5fc28fc9b1e", "revision": "6a5be22a0ad6c186950561b5393b9d9cb2fa1924"}

View Change

To view, visit change 1068507. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 25, 2018, 7:32:38 PM5/25/18

to Erik Luo, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Dmitry Gozman, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Commit Bot merged this change.

View Change

Approvals:
  Dmitry Gozman: Looks good to me
  Erik Luo: Commit

DevTools: replace Console messageURLFilter setting with text filter

Bug: 804611
Change-Id: Idb76d8eed1ed16d39e97e1b67f1abeb7efb4f367

Reviewed-on: https://chromium-review.googlesource.com/1068507
Commit-Queue: Erik Luo <lu...@chromium.org>
Reviewed-by: Dmitry Gozman <dgo...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562061}


---
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test-expected.txt
M third_party/WebKit/LayoutTests/http/tests/devtools/console/console-filter-test.js
M third_party/blink/renderer/devtools/front_end/common/Settings.js
M third_party/blink/renderer/devtools/front_end/console/ConsoleView.js

4 files changed, 24 insertions(+), 98 deletions(-)

To view, visit change 1068507. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward