Fifth step of many to porting blink CSP tests to WPT [chromium/src : master]

Andy Paicu (Gerrit)

unread,

Oct 20, 2017, 9:28:02 AM10/20/17

to blink-revie...@chromium.org, blink-...@chromium.org, Mike West, chromium...@chromium.org, Thiago Farina

When does it stop? The pain never ends.

View Change

To view, visit change 730964. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Oct 20, 2017, 9:31:09 AM10/20/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Commit Bot, Mike West, chromium...@chromium.org, Thiago Farina

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/w3c/web-platform-tests/pull/7920.

If this CL lands and Travis CI upstream is green, we will auto-merge the PR.

Note: Please check the Travis CI status (at the bottom of the PR) before landing this CL and only land this CL if the status is green. Otherwise a human needs to step in and resolve it manually. (This may be automated in the future, see https://crbug.com/711447)

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md#Automatic-export-process

View Change

To view, visit change 730964. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Oct 20, 2017, 11:19:50 AM10/20/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Commit Bot, Mike West, chromium...@chromium.org, Thiago Farina

Successfully updated WPT GitHub pull request with new revision "Rebase and upload": https://github.com/w3c/web-platform-tests/pull/7920

View Change

To view, visit change 730964. To unsubscribe, or for help writing mail filters, visit settings.

Mike West (Gerrit)

unread,

Oct 22, 2017, 4:25:53 AM10/22/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Blink WPT Bot, Commit Bot, chromium...@chromium.org, Thiago Farina

:+1:

Patch set 2:Code-Review +1

View Change

To view, visit change 730964. To unsubscribe, or for help writing mail filters, visit settings.

Andy Paicu (Gerrit)

unread,

Oct 23, 2017, 2:18:55 AM10/23/17

to blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Blink WPT Bot, Commit Bot, chromium...@chromium.org, Thiago Farina

Patch set 2:Commit-Queue +2

View Change

To view, visit change 730964. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 23, 2017, 4:20:45 AM10/23/17

to Andy Paicu, blink-revie...@chromium.org, blink-...@chromium.org, Mike West, Blink WPT Bot, chromium...@chromium.org, Thiago Farina

Commit Bot merged this change.

View Change

Approvals:
  Mike West: Looks good to me
  Andy Paicu: Commit

Fifth step of many to porting blink CSP tests to WPT

This has been a long time overdue but there are too many things currently
blocking on this so it's time to look at the blink-contrib folders.

Goals are to:
- make blink-contrib folders contain valid tests that are not only
programatically generated
- get rid of the reliance on checkreport as much as possible in these tests

Bug: 651742
Change-Id: Ic5f9ae5c357d907cd4b88e2fd16c483254e3ac5a
Reviewed-on: https://chromium-review.googlesource.com/730964
Reviewed-by: Mike West <mk...@chromium.org>
Commit-Queue: Andy Paicu <andy...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510734}
---
M third_party/WebKit/LayoutTests/TestExpectations
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib-2/form-action-src-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib-2/form-action-src-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib-2/form-action-src-default-ignored.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib-2/form-action-src-get-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib-2/form-action-src-get-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib-2/form-action-src-javascript-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib-2/form-action-src-redirect-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/resources/postmessage-fail.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/resources/postmessage-pass.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-connect-src-allowed.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-connect-src-allowed.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-connect-src-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-connect-src-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-eval-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-eval-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-from-guid.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-function-function-blocked.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-function-function-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-importscripts-blocked.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-script-src.sub.html
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-script-src.sub.html.sub.headers
D third_party/WebKit/LayoutTests/external/wpt/content-security-policy/blink-contrib/worker-set-timeout-blocked.sub.html.sub.headers
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/connect-src/support/worker-make-xhr-blocked.sub.js
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/connect-src/support/worker-make-xhr-blocked.sub.js.sub.headers
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/connect-src/support/worker-make-xhr.sub.js
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/connect-src/worker-connect-src-allowed.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/connect-src/worker-connect-src-blocked.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/connect-src/worker-from-guid.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-allowed.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-blocked.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-default-ignored.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-get-allowed.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-get-blocked.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-javascript-blocked.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-javascript-blocked.sub.html.sub.headers
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/form-action/form-action-src-redirect-blocked.sub.html
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/frame-src/frame-src-allowed.sub.html
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/frame-src/frame-src-blocked.sub.html
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/frame-src/frame-src-cross-origin-load.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/post-message.js
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-eval.js
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-eval.js.sub.headers
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-function-function.js
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-function-function.js.sub.headers
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-importscripts.js
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-importscripts.js.sub.headers
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-set-timeout.js
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/support/worker-set-timeout.js.sub.headers
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/worker-eval-blocked.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/worker-function-function-blocked.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/worker-importscripts-blocked.sub.html
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/worker-script-src.sub.html
R third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/worker-set-timeout-blocked.sub.html
54 files changed, 246 insertions(+), 346 deletions(-)

To view, visit change 730964. To unsubscribe, or for help writing mail filters, visit settings.

Blink WPT Bot (Gerrit)

unread,

Oct 23, 2017, 5:14:26 AM10/23/17

to Andy Paicu, Commit Bot, blink-revie...@chromium.org, blink-...@chromium.org, Mike West, chromium...@chromium.org, Thiago Farina

The WPT PR for this CL has been merged upstream! https://github.com/w3c/web-platform-tests/pull/7920

View Change

To view, visit change 730964. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward