DevTools: Do not sort async events by endTime. [chromium/src : master]

Alexei Filippov (Gerrit)

unread,

May 25, 2018, 1:41:19 PM5/25/18

to Paul Irish, Andrey Kosyakov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org

Alexei Filippov would like Paul Irish and Andrey Kosyakov to review this change.

View Change

DevTools: Do not sort async events by endTime.

We used to sort async events having the same start time by end time.
That added a non-deterministic behavior causing some events being swapped
if their start time accidentally happens to be the same.

BUG=823837

Change-Id: I6068da8f8c9d2b7a0730003b19bf37fb2d3af590
---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming-expected.txt
M third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming.js
M third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
M third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js
5 files changed, 21 insertions(+), 17 deletions(-)

To view, visit change 1073612. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Filippov (Gerrit)

unread,

May 25, 2018, 1:41:20 PM5/25/18

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, Paul Irish, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

This change is ready for review.

View Change

To view, visit change 1073612. To unsubscribe, or for help writing mail filters, visit settings.

Andrey Kosyakov (Gerrit)

unread,

May 25, 2018, 4:43:24 PM5/25/18

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Paul Irish, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 1073612. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 25, 2018, 6:36:41 PM5/25/18

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, Paul Irish, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Try jobs failed on following builders:
  linux_chromium_rel_ng on luci.chromium.try (JOB_FAILED, https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/103099)

View Change

To view, visit change 1073612. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Filippov (Gerrit)

unread,

May 25, 2018, 9:34:10 PM5/25/18

to apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, Commit Bot, Paul Irish, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Patch set 2:Commit-Queue +2

View Change

To view, visit change 1073612. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 25, 2018, 9:34:21 PM5/25/18

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, Paul Irish, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

CQ is trying the patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"fix a test" https://chromium-review.googlesource.com/c/1073612/2

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/1073612/2

Bot data: {"action": "start", "triggered_at": "2018-05-26T01:34:08.0Z", "cq_cfg_revision": "6a25833cb93164fb378d8087f9dae5fc28fc9b1e", "revision": "ce03d1a2443c7d52a2779520c25809937db6866d"}

View Change

To view, visit change 1073612. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

May 25, 2018, 10:55:32 PM5/25/18

to Alexei Filippov, apavlo...@chromium.org, blink-...@chromium.org, caseq...@chromium.org, kozyatins...@chromium.org, lushnik...@chromium.org, pfeldma...@chromium.org, Andrey Kosyakov, Paul Irish, chromium...@chromium.org, devtools...@chromium.org, Pavel Feldman

Commit Bot merged this change.

View Change

Approvals:
  Andrey Kosyakov: Looks good to me
  Alexei Filippov: Commit

DevTools: Do not sort async events by endTime.

We used to sort async events having the same start time by end time.
That added a non-deterministic behavior causing some events being swapped
if their start time accidentally happens to be the same.

BUG=823837

Change-Id: I6068da8f8c9d2b7a0730003b19bf37fb2d3af590

Reviewed-on: https://chromium-review.googlesource.com/1073612
Commit-Queue: Alexei Filippov <al...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562109}


---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming-expected.txt
M third_party/WebKit/LayoutTests/http/tests/devtools/tracing/timeline-time/timeline-usertiming.js

M third_party/WebKit/LayoutTests/http/tests/devtools/tracing/trace-event-self-time-expected.txt
M third_party/blink/renderer/devtools/front_end/sdk/TracingModel.js
M third_party/blink/renderer/devtools/front_end/timeline_model/TimelineModel.js
6 files changed, 23 insertions(+), 19 deletions(-)

To view, visit change 1073612. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward